On Thu, 16 Feb 2023 01:42:16 GMT, David M. Lloyd wrote:
>> The class generated for lambda proxies is now defined as a hidden class.
>> This means that the counter, which was used to ensure a unique class name
>> and avoid clashes, is now redundant. In addition to performing redundant
>> work,
On Wed, 15 Feb 2023 20:30:00 GMT, Richard Reingruber wrote:
>> This fixes the linked issue by trimming the caller of a frame to be
>> deoptimized back to its `unextended_sp` iff it is compiled. The creation of
>> the section `dead after deoptimization` shown in the attachment
>>
On Wed, 15 Feb 2023 08:15:28 GMT, Alan Bateman wrote:
>I assume you can quickly check which loop, I suspect it's the deflate loop
>based of the previous comments/experiments.
Both of loop's are inf-loops with this change. If somehow I terminate the
first loop then second goes into infinite
On Mon, 23 Jan 2023 02:35:19 GMT, Tingjun Yuan wrote:
> Document `java.util.Arrays.asList` that the list will throw an
> `ArrayStoreException` when attempting to set an element with a wrong type.
This pull request has been closed without being integrated.
-
PR:
On Thu, 16 Feb 2023 04:39:20 GMT, Stuart Marks wrote:
>> I've written a CSR report for this PR as below. Could someone please help
>> me to submit it to the JBS if it looks okay? Thank you!
>>
>> ---
>>
>> **Compatibility Risk:** minimum
>>
>> **Compatibility Risk Description:** No
On Wed, 8 Feb 2023 23:33:57 GMT, Tingjun Yuan wrote:
>> Tingjun Yuan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Arrays.java
>
> I've written a CSR report for this PR as below. Could someone please help me
> to submit it to
> This is an approach to adding a flag to jlink that will allow --compress to
> take the same types of arguments as jmod, thus bringing the two into
> alignment. This likely requires a CSR and a discussion on whether we should
> deprecate or simply remove the original numeric compression
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
> this also impacts build reproducibility for native image
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
> this also impacts build reproducibility for native image
On Wed, 15 Feb 2023 22:44:21 GMT, David M. Lloyd wrote:
>> The class generated for lambda proxies is now defined as a hidden class.
>> This means that the counter, which was used to ensure a unique class name
>> and avoid clashes, is now redundant. In addition to performing redundant
>> work,
On Wed, 15 Feb 2023 22:44:21 GMT, David M. Lloyd wrote:
>> The class generated for lambda proxies is now defined as a hidden class.
>> This means that the counter, which was used to ensure a unique class name
>> and avoid clashes, is now redundant. In addition to performing redundant
>> work,
On Mon, 13 Feb 2023 22:03:14 GMT, Joe Darcy wrote:
> Proceeding down the line of FDLIBM functions to be ported, next up are asin,
> acos, and atan.
>
> Diffs of the various versions will follow in a separate message.
>
> There were no unusual coding idioms encountered in porting these
> Initial pass of porting FDLIBM sinh/cosh/tanh to Java. I do intend to
> refactor the regression tests a bit to reduce duplication, but the actual
> ports should be ready for review.
>
> Diff'ing the ports as before, original vs transliteration port:
>
>
> $ diff -w Hyperbolic.c
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
> this also impacts build reproducibility for native image
> Proceeding down the line of FDLIBM functions to be ported, next up are asin,
> acos, and atan.
>
> Diffs of the various versions will follow in a separate message.
>
> There were no unusual coding idioms encountered in porting these methods.
Joe Darcy has updated the pull request
On Mon, 13 Feb 2023 09:59:24 GMT, Claes Redestad wrote:
> We can improve various String methods such as `startsWith`, `endsWith` and
> `regionMatches` by leveraging the intrinsified mismatch methods in
> `ArraysSupport`.
This pull request has now been integrated.
Changeset: 861e3020
Author:
On Mon, 13 Feb 2023 16:10:14 GMT, Claes Redestad wrote:
>> We can improve various String methods such as `startsWith`, `endsWith` and
>> `regionMatches` by leveraging the intrinsified mismatch methods in
>> `ArraysSupport`.
>
> Claes Redestad has updated the pull request incrementally with one
On Wed, 15 Feb 2023 01:13:16 GMT, Joe Darcy wrote:
>> Proceeding down the line of FDLIBM functions to be ported, next up are asin,
>> acos, and atan.
>>
>> Diffs of the various versions will follow in a separate message.
>>
>> There were no unusual coding idioms encountered in porting these
> This is an approach to adding a flag to jlink that will allow --compress to
> take the same types of arguments as jmod, thus bringing the two into
> alignment. This likely requires a CSR and a discussion on whether we should
> deprecate or simply remove the original numeric compression
On Wed, 15 Feb 2023 20:46:47 GMT, David M. Lloyd wrote:
>> The class generated for lambda proxies is now defined as a hidden class.
>> This means that the counter, which was used to ensure a unique class name
>> and avoid clashes, is now redundant. In addition to performing redundant
>> work,
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote:
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
>
On Mon, 21 Nov 2022 16:46:43 GMT, Strahinja Stanojevic wrote:
>> This PR introduces an option to output stable names for the lambda classes
>> in the JDK. A stable name consists of two parts: The first part is the
>> predefined value `$$Lambda$` appended to the lambda capturing class, and the
On Wed, 15 Feb 2023 12:35:52 GMT, Goetz Lindenmaier wrote:
>> Richard Reingruber has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Improve comment
>> - Improve comment
>> - Spelling
>
> src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line
> This fixes the linked issue by trimming the caller of a frame to be
> deoptimized back to its `unextended_sp` iff it is compiled. The creation of
> the section `dead after deoptimization` shown in the attachment
>
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote:
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
>
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote:
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
>
On Wed, 15 Feb 2023 18:23:02 GMT, Mandy Chung wrote:
>> I think that deprecating the entire plugin could be appropriate, given the
>> overhead, unless there's some performance data to the contrary. I haven't
>> seen much in favor of keeping it, but I do think that breaking it apart from
>>
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote:
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
>
On Mon, 13 Feb 2023 22:05:15 GMT, Mandy Chung wrote:
> `LambdaForm` declares int constants for `BasicType::ordinal` to workaround
> JDK-8161245. Now these int constants are no longer needed.This removes
> these int constants and reference `BasicType` enums directly.
This pull request
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote:
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
>
On Wed, 15 Feb 2023 14:56:27 GMT, Ian Graves wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CompactConstantPoolsPlugin.java
>> line 48:
>>
>>> 46:
>>> 47: public CompactConstantPoolsPlugin() {
>>> 48: super("compact-constant-pools");
>>
>> This plugin
On Wed, 15 Feb 2023 17:32:38 GMT, David M. Lloyd wrote:
> The class generated for lambda proxies is now defined as a hidden class. This
> means that the counter, which was used to ensure a unique class name and
> avoid clashes, is now redundant. In addition to performing redundant work,
>
Thanks Roger.
Let's say you have a `String` that is structured in lines, and for each line
you need to count the occurrences (0 or more) of some character.
A way to process a line is to first search for the next '\n' from the current
position, then to seach for that character starting from the
The class generated for lambda proxies is now defined as a hidden class. This
means that the counter, which was used to ensure a unique class name and avoid
clashes, is now redundant. In addition to performing redundant work, this also
impacts build reproducibility for native image generators
On Mon, 21 Nov 2022 16:46:43 GMT, Strahinja Stanojevic wrote:
>> This PR introduces an option to output stable names for the lambda classes
>> in the JDK. A stable name consists of two parts: The first part is the
>> predefined value `$$Lambda$` appended to the lambda capturing class, and the
Hi Raffaello,
What's the use case, can you give an example?
Seems reasonable; would you also add `lastIndexOf(int ch, int fromIndex,
int toIndex)`?
Not intrinsified, but for symmetry.
Regards, Roger
On 2/15/23 10:47 AM, Raffaello Giulietti wrote:
Hello,
Currently `String` does not expose
Hello,
Currently `String` does not expose a method `indexOf(int ch, int fromIndex, int
toIndex)`, where the 3rd parameter limits the search to positions up to it
(exclusive). JBS issue [1] has been filed as an “Enhancement” to add it to the
codebase.
Before preparing a PR and a CSR, I would
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
On Thu, 9 Feb 2023 14:05:10 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Wed, 15 Feb 2023 14:45:32 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/constantpool/MemberRefEntry.java
>> line 62:
>>
>>> 60: * {@return whether this member is a method}
>>> 61: */
>>> 62: boolean isMethod();
>>
>> this seems surprising -
On Tue, 14 Feb 2023 14:10:08 GMT, Richard Reingruber wrote:
> This fixes the linked issue by trimming the caller of a frame to be
> deoptimized back to its `unextended_sp` iff it is compiled. The creation of
> the section `dead after deoptimization` shown in the attachment
>
On Tue, 14 Feb 2023 20:20:03 GMT, Mandy Chung wrote:
>> Ian Graves has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing up resources
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/CompactConstantPoolsPlugin.java
>
On Thu, 9 Feb 2023 14:04:22 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 14:18:56 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 14:24:58 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 15:07:01 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
On Tue, 14 Feb 2023 14:10:08 GMT, Richard Reingruber wrote:
> This fixes the linked issue by trimming the caller of a frame to be
> deoptimized back to its `unextended_sp` iff it is compiled. The creation of
> the section `dead after deoptimization` shown in the attachment
>
On Wed, 15 Feb 2023 11:32:32 GMT, Lance Andersen wrote:
>> The habit of opening resources in a TwR is hard to break, but I guess it's
>> ok for a test like this. I have inlined the method and removed the TwR.
>
>> The habit of opening resources in a TwR is hard to break, but I guess it's
>> ok
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
On Wed, 15 Feb 2023 09:55:04 GMT, Eirik Bjorsnos wrote:
> The habit of opening resources in a TwR is hard to break, but I guess it's ok
> for a test like this. I have inlined the method and removed the TwR.
Agree, thanks for addressing the suggestion as it makes the test cleaner given
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
On Tue, 14 Feb 2023 23:12:38 GMT, Lance Andersen wrote:
>> Eirik Bjorsnos has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Prefer expectThrows with asserts over test annotation regex
>
>
On Mon, 13 Feb 2023 14:12:15 GMT, Severin Gehwolf wrote:
> Could I please get a review of this trivial comment-only change?
> `imageFile.hpp`
> describes some properties of the jimage file `lib/modules`. However, I don't
> think
> the comment example matches current code in the JDK.
>
> After finding a hash match, getEntryPos needs to compare the lookup name up
> to the encoded entry name in the CEN. This comparison is done by decoding the
> entry name into a String. The names can then be compared using the String
> API. This decoding step adds a significat cost to this
On Tue, 14 Feb 2023 19:30:19 GMT, Severin Gehwolf wrote:
>> Could I please get a review of this trivial comment-only change?
>> `imageFile.hpp`
>> describes some properties of the jimage file `lib/modules`. However, I don't
>> think
>> the comment example matches current code in the JDK.
>>
On Thu, 9 Feb 2023 13:17:30 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line
On Sat, 21 Jan 2023 00:15:10 GMT, Scott Gibbons wrote:
> Added code for Base64 acceleration (encode and decode) which will accelerate
> ~4x for AVX2 platforms.
>
> Encode performance:
> **Old:**
>
> Benchmark (maxNumBytes) Mode Cnt Score Error
> Units
>
On Tue, 14 Feb 2023 18:22:32 GMT, Scott Gibbons wrote:
>> Added code for Base64 acceleration (encode and decode) which will accelerate
>> ~4x for AVX2 platforms.
>>
>> Encode performance:
>> **Old:**
>>
>> Benchmark (maxNumBytes) Mode Cnt Score Error
>> Units
On Thu, 9 Feb 2023 13:10:43 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Thu, 9 Feb 2023 14:01:10 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> AttributeElement.Kind removal (#48)
>
>
On Wed, 15 Feb 2023 02:25:00 GMT, Amit Kumar wrote:
> After reverting all of my changes, I applied your patch and I got time limit
> error, probably because of some inf-loop ?
>
> ```
> result: Error. Agent error: java.lang.Exception: Agent 2 timed out with a
> timeout of 480 seconds; check
On Thu, 9 Feb 2023 13:01:57 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/classfile/constantpool/ClassEntry.java
>> line 80:
>>
>>> 78: * Return a List composed by appending the additions to the base
>>> list.
>>> 79: * @param base The base elements
64 matches
Mail list logo
