On Wed, 8 Mar 2023 20:54:17 GMT, Jorn Vernee wrote:
> @feilongjiang Could you comment on this? If you could figure out the needed
> sizes for RISCV I could add the needed changes to this patch. Otherwise I
> could file a followup issue if that seems more convenient. TIA
Yes, I will take a look
Let's please not kill generic BSD support if at all possible. There is
NetBSD, OpenBSD, FreeBSD, and DragonflyBSD. I know FreeBSD and NetBSD have
OpenJDK 19 and 17 respectively.
On Wed, Mar 8, 2023, 6:54 PM David Holmes wrote:
> On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
>
> > Improvem
On Fri, 3 Mar 2023 21:41:35 GMT, Vladimir Kozlov wrote:
> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
> met
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - S
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
On Tue, 7 Mar 2023 22:55:56 GMT, Justin Lu wrote:
> The java.util.LocaleISOData.isoCountryTable has an incorrect formal name for
> Nepal.
>
> According to [Wikipedia](https://en.wikipedia.org/wiki/Nepal) and the
> [UN](https://www.un.int/protocol/sites/www.un.int/files/Protocol%20and%20Liaiso
On Wed, 8 Mar 2023 23:14:05 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
On Wed, 8 Mar 2023 22:49:42 GMT, Vladimir Kozlov wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 3534:
>>
>>> 3532: __ leave(); // required for proper stackwalking of RuntimeStub frame
>>> 3533: __ ret(0);
>>> 3534:
>>
>> Do we really need to set up a stack frame for these two?
On Wed, 8 Mar 2023 23:14:05 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - S
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
> methods were implemented originally.
>
> Replaced `SharedRun
On Wed, 8 Mar 2023 05:17:53 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for accessing
> annotations. The main differences from `java.lang.reflect.AnnotatedElement`
> are:
> * Each `Annotated` method explicitly specifies the annotation type(s) for
> which it wants annotation data. That is, there is no
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - S
On Wed, 8 Mar 2023 22:27:31 GMT, Dean Long wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove RISC-V port code for float16 intrinsics
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 3534:
>
>> 3532:
On Wed, 8 Mar 2023 22:02:22 GMT, Justin Lu wrote:
> This PR removes the JNI Exception pending defect groups in ClassLoader.c.
>
> `getUTF()` throws an exception and subsequently returns `null`; the exception
> should either be cleared, or control returned to the JVM.
> `JNU_ThrowOutOfMemoryEr
On Wed, 8 Mar 2023 05:17:53 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
This PR removes the JNI Exception pending defect groups in ClassLoader.c.
`getUTF()` throws an exception and subsequently returns `null`; the exception
should either be cleared, or control returned to the JVM.
`JNU_ThrowOutOfMemoryError(env, NULL);` should not be called again
-
Co
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
On Wed, 8 Mar 2023 21:41:31 GMT, Vladimir Ivanov wrote:
> Or encapsulate the constant folding logic (along with the guard) into
> SharedRuntime and return Type* (instead of int/float scalar).
I take this particular suggestion back. `SharedRuntime` is compiler-agnostic
while `Type` is C2-specif
On Wed, 8 Mar 2023 20:55:29 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/opto/convertnode.cpp line 171:
>>
>>> 169: if (t == Type::TOP) return Type::TOP;
>>> 170: if (t == Type::FLOAT) return TypeInt::SHORT;
>>> 171: if (StubRoutines::f2hf() == nullptr) return bottom_type();
>>
>> Wha
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Wed, 8 Mar 2023 19:57:43 GMT, Eirik Bjorsnos wro
On Wed, 8 Mar 2023 19:04:01 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove RISC-V port code for float16 intrinsics
>
> src/hotspot/share/runtime/sharedRuntime.cpp line 451:
>
>> 449
On Wed, 8 Mar 2023 19:57:43 GMT, Eirik Bjorsnos wrote:
> Please review this comment-only PR which fixes incorrect language names
> 'Norwegian Bokmål' and 'Volapük' in the comments in LocaleISOData:
>
> `+ "nb" + "nob" // Norwegian Bokm?l`
> `+ "vo" + "vol" // Volap?k`
>
> These encoding iss
On Wed, 8 Mar 2023 19:57:43 GMT, Eirik Bjorsnos wrote:
> Please review this comment-only PR which fixes incorrect language names
> 'Norwegian Bokmål' and 'Volapük' in the comments in LocaleISOData:
>
> `+ "nb" + "nob" // Norwegian Bokm?l`
> `+ "vo" + "vol" // Volap?k`
>
> These encoding iss
On Wed, 8 Mar 2023 19:38:56 GMT, Vladimir Ivanov wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove RISC-V port code for float16 intrinsics
>
> src/hotspot/share/opto/convertnode.cpp line 171:
>
>> 169: i
On Wed, 8 Mar 2023 05:17:53 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
On Wed, 8 Mar 2023 18:40:05 GMT, Vladimir Kozlov wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> I think you need to add these changes to other ports too and ask for testing
> on them.
@
On Wed, 8 Mar 2023 19:57:43 GMT, Eirik Bjorsnos wrote:
> Please review this comment-only PR which fixes incorrect language names
> 'Norwegian Bokmål' and 'Volapük' in the comments in LocaleISOData:
>
> `+ "nb" + "nob" // Norwegian Bokm?l`
> `+ "vo" + "vol" // Volap?k`
>
> These encoding iss
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
Please review this comment-only PR which fixes incor
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote:
> This patch modifies the `getLastErrorString` method to return a `jstring`.
> Thanks to that we can avoid unnecessary back and forth conversions between
> Unicode and other charsets on Windows.
>
> Other changes include:
> - the Windows
> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for accessing
> annotations. The main differences from `java.lang.reflect.AnnotatedElement`
> are:
> * Each `Annotated` method explicitly specifies the annotation type(s) for
> which it wants annotation data. That is, there is no
On Wed, 8 Mar 2023 05:17:53 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
On Mon, 6 Mar 2023 18:40:47 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the
> sharing mechanism for upcall stubs to AbstractLinker.
>
> This also speeds up upcall stub linking:
Looks good (already reviewed on Panama repo)
-
M
Improvements to support OS specific customization for JDK internal use:
- To select values and code; allowing elimination of unused code and values
- Optionally evaluated by build processes, compilation, or archiving (i.e. CDS)
- Simple API to replace adhoc comparisons with `os.name`
- Clear an
On Wed, 8 Mar 2023 14:52:01 GMT, Jorn Vernee wrote:
>> The issue is that the size of the code buffer is not large enough to hold
>> the whole stub.
>>
>> Proposed solution is to scale the size of the stub with the number of
>> arguments. I've adjusted sizes for both downcall and upcall stubs.
On Wed, 8 Mar 2023 16:23:16 GMT, Paul Sandoz wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address reviews
>
> Java changes look good. The HotSpot code looks well structured but i will let
> others comment on th
> `Vector::slice` is a method at the top-level class of the Vector API that
> concatenates the 2 inputs into an intermediate composite and extracts a
> window equal to the size of the inputs into the result. It is used in vector
> conversion methods where the part number is not 0 to slice the pa
Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the
sharing mechanism for upcall stubs to AbstractLinker.
This also speeds up upcall stub linking:
-
Commit messages:
- update benchmark
- update copyright years
- 8302346: Lift upcall sharing mechanism to A
On Wed, 8 Mar 2023 13:46:03 GMT, Quan Anh Mai wrote:
>> `Vector::slice` is a method at the top-level class of the Vector API that
>> concatenates the 2 inputs into an intermediate composite and extracts a
>> window equal to the size of the inputs into the result. It is used in vector
>> conver
On Wed, 8 Mar 2023 13:48:16 GMT, Quan Anh Mai wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java
>> line 2289:
>>
>>> 2287: getClass(), byte.class, length(),
>>> 2288: this, that, origin,
>>> 2289: new VectorSliceOp() {
>>
> The issue is that the size of the code buffer is not large enough to hold the
> whole stub.
>
> Proposed solution is to scale the size of the stub with the number of
> arguments. I've adjusted sizes for both downcall and upcall stubs. I've also
> dropped the number of relocations, since we're
The issue is that the size of the code buffer is not large enough to hold the
whole stub.
Proposed solution is to scale the size of the stub with the number of
arguments. I've adjusted sizes for both downcall and upcall stubs. I've also
dropped the number of relocations, since we're not really
On Wed, 8 Mar 2023 00:29:05 GMT, Paul Sandoz wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address reviews
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java
> line 2289:
>
>> 2287:
> `Vector::slice` is a method at the top-level class of the Vector API that
> concatenates the 2 inputs into an intermediate composite and extracts a
> window equal to the size of the inputs into the result. It is used in vector
> conversion methods where the part number is not 0 to slice the pa
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy wrote:
> Quick port of IEEEremainder; sorry for missing this earlier. Will add
> targeted tests in a follow-up fix.
src/java.base/share/classes/java/lang/FdLibm.java line 3367:
> 3365: /* purge off exception values */
> 3366: i
This patch modifies the `getLastErrorString` method to return a `jstring`.
Thanks to that we can avoid unnecessary back and forth conversions between
Unicode and other charsets on Windows.
Other changes include:
- the Windows implementation of `getLastErrorString` no longer checks `errno`.
I ve
On Wed, 8 Mar 2023 01:30:58 GMT, Joe Darcy wrote:
> Quick port of IEEEremainder; sorry for missing this earlier. Will add
> targeted tests in a follow-up fix.
src/java.base/share/classes/java/lang/FdLibm.java line 3437:
> 3435: return Zero[sx>>>31]; // unsigned shift
> 3436:
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes
> and this patch converts it to use Classfile API.
>
> This pull request suppose to chain on the 8294982: Implementation of
> Classfile API https://github.com/openjdk/jdk/pull/10982
>
> Please review.
>
> Thank you
On 08/03/2023 10:36, David Holmes wrote:
On 7/03/2023 8:16 pm, Kim Barrett wrote:
On Mar 6, 2023, at 10:11 AM, Aleksei Ivanov
wrote:
On 06/03/2023 13:51, Albert Yang wrote:
Upon a cursory inspection of ForceGC.java, it seems that the
fundamental logic involves waiting for a certain duratio
On 7/03/2023 8:16 pm, Kim Barrett wrote:
On Mar 6, 2023, at 10:11 AM, Aleksei Ivanov wrote:
On 06/03/2023 13:51, Albert Yang wrote:
Upon a cursory inspection of ForceGC.java, it seems that the fundamental logic
involves waiting for a certain duration and relying on chance. However, I am of
t
On Tue, 7 Mar 2023 15:48:58 GMT, Maurizio Cimadamore
wrote:
>> This is common practise across the whole implementation. Do you suggest to
>> remove all similar javadoc from all implementation classes?
>
> Well, if the javadoc simply states the name of the class it doesn't seem very
> useful. B
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Wed, 8 Mar 2023 05:17:53 GMT, Vladimir Kozlov wrote:
>> Implemented `Float.floatToFloat16` and `Float.float16ToFloat` intrinsics in
>> Interpreter and C1 compiler to produce the same results as C2 intrinsics on
>> x64, Aarch64 and RISC-V - all platforms where C2 intrinsics for these Java
>>
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
On Tue, 7 Mar 2023 16:06:17 GMT, Paul Sandoz wrote:
>> `Long:numberOfLeadingZeros` implementation uses more method calls,
>> conditional statements and binary operations. I would prefer to stick with
>> the current implementation for its speed and simplicity.
>
> `numberOfLeadingZeros` is an in
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957))
> will chain to this one.
>
60 matches
Mail list logo
