Re: RFR: 8304443: bootcycle builds fail after JDK-8015831

2023-03-18 Thread Vicente Romero
On Sat, 18 Mar 2023 17:46:00 GMT, Archie L. Cobbs wrote: > The fix for JDK-8015831, which added the new `this-escape` lint warning, > caused the build of the `bootcycle-images` make target to fail. > > This commit adds the additional `@SuppressWarnings("this-escape")` > annotations needed to

Re: RFR: 8304443: bootcycle builds fail after JDK-8015831

2023-03-18 Thread Vicente Romero
On Sat, 18 Mar 2023 17:46:00 GMT, Archie L. Cobbs wrote: > The fix for JDK-8015831, which added the new `this-escape` lint warning, > caused the build of the `bootcycle-images` make target to fail. > > This commit adds the additional `@SuppressWarnings("this-escape")` > annotations needed to

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library

2023-03-18 Thread Mandy Chung
On Fri, 17 Mar 2023 22:01:46 GMT, Mandy Chung wrote: > `ModuleInfoWriter` is not used by the runtime. Move it to the test library > as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the > test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >

RFR: 8304443: bootcycle builds fail after JDK-8015831

2023-03-18 Thread Archie L . Cobbs
The fix for JDK-8015831, which added the new `this-escape` lint warning, caused the build of the `bootcycle-images` make target to fail. This commit adds the additional `@SuppressWarnings("this-escape")` annotations needed to fix it. - Commit messages: - Add

Re: RFR: 8304245: Speed up CharacterData.of by avoiding bit shifting in the latin1 fast-path test [v2]

2023-03-18 Thread Eirik Bjorsnos
On Sat, 18 Mar 2023 17:06:52 GMT, jmehrens wrote: >> We could, but benchmarks show no performance improvements over the current >> PR. I think the current code is perhaps slightly more readable. > > Does non-short-circuit logical AND operator perform similar to baseline? In > this very

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v9]

2023-03-18 Thread Jaikiran Pai
On Sat, 18 Mar 2023 13:17:04 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v8]

2023-03-18 Thread Jaikiran Pai
On Mon, 13 Mar 2023 23:20:35 GMT, Mandy Chung wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> don't hardcode the .jmod extension while determining java.base module >> location > >

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v8]

2023-03-18 Thread Jaikiran Pai
On Tue, 14 Mar 2023 08:30:11 GMT, Alan Bateman wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 953: >> >>> 951: // and supported for creating an image through jlink. Else >>> returns null. >>> 952: private static ByteOrder >>>

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v9]

2023-03-18 Thread Jaikiran Pai
> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being >

Re: RFR: 8304303: implement VirtualThread class notifyJvmti methods as C2 intrinsics [v4]

2023-03-18 Thread Alan Bateman
On Fri, 17 Mar 2023 10:31:46 GMT, Serguei Spitsyn wrote: >> This is needed for future performance/scalability improvements in JVMTI >> support of virtual threads. >> The update includes the following: >> >> 1. Refactored the `VirtualThread` native methods: >> `notifyJvmtiMountBegin`

Re: RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library

2023-03-18 Thread Alan Bateman
On Fri, 17 Mar 2023 22:01:46 GMT, Mandy Chung wrote: > `ModuleInfoWriter` is not used by the runtime. Move it to the test library > as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the > test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` >

Track Classfile API changes on the classfile-api-dev mailing list

2023-03-18 Thread Glavo
Hi everyone, I extracted Classfile API from JDK, ported it back to Java 17, and published it to Maven Central as a standalone library. Here is its repository: https://github.com/Glavo/classfile (I've posted the above on classfile-api-dev, but I don't see it in the mailing list archives. I