On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
Please review this javadoc only change which uses `@snippet` and `@linkplain`
in i18n related util packages.
-
Commit messages:
- copyright years
- property resource bundle changes
- list resource bundle changes
- resource bundle changes
- currency changes
- locale changes
Cha
On Tue, 9 May 2023 20:39:19 GMT, Justin Lu wrote:
> Please review this PR which adds an example snippet to
> `java.time.temporal.WeekFields.of(Locale locale)`
>
> The snippet demonstrates how to create a Locale that has English Locale
> qualities with an ISO-8601 first day of the week.
>
> T
On Wed, 10 May 2023 14:26:54 GMT, Jorn Vernee wrote:
>> FWIW, since Shenandoah changed their load barriers we have been cleaning
>> away the usages of the Access API for loads and stores to primitive values.
>> There's no such support in the C++ Runtime code.
>
> Ok, since this is loading a `lo
On Wed, 10 May 2023 20:28:11 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize th
On Wed, 10 May 2023 20:28:11 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize th
On Wed, 10 May 2023 17:13:13 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Build hotspot libjvm.a and JDK static libraries for
>>
On Wed, 10 May 2023 20:38:50 GMT, Jiangli Zhou wrote:
> > This change caused all our builds but Linux to fail. Did you verify on
> > other platforms than Linux at all? I see you have GHA turned off.
>
> Sorry about the issue. There were failed workflows after I merged with the
> latest JDK mas
On Wed, 10 May 2023 20:24:30 GMT, Erik Joelsson wrote:
> This change caused all our builds but Linux to fail. Did you verify on other
> platforms than Linux at all? I see you have GHA turned off.
Sorry about the issue. There were failed workflows after I merged with the
latest JDK master this
> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
> collation for Swedish to the modern one. In order to provide a means for
> users who need the old collation, this PR intends to make `Collator`
> recognize the `co` Unicode locale extension so that multiple implement
On Wed, 10 May 2023 17:13:13 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Build hotspot libjvm.a and JDK static libraries for
>>
The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
collation for Swedish to the modern one. In order to provide a means for users
who need the old collation, this PR intends to make `Collator` recognize the
`co` Unicode locale extension so that multiple implementations f
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> static
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> static-libs-image/static-libs-bundles targets; This change do
On Tue, 9 May 2023 15:50:13 GMT, Viktor Klang wrote:
> Still relevant to address? /cc @PaulSandoz
This pull request has now been integrated.
Changeset: 8a95020a
Author:Viktor Klang
Committer: Paul Sandoz
URL:
https://git.openjdk.org/jdk/commit/8a95020ab6c61f25954a56e1965529bb2f6f58
On Thu, 6 Apr 2023 22:36:33 GMT, Archie Cobbs wrote:
> IO stream classes like `FileOutputStream` can have assocated NIO channels.
>
> When `close()` is invoked on one of these classes, it in turn invokes
> `close()` on the associated channel (if any). But when the associated
> channel's `close
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Build hotspot libjvm.a and JDK static libraries for
> static-libs-image/static-libs-bundles targets; This change do
On Wed, 10 May 2023 07:48:11 GMT, Viktor Klang wrote:
>> Still relevant to address? /cc @PaulSandoz
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updating copyright year
Marked as reviewed by psandoz (Reviewer).
---
On Wed, 3 May 2023 13:34:12 GMT, Erik Joelsson wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Implemented the review comments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
-
On Fri, 5 May 2023 21:50:06 GMT, Lance Andersen wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Move the pseudo code generation part from setup() to seperate methods.
>
> test/jdk/javax/xml/jaxp/datatype/8033980
On Wed, 10 May 2023 13:53:53 GMT, Stefan Karlsson wrote:
>> I just figured it out. It was introduced by
>> https://bugs.openjdk.org/browse/JDK-8203172 (on aarch64) which mentions
>> Shenandoah and future GCs. However, the Shenandoah comment says
>> "non-reference load, no additional barrier is
On Wed, 10 May 2023 11:16:44 GMT, Martin Doerr wrote:
>> src/hotspot/cpu/ppc/upcallLinker_ppc.cpp line 202:
>>
>>> 200:
>>> 201: MacroAssembler* _masm = new MacroAssembler(&buffer);
>>> 202: address start = __ function_entry(); // called by C
>>
>> If `!defined(ABI_ELFv2)` a function descr
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Wed, 12 Apr 2023 07:12:10 GMT, Julian Waters wrote:
>> C11 has been stable for a long time on all platforms, so native code can use
>> the standard alignas operator for alignment requirements
>
> Julian Waters has updated the pull request incrementally with four additional
> commits since th
On Wed, 10 May 2023 13:43:41 GMT, Martin Doerr wrote:
>> You are reasoning about implementation details. By using the provided
>> abstraction you and other maintainers (who might be unfamiliar with them)
>> would not have to do that. Also the assumptions you make introduce a hidden
>> dependen
On Wed, 10 May 2023 13:33:02 GMT, Richard Reingruber wrote:
>> GC barriers are used when loading or storing an oop. No GC we currently have
>> (not even the generational ones) use barriers for loading a plain address
>> from an oop. The PPC64 implementation of the BarrierSetAssembler currently
On Wed, 10 May 2023 13:24:55 GMT, Martin Doerr wrote:
>> As I see it, the access API is an abstraction to be used instead of raw
>> loads. It hides details. See for instance
>> `TemplateTable::getfield_or_static` on x86 where it is also used. PPC lags
>> behind in making use of the access API.
On Wed, 10 May 2023 13:22:48 GMT, Richard Reingruber wrote:
>>> It does the same but with a more complicated API.
>>
>> AFAIK It depends on the GC that's being used. `access_load_at` will make
>> sure the right GC barriers are inserted (mostly for concurrent GCs).
>
> As I see it, the access AP
On Wed, 10 May 2023 13:07:35 GMT, Jorn Vernee wrote:
>> Interesting. I have no idea why. It does the same but with a more
>> complicated API.
>> I just noticed that other platforms use `NONZERO`. I think I should at least
>> add that.
>
>> It does the same but with a more complicated API.
>
>
On Wed, 10 May 2023 11:23:04 GMT, Martin Doerr wrote:
>> src/hotspot/cpu/ppc/upcallLinker_ppc.cpp line 236:
>>
>>> 234: __ block_comment("{ receiver ");
>>> 235: __ load_const_optimized(R3_ARG1, (intptr_t)receiver, R0);
>>> 236: __ resolve_jobject(R3_ARG1, tmp, R31,
>>> MacroAssembler::PR
On Wed, 10 May 2023 11:13:14 GMT, Martin Doerr wrote:
> It does the same but with a more complicated API.
AFAIK It depends on the GC that's being used. `access_load_at` will make sure
the right GC barriers are inserted (mostly for concurrent GCs).
-
PR Review Comment: https://git.
On Tue, 9 May 2023 23:06:23 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
On Thu, 27 Oct 2022 20:16:14 GMT, Jim Laskey wrote:
> Enhance the Java programming language with string templates, which are
> similar to string literals but contain embedded expressions. A string
> template is interpreted at run time by replacing each expression with the
> result of evaluatin
On Tue, 9 May 2023 15:48:52 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> libTestHFA: Add explicit type conversion to avoid build warning.
>
> src/hotspot/cpu/ppc/vmstorage_ppc.hpp line 81
On Fri, 28 Apr 2023 13:18:27 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert unintended formatting changes. Fix comment.
>
> src/hotspot/cpu/ppc/upcallLinker_ppc.cpp line 236:
>
>> 2
On Thu, 27 Apr 2023 16:19:46 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert unintended formatting changes. Fix comment.
>
> src/hotspot/cpu/ppc/upcallLinker_ppc.cpp line 202:
>
>> 2
On Wed, 26 Apr 2023 14:41:51 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 24 commits:
>>
>> - Adaptation for JDK-8305668
>> - Merge remote-tracking branch 'origin' into PPC64_Pan
On Wed, 26 Apr 2023 14:32:59 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 24 commits:
>>
>> - Adaptation for JDK-8305668
>> - Merge remote-tracking branch 'origin' into PPC64_Pan
On Mon, 27 Mar 2023 16:54:31 GMT, Richard Reingruber wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move ABIv2CallArranger out of linux subdirectory. ABIv1/2 does match the
>> AIX/linux separation.
>
> src/hotspo
> Implementation of "Foreign Function & Memory API" for linux on Power (Little
> Endian) according to "Power Architecture 64-Bit ELF V2 ABI Specification".
>
> This PR does not include code for VaList support because it's supposed to get
> removed by [JDK-8299736](https://bugs.openjdk.org/browse
On Wed, 10 May 2023 09:55:13 GMT, Adam Sotona wrote:
>> That seems misplaced. Please file an RFE to have this cleaned up.
>>
>> Each microbenchmark that has to add opens needs to take responsibility for
>> that themselves and not change the environment for everything else. And all
>> micros t
> Following improvements implemented:
> - Switch over `String` replaced with switch single char
> - Binary search for frames in `StackMapGenerator`
> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
> - `ClassEntry` is caching `ClassDesc` symbol
> - Caching of type symbols in `NameAndT
On Tue, 9 May 2023 16:15:27 GMT, Claes Redestad wrote:
>> They are added in the `make/RunTests.gmk`:
>> https://github.com/openjdk/jdk/pull/13550/files#diff-041bf69ea79b333b9ce99c1f879e398d698538530a35c361500b72631f059233R599-R608
>
> That seems misplaced. Please file an RFE to have this cleaned
On Fri, 5 May 2023 17:25:38 GMT, Aleksei Efimov wrote:
> JNDI `DnsClient` has a finalize method to close its internal datagram channel
> selector.
> The change proposed here replaces it with a cleaner to close the selector
> once the `DnsClient`
> instance becomes phantom reachable.
>
> Th
On Tue, 9 May 2023 23:06:23 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
> Port of: https://git.openjdk.org/panama-foreign/pull/831
Maurizio Cimadamore has updated the pull request with a new target base due to
a merge or a rebase. The pull request now contains four commits:
- Merge branch 'master' into linker_restricted
- Address review comment
- Cleanup code so
> Still relevant to address? /cc @PaulSandoz
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Updating copyright year
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13890/files
- new: https://git.openjdk.org/jdk/p
On Tue, 9 May 2023 16:28:52 GMT, Paul Sandoz wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using apiNote and rewording from method to operation
>
> Marked as reviewed by psandoz (Reviewer).
@PaulSandoz Forgot to
49 matches
Mail list logo
