On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The
On Fri, 12 May 2023 15:24:19 GMT, Volker Simonis wrote:
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start
On Fri, 12 May 2023 20:41:32 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding
On Fri, 12 May 2023 19:38:53 GMT, Roger Riggs wrote:
>> Launching of processes on Windows using `ProcessCreateW` with a Unicode
>> character set requires the buffer to be writable. An access violation might
>> occur if `ProcessCreateW` writes to the command line string. The current
>>
On Thu, 6 Apr 2023 18:07:29 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding
> This PR improves both the worst-case performance of `nextExponential` and
> `nextGaussian` and the distribution of output at the tails. It fixes the
> following imperfections:
>
> * Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a
> rounding error to accumulate at the
On Thu, 11 May 2023 18:27:28 GMT, Justin Lu wrote:
> Please review this PR which adds an initial equality check to
> `RuleBasedCollator.compare(String source, String target)`.
>
> This speeds up the operation for equal input Strings, as it bypasses Collator
> rule comparisons of each element
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The
On Thu, 6 Apr 2023 18:07:29 GMT, Chris Hennick wrote:
>> This PR improves both the worst-case performance of `nextExponential` and
>> `nextGaussian` and the distribution of output at the tails. It fixes the
>> following imperfections:
>>
>> * Repeatedly adding
Hi,
May I have this update reviewed?
The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because of
security concerns. The issue was addressed in
[JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building
failure, and
> Launching of processes on Windows using `ProcessCreateW` with a Unicode
> character set requires the buffer to be writable. An access violation might
> occur if `ProcessCreateW` writes to the command line string. The current
> implementation fetches the command line string using JNI
On Fri, 12 May 2023 18:03:13 GMT, Coleen Phillimore wrote:
>> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>>
>> Main changes:
>> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
>> changes in this PR are protected by this flag.
>> - The
On Fri, 12 May 2023 17:27:25 GMT, Roman Kennke wrote:
> This is the main body of the JEP 450: Compact Object Headers (Experimental).
>
> Main changes:
> - Introduction of the (experimental) flag UseCompactObjectHeaders. All
> changes in this PR are protected by this flag.
> - The compressed
This is the main body of the JEP 450: Compact Object Headers (Experimental).
Main changes:
- Introduction of the (experimental) flag UseCompactObjectHeaders. All changes
in this PR are protected by this flag.
- The compressed Klass* can now be stored in the mark-word of objects. In
order to
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8308016: Remove ellipses ("...") from snippets
-
Changes:
- all:
On Fri, 12 May 2023 17:56:08 GMT, Naoto Sato wrote:
>> Launching of processes on Windows using `ProcessCreateW` with a Unicode
>> character set requires the buffer to be writable. An access violation might
>> occur if `ProcessCreateW` writes to the command line string. The current
>>
On Fri, 12 May 2023 17:56:12 GMT, Justin Lu wrote:
> Please review this trivial fix which updates the IANA data to version
> 5/11/2023. As the update only includes variant sub-tags, there is no impact
> to JDK tests. The update can be found
>
On Fri, 12 May 2023 17:56:12 GMT, Justin Lu wrote:
> Please review this trivial fix which updates the IANA data to version
> 5/11/2023. As the update only includes variant sub-tags, there is no impact
> to JDK tests. The update can be found
>
On Fri, 12 May 2023 17:52:29 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/Console.java line 124:
>>
>>> 122: * if (con != null) {
>>> 123: * Scanner sc = new Scanner(con.reader());
>>> 124: * ...
>>
>> I'm not sure how you
Please review this trivial fix which updates the IANA data to version
5/11/2023. As the update only includes variant sub-tags, there is no impact to
JDK tests. The update can be found
[here](https://mm.icann.org/pipermail/ietf-languages-announcements/2023-May/87.html).
-
On Tue, 9 May 2023 21:46:51 GMT, Roger Riggs wrote:
> Launching of processes on Windows using `ProcessCreateW` with a Unicode
> character set requires the buffer to be writable. An access violation might
> occur if `ProcessCreateW` writes to the command line string. The current
>
On Fri, 12 May 2023 17:31:32 GMT, Justin Lu wrote:
>> Replace `{@code ...}` patterns and the like with `{@snippet
>> lang=java : ...}`.
>
> src/java.base/share/classes/java/io/Console.java line 124:
>
>> 122: * if (con != null) {
>> 123: * Scanner sc = new
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize
On Fri, 12 May 2023 17:25:45 GMT, Justin Lu wrote:
>> Please review changes to `EquivMapsGenerator.java` (which is used to
>> generate the Locale equivalencies for the JDK).
>>
>> The file previously used large concatenated Strings, which are now replaced
>> with text blocks, in addition to
Launching of processes on Windows using `ProcessCreateW` with a Unicode
character set requires the buffer to be writable. An access violation might
occur if `ProcessCreateW` writes to the command line string. The current
implementation fetches the command line string using JNI GetStringChars
On Fri, 12 May 2023 16:17:38 GMT, Brian Burkhalter wrote:
> Replace `{@code ...}` patterns and the like with `{@snippet
> lang=java : ...}`.
src/java.base/share/classes/java/io/Console.java line 124:
> 122: * if (con != null) {
> 123: * Scanner sc = new
On Fri, 12 May 2023 16:41:18 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove more ws in text block
>
> make/jdk/src/classes/build/tools/generatelsrequivmaps/EquivMapsGenerator.java
> line 344:
> Please review changes to `EquivMapsGenerator.java` (which is used to generate
> the Locale equivalencies for the JDK).
>
> The file previously used large concatenated Strings, which are now replaced
> with text blocks, in addition to some cleanup. No functionality is changed,
> the Locale
On Fri, 12 May 2023 16:41:20 GMT, Steven Loomis wrote:
>>> I'm just wondering where a developer might go to get a definitive list,
>>> i.e. aside from this API note, how would they know that "-trad" or
>>> "-traditional" can be used to configure the ordering. Locale.forLanguageTag
>>>
On Fri, 12 May 2023 16:41:20 GMT, Steven Loomis wrote:
>>> I'm just wondering where a developer might go to get a definitive list,
>>> i.e. aside from this API note, how would they know that "-trad" or
>>> "-traditional" can be used to configure the ordering. Locale.forLanguageTag
>>>
On Thu, 11 May 2023 20:39:57 GMT, Justin Lu wrote:
>> Please review this javadoc only change which uses `@snippet` and
>> `@linkplain` in i18n related util packages.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review:
On Thu, 11 May 2023 22:23:47 GMT, Justin Lu wrote:
>> Please review changes to `EquivMapsGenerator.java` (which is used to
>> generate the Locale equivalencies for the JDK).
>>
>> The file previously used large concatenated Strings, which are now replaced
>> with text blocks, in addition to
On Fri, 12 May 2023 16:32:57 GMT, Naoto Sato wrote:
> > I'm just wondering where a developer might go to get a definitive list,
> > i.e. aside from this API note, how would they know that "-trad" or
> > "-traditional" can be used to configure the ordering. Locale.forLanguageTag
> > supports
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize
On Thu, 11 May 2023 20:39:57 GMT, Justin Lu wrote:
>> Please review this javadoc only change which uses `@snippet` and
>> `@linkplain` in i18n related util packages.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review:
On Tue, 17 Jan 2023 15:55:40 GMT, Jan Lahoda wrote:
>> The pattern matching switches are using a bootstrap method
>> `SwitchBootstrap.typeSwitch` to implement the jumps in the switch.
>> Basically, for a switch like:
>>
>> switch (obj) {
>> case String s when s.isEmpty() -> {}
>> case
On Fri, 12 May 2023 08:45:37 GMT, Alan Bateman wrote:
> I'm just wondering where a developer might go to get a definitive list, i.e.
> aside from this API note, how would they know that "-trad" or "-traditional"
> can be used to configure the ordering. Locale.forLanguageTag supports more
>
Replace `{@code ...}` patterns and the like with `{@snippet
lang=java : ...>`.
-
Commit messages:
- 8308016: Use snippets in java.io package
Changes: https://git.openjdk.org/jdk/pull/13957/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=13957=00
Issue:
On Thu, 11 May 2023 10:00:39 GMT, Maurizio Cimadamore
wrote:
> As the title says, this patch fixes an issue with
> `MemorySegment::reinterpet`, which reports the customary "restricted method"
> section twice.
>
> I also fixed some wrong capitalization in the text of the factories in
>
Since JDK13, executing commands in a sub-process defaults to the so called
`POSIX_SPAWN` launching mechanism (i.e.
`-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by using
`posix_spawn(3)` to firstly start a tiny helper program called `jspawnhelper`
in a subprocess. In a
On Fri, 5 May 2023 13:43:43 GMT, Daniel Fuchs wrote:
> Several Handlers class use monitors to synchronize when formatting /
> publishing LogRecords.
> When logging within a VirtualThread, holding this monitor can cause the
> carrier thread to be pinned.
> Handlers could use
On Wed, 10 May 2023 10:00:47 GMT, Adam Sotona wrote:
>> Following improvements implemented:
>> - Switch over `String` replaced with switch single char
>> - Binary search for frames in `StackMapGenerator`
>> - `StackMapGenerator.rawHandlers` with pre-calculated offsets
>> - `ClassEntry` is
On Thu, 11 May 2023 10:00:39 GMT, Maurizio Cimadamore
wrote:
> As the title says, this patch fixes an issue with
> `MemorySegment::reinterpet`, which reports the customary "restricted method"
> section twice.
>
> I also fixed some wrong capitalization in the text of the factories in
>
On Thu, 11 May 2023 18:34:45 GMT, Daniel Fuchs wrote:
>> Several Handlers class use monitors to synchronize when formatting /
>> publishing LogRecords.
>> When logging within a VirtualThread, holding this monitor can cause the
>> carrier thread to be pinned.
>> Handlers could use
Can I please get a review of this test only change which addresses the issue
noted in https://bugs.openjdk.org/browse/JDK-8307403?
When we recently did a change in https://bugs.openjdk.org/browse/JDK-8299748,
there was a oversight that the `deflate.deflate(tempBuffer)` could potentially
end up
This patch adds a simpler method for composing symbol lookups. It is common for
clients to chain multiple symbol lookups together, e.g. to find a symbol in
multiple libraries.
A new instance method, namely `SymbolLookup::or` is added, which first searches
a symbol in the first lookup, and, if
On Thu, 11 May 2023 21:29:51 GMT, Maurizio Cimadamore
wrote:
> This patch fixes the JNI test for the enable native access flag, which was
> updated incorrectly as part of https://git.openjdk.org/jdk/pull/13863.
>
> The problem is that the test doesn't make global references out of the local
On Thu, 11 May 2023 20:51:37 GMT, Naoto Sato wrote:
>> The fix to https://bugs.openjdk.org/browse/JDK-8306927 switched the default
>> collation for Swedish to the modern one. In order to provide a means for
>> users who need the old collation, this PR intends to make `Collator`
>> recognize
48 matches
Mail list logo
