Re: jspawnhelper's sometimes problematic use of argv0

2023-06-17 Thread Daniel Jarabek
Hi Thomas, Thank you for this quick fix! I have tested (after much difficultly getting cross compilation to work - a good learning experience) and this fix works for me. Using QEMU_STRACE, I verified that argv[0] is now the program name and argv[1] contains the fd data. While you are

RFR: JDK-8310265: (process) jspawnhelper should not use argv[0]

2023-06-17 Thread Thomas Stuefe
Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] jspawnhelper uses argv[0] to receive the fd string from the parent. That breaks with conventions and trips over certain tools like binfmt_misc. For details, see linked ML discussion. [1]

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-17 Thread Thomas Stüfe
Mind testing https://github.com/openjdk/jdk/pull/14531 ? On Sat, Jun 17, 2023 at 8:20 PM Thomas Stüfe wrote: > Hi Daniel, > > thank you for that thorough analysis. I opened > https://bugs.openjdk.org/browse/JDK-8310265 to track this issue. > > Looking at the code, this should be easy to fix, we

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-17 Thread Thomas Stüfe
Hi Daniel, thank you for that thorough analysis. I opened https://bugs.openjdk.org/browse/JDK-8310265 to track this issue. Looking at the code, this should be easy to fix, we would not even have to fix jspawnhelper itself, just its spawn point. I did a small patch which seemed to work. But this

Withdrawn: 8304917: Remove unused function declarations in check_classname.h

2023-06-17 Thread duke
On Fri, 17 Mar 2023 14:17:00 GMT, Thiago Henrique Hüpner wrote: > Both functions "VerifyClassname" and "VerifyFixClassname" are not used. The > functions that are used in the Class.c are "verifyClassname" and > "verifyFixClassname", which are declared in the "check_classname.h" header This

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-17 Thread Alan Bateman
On Sat, 17 Jun 2023 00:35:22 GMT, Mandy Chung wrote: >> This PR clarifies the spec of the 3-arg Class::forName regarding the format >> of the name for an array type which is of the form: one or more of "[" + >> binary name of the element type + ";'. > > Mandy Chung has updated the pull

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-17 Thread Alan Bateman
On Fri, 16 Jun 2023 11:41:14 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-17 Thread Alan Bateman
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > This moves the SunEC JCE Provider (Elliptic Curve) into java.base. EC has > always been separate from the base module/pkg because of its dependence on a > native library. That library was removed in JDK 16. The proposed changes

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-17 Thread Alan Bateman
On Fri, 16 Jun 2023 20:32:23 GMT, Weijun Wang wrote: >> Hi, >> >> I need a code review for moving the contents of the jdk.crypto.ec module >> into java.base. This moves the SunEC JCE Provider (Elliptic Curve) into >> java.base. EC has always been separate from the base module/pkg because of

Re: RFR: 8309853: StructuredTaskScope.join description improvements

2023-06-17 Thread Ron Pressler
On Mon, 12 Jun 2023 14:32:07 GMT, Alan Bateman wrote: > StructuredTaskScope's class description introduces the join method as waiting > for all subtasks to finish but the API docs for join/joinUntil are phrased in > terms of waiting for all threads to finish. ShutdownOnXXX join/joinUntil >