Re: RFR: 8310929: Optimization for Integer.toString [v11]

2023-07-01 Thread 温绍锦
> Optimization for: > Integer.toString > Long.toString > StringBuilder#append(int) > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toString*"

Re: RFR: 8310929: Optimization for Integer.toString [v10]

2023-07-01 Thread 温绍锦
On Sun, 2 Jul 2023 02:05:48 GMT, Chen Liang wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> use upper case for static final field > > src/java.base/share/classes/java/lang/StringUTF16.java line 1540: > >> 1538: if

Re: RFR: 8310929: Optimization for Integer.toString [v10]

2023-07-01 Thread Chen Liang
On Sat, 1 Jul 2023 14:12:05 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v20]

2023-07-01 Thread Chen Liang
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based > implementation of MethodHandleProxies.asInterface has a few issues: > 1. Exposes too much information via Proxy supertype (and WrapperInstance > interface) > 2. Does not allow future expansion to support SAM[^1]

Re: RFR: 8310929: Optimization for Integer.toString [v10]

2023-07-01 Thread 温绍锦
On Sun, 2 Jul 2023 01:27:26 GMT, Chen Liang wrote: >> 温绍锦 has updated the pull request incrementally with one additional commit >> since the last revision: >> >> use upper case for static final field > > src/java.base/share/classes/java/lang/StringUTF16.java line 1538: > >> 1536:

Re: RFR: 8310929: Optimization for Integer.toString [v10]

2023-07-01 Thread Chen Liang
On Sat, 1 Jul 2023 14:12:05 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test

Re: RFR: 8311207: Cleanup for Optimization for UUID.toString [v6]

2023-07-01 Thread Chen Liang
On Sat, 1 Jul 2023 14:42:07 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v12]

2023-07-01 Thread Oliver Kopp
On Sat, 1 Jul 2023 18:36:10 GMT, Oliver Kopp wrote: >> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): >> "MethodTooLargeException thrown while creating a jlink image". >> >> Java still has a 64kb limit: A method may not be longer than 64kb. The idea >> of the fix is to

Re: RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-01 Thread Sergey Tsypanov
On Sat, 1 Jul 2023 07:53:17 GMT, Swati Sharma wrote: > The below benchmark files have scaling issues due to cache contention and > leads to poor scaling when run on multiple threads. The patch sets the scope > from benchmark level to thread level to fix the issue: > -

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v12]

2023-07-01 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v6]

2023-07-01 Thread Chen Liang
On Sat, 1 Jul 2023 14:42:07 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v11]

2023-07-01 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v6]

2023-07-01 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v19]

2023-07-01 Thread Chen Liang
On Thu, 29 Jun 2023 03:16:15 GMT, Chen Liang wrote: >> As John Rose has pointed out in this issue, the current j.l.r.Proxy based >> implementation of MethodHandleProxies.asInterface has a few issues: >> 1. Exposes too much information via Proxy supertype (and WrapperInstance >> interface) >>

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v5]

2023-07-01 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8310929: Optimization for Integer.toString [v10]

2023-07-01 Thread 温绍锦
> Optimization for: > Integer.toString > Long.toString > StringBuilder#append(int) > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toString*"

Re: RFR: 8310929: Optimization for Integer.toString [v8]

2023-07-01 Thread Chen Liang
On Fri, 30 Jun 2023 13:27:11 GMT, 温绍锦 wrote: >> Optimization for: >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v10]

2023-07-01 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v9]

2023-07-01 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v8]

2023-07-01 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v7]

2023-07-01 Thread Oliver Kopp
> Fix for [JDK-8240567](https://bugs.openjdk.org/browse/JDK-8240567): > "MethodTooLargeException thrown while creating a jlink image". > > Java still has a 64kb limit: A method may not be longer than 64kb. The idea > of the fix is to split up the generated methods in several smaller methods >

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v6]

2023-07-01 Thread Oliver Kopp
On Thu, 29 Jun 2023 20:58:53 GMT, Mandy Chung wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix threshold > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/SystemModulesPlugin.java > line 691: >

Re: RFR: 8310929: Optimization for Integer.toString [v9]

2023-07-01 Thread 温绍锦
> Optimization for: > Integer.toString > Long.toString > StringBuilder#append(int) > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toString*"

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v6]

2023-07-01 Thread Oliver Kopp
On Thu, 29 Jun 2023 20:26:58 GMT, Mandy Chung wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix threshold > > test/jdk/tools/jlink/JLink100Modules.java line 40: > >> 38: * @library ../lib >> 39: * @modules

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v4]

2023-07-01 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v3]

2023-07-01 Thread ExE Boss
On Sat, 1 Jul 2023 03:22:06 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make

RFR: 8311178: JMH tests don't scale well when sharing output buffers

2023-07-01 Thread Swati Sharma
The below benchmark files have scaling issues due to cache contention and leads to poor scaling when run on multiple threads. The patch sets the scope from benchmark level to thread level to fix the issue: - org/openjdk/bench/java/io/DataOutputStreamTest.java -