Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-31 Thread sid8606
On Mon, 31 Jul 2023 14:27:38 GMT, Amit Kumar wrote: >> src/hotspot/cpu/s390/frame_s390.cpp line 228: >> >>> 226: >>> 227: bool frame::upcall_stub_frame_is_first() const { >>> 228: assert(is_upcall_stub_frame(), "must be optimzed entry frame"); >> >> typo: s/optimzed/optimized > > @sid8606 yo

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v10]

2023-07-31 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: Fix typo Signed-off-by: Sidraya - Changes: - all: https://git.openjdk.org/jdk/pull/14801/file

Re: [jdk21] RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException

2023-07-31 Thread Iris Clark
On Mon, 31 Jul 2023 21:13:16 GMT, Justin Lu wrote: > Please review this change which contains a backport of commit > [c6396dce](https://github.com/openjdk/jdk/commit/c6396dceb9a64578d5b335af27ad1d968190a1fa) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR is a jav

Re: [jdk21] RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException

2023-07-31 Thread Naoto Sato
On Mon, 31 Jul 2023 21:13:16 GMT, Justin Lu wrote: > Please review this change which contains a backport of commit > [c6396dce](https://github.com/openjdk/jdk/commit/c6396dceb9a64578d5b335af27ad1d968190a1fa) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > This PR is a jav

[jdk21] RFR: 8039165: [Doc] MessageFormat null locale generates NullPointerException

2023-07-31 Thread Justin Lu
Please review this change which contains a backport of commit [c6396dce](https://github.com/openjdk/jdk/commit/c6396dceb9a64578d5b335af27ad1d968190a1fa) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This PR is a java.text doc/test-only change. The commit being backported was a

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread David Holmes
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

[jdk21] Integrated: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread David Holmes
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-31 Thread Stuart Marks
Vote: yes On 7/27/23 11:36 AM, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class loader, NIO

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-31 Thread Stuart Marks
Vote: yes On 7/27/23 11:36 AM, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX, Transform

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-31 Thread Stuart Marks
Vote: yes On 7/27/23 11:35 AM, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, files, and b

Re: RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v4]

2023-07-31 Thread Alan Bateman
On Thu, 27 Jul 2023 19:09:00 GMT, Matias Saavedra Silva wrote: >> Currently we exit the VM after static dumping with >> `MetaspaceShared::exit_after_static_dump()`. >> >> >> // We have finished dumping the static archive. At this point, there may be >> pending VM >> // operations. We have

Re: [jdk21] RFR: 8310033: Clarify return value of Java Time compareTo methods

2023-07-31 Thread Naoto Sato
On Mon, 31 Jul 2023 19:48:45 GMT, Roger Riggs wrote: > A doc-only change to improve javadoc in java.time. Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/153#pullrequestreview-1555741239

Re: RFR: 8313406: nep_invoker_blob can be simplified more

2023-07-31 Thread Jorn Vernee
On Mon, 31 Jul 2023 12:22:00 GMT, Yasumasa Suenaga wrote: > In FFM, native function would be called via `nep_invoker_blob`. If the > function has two arguments, it would be following: > > > Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10 > ---

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-31 Thread Iris Clark
Vote: yes Thanks, Iris

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-31 Thread Iris Clark
Vote: yes Thanks, Iris

[jdk21] RFR: 8310033: Clarify return value of Java Time compareTo methods

2023-07-31 Thread Roger Riggs
A doc-only change to improve javadoc in java.time. - Commit messages: - Backport 8650026ff16e5c5eff897f9fd39c0c35fd8b7367 Changes: https://git.openjdk.org/jdk21/pull/153/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=153&range=00 Issue: https://bugs.openjdk.org/browse/J

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-31 Thread Iris Clark
Vote: yes Thanks, Iris

Integrated: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared

2023-07-31 Thread Jim Laskey
On Tue, 27 Jun 2023 19:07:12 GMT, Jim Laskey wrote: > java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent > caching scheme for Carrier objects. The technique used is generally useful > for a variety of caching schemes and is being moved to be shared in other > parts of th

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread Erik Gahlin
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match [v4]

2023-07-31 Thread Raffaello Giulietti
> Fixes a bug showing up after > [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are > capturing groups outside the match. Raffaello Giulietti has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated chan

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

2023-07-31 Thread Roger Riggs
On Fri, 28 Jul 2023 17:39:18 GMT, Amit Kumar wrote: >> Adds `classpath exception` in multiple files, affects copyright header only. > > Amit Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > revert java.lang.foreign changes Since we're

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match [v3]

2023-07-31 Thread Raffaello Giulietti
> Fixes a bug showing up after > [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are > capturing groups outside the match. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Refactored recent tests as JUnit

Re: RFR: 8312976: MatchResult produces StringIndexOutOfBoundsException for groups outside match [v2]

2023-07-31 Thread Raffaello Giulietti
> Fixes a bug showing up after > [JDK-8132995](https://bugs.openjdk.org/browse/JDK-8132995) when there are > capturing groups outside the match. Raffaello Giulietti has updated the pull request incrementally with two additional commits since the last revision: - Added a test with negatvie loo

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v4]

2023-07-31 Thread Brian Burkhalter
> Limit native memory allocation and move write loop from the native layer into > Java. This change should make the OOME reported in the issue much less likely. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 6478546: do-while ->

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread Iris Clark
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: RFR: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out

2023-07-31 Thread Mandy Chung
On Fri, 28 Jul 2023 15:44:54 GMT, Alan Bateman wrote: > This is a test only change to a test that exercises core reflection from > virtual threads. One of the tests (testNewInstance6) uses a custom scheduler > in setup to check that calling a constructor reflectively, where the > constructor p

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread Mandy Chung
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

RFR: 8313406: nep_invoker_blob can be simplified more

2023-07-31 Thread Yasumasa Suenaga
In FFM, native function would be called via `nep_invoker_blob`. If the function has two arguments, it would be following: Decoding RuntimeStub - nep_invoker_blob 0x7fcae394cd10 0x7fcae394cd80: pushq %rbp

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-31 Thread Amit Kumar
On Thu, 13 Jul 2023 07:41:11 GMT, Amit Kumar wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address suggestions from Jorn Vernee > > src/hotspot/cpu/s390/frame_s390.cpp line 228: > >> 226: >> 227: bool frame::upcall_

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-31 Thread sid8606
On Thu, 13 Jul 2023 07:46:00 GMT, Amit Kumar wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address suggestions from Jorn Vernee > > src/java.base/share/classes/jdk/internal/foreign/abi/s390/linux/LinuxS390CallArranger

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v9]

2023-07-31 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: Fix typos Signed-off-by: Sidraya - Changes: - all: https://git.openjdk.org/jdk/pull/14801/fil

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread Daniel Fuchs
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v3]

2023-07-31 Thread Amit Kumar
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Address suggestions from Jorn Vernee src/hotspot/cpu/s

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v8]

2023-07-31 Thread Amit Kumar
On Mon, 31 Jul 2023 14:04:23 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > List all the volatile regs in LinuxS390CallArranger ex

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread sid8606
On Mon, 31 Jul 2023 09:51:44 GMT, sid8606 wrote: >> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 45: >> >>> 43: if (reg == Z_SP) continue; >>> 44: // though Z_R6 is argument register it is a saved register >>> 45: if (!abi.is_volatile_reg(reg) || reg == Z_R6) { >> >> So, is the p

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v8]

2023-07-31 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: List all the volatile regs in LinuxS390CallArranger explicitly Signed-off-by: Sidraya - Changes

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v10]

2023-07-31 Thread Jim Laskey
> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent > caching scheme for Carrier objects. The technique used is generally useful > for a variety of caching schemes and is being moved to be shared in other > parts of the jdk. The MethodType interning case is one example.

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v9]

2023-07-31 Thread Jim Laskey
On Wed, 19 Jul 2023 13:59:00 GMT, Chen Liang wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 15 commits: >> >> - Merge branch 'master' into 8310913 >> - Requested changes. >> >>Added intern with Unar

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread sid8606
On Mon, 31 Jul 2023 08:08:37 GMT, Jorn Vernee wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Preserve and restore register Z_R6 >> >> Though Z_R6 is argument register it is a saved register >> so preserve and re

[jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

2023-07-31 Thread David Holmes
Main changes are to use 21 instead of 21-ea. In addition the following files contain additional updates from the closed sources: - src/java.base/share/man/java.1 [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java manpage markdown source for JFR filename expansion [JDK

Integrated: 8313307: java/util/Formatter/Padding.java fails on some Locales

2023-07-31 Thread Aleksey Shipilev
On Fri, 28 Jul 2023 08:49:20 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ CONF=macosx-aarch64-server-fastdebug make images test > TEST=java/util/Formatter/Padding.java > > ... > STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' > org.opentest4j.AssertionFailedError: expec

Re: RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales [v2]

2023-07-31 Thread Aleksey Shipilev
On Fri, 28 Jul 2023 17:13:54 GMT, Aleksey Shipilev wrote: >> Fails like this: >> >> >> $ CONF=macosx-aarch64-server-fastdebug make images test >> TEST=java/util/Formatter/Padding.java >> >> ... >> STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' >> org.opentest4j.AssertionFailedErr

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-31 Thread Per-Ake Minborg
Vote: Yes. From: core-libs-dev on behalf of Lance Andersen Sent: Friday, July 28, 2023 9:40 PM To: Roger Riggs ; core-libs-dev Subject: Re: CFV: New Core Libraries Group Member: Joe Wang Vote: Yes. On 27/07/2023 19:36, Roger Riggs wrote: I hereby nominate

[jdk21] RFR: 8313023: Return value corrupted when using CCS + isTrivial (mainline)

2023-07-31 Thread Jorn Vernee
Hi all, This pull request contains a backport of commit [6fca2898](https://github.com/openjdk/jdk/commit/6fca28988794b52a6aa974bed1ed6f4f07e0994b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Jorn Vernee on 31 Jul 2023 and was revi

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread Jorn Vernee
On Fri, 28 Jul 2023 03:59:26 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Preserve and restore register Z_R6 > > Though Z_R

Integrated: 8313023: Return value corrupted when using CCS + isTrivial (mainline)

2023-07-31 Thread Jorn Vernee
On Tue, 25 Jul 2023 19:17:38 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/848 from the > panama-foreign repo. > > Copying the PR body here for convenience: > > Due to a bug in the downcall linker stub generation, we don't save the return > value when captu

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v7]

2023-07-31 Thread sid8606
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). sid8606 has updated the pull request incrementally with one additional commit since the last revision: Restructure comment sentence - Changes: - all: https://git.openjdk.org/jdk/pull/14801/files - new

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

2023-07-31 Thread sid8606
On Fri, 28 Jul 2023 12:36:13 GMT, Andrew Haley wrote: >> sid8606 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Preserve and restore register Z_R6 >> >> Though Z_R6 is argument register it is a saved register >> so preserve and r

Integrated: 8313231: Redundant if statement in ZoneInfoFile

2023-07-31 Thread John Jiang
On Thu, 27 Jul 2023 06:46:46 GMT, John Jiang wrote: > if (i < savingsInstantTransitions.length) { > // javazic writes the last GMT offset into index 0! > if (i < savingsInstantTransitions.length) { > offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000; > nOffse

Re: RFR: 8313231: Redundant if statement in ZoneInfoFile

2023-07-31 Thread John Jiang
On Mon, 31 Jul 2023 07:11:24 GMT, Stephen Colebourne wrote: >> if (i < savingsInstantTransitions.length) { >> // javazic writes the last GMT offset into index 0! >> if (i < savingsInstantTransitions.length) { >> offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000; >>

Re: RFR: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out

2023-07-31 Thread Jaikiran Pai
On Fri, 28 Jul 2023 15:44:54 GMT, Alan Bateman wrote: > This is a test only change to a test that exercises core reflection from > virtual threads. One of the tests (testNewInstance6) uses a custom scheduler > in setup to check that calling a constructor reflectively, where the > constructor p

Re: RFR: 8313231: Redundant if statement in ZoneInfoFile

2023-07-31 Thread Stephen Colebourne
On Thu, 27 Jul 2023 06:46:46 GMT, John Jiang wrote: > if (i < savingsInstantTransitions.length) { > // javazic writes the last GMT offset into index 0! > if (i < savingsInstantTransitions.length) { > offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000; > nOffse

Re: RFR: 8313231: Redundant if statement in ZoneInfoFile

2023-07-31 Thread Stephen Colebourne
On Thu, 27 Jul 2023 11:01:23 GMT, Pavel Rappo wrote: >> if (i < savingsInstantTransitions.length) { >> // javazic writes the last GMT offset into index 0! >> if (i < savingsInstantTransitions.length) { >> offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000; >>