Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-17 Thread Alan Bateman
On Mon, 18 Sep 2023 01:44:10 GMT, David Holmes wrote: > Surely that is not a specified exported thread state though ?? Why would we > care about PINNED (timed or otherwise) in the current context? There are internal states and then mappings to the thread states defined by the APIs

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v10]

2023-09-17 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-17 Thread 温绍锦
On Mon, 18 Sep 2023 03:00:25 GMT, Chen Liang wrote: >> 温绍锦 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains ten additional commits since the >>

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v9]

2023-09-17 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-17 Thread Chen Liang
On Mon, 18 Sep 2023 02:53:18 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >>

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v8]

2023-09-17 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids

Re: RFR: 8312498: Thread::getState and JVM TI GetThreadState should return TIMED_WAITING virtual thread is timed parked [v3]

2023-09-17 Thread David Holmes
On Fri, 15 Sep 2023 06:34:52 GMT, Alan Bateman wrote: >> What is TIMED PINNING? >> >> To me TIMED_X are a specific set of states and there are not enough of them >> to consider TIMED to be a bit that can be applied to any state X. > >> What is TIMED PINNING? > > LockSupport.parkNanos when

Re: RFR: 8303525: Refactor/cleanup open/test/jdk/javax/rmi/ssl/SSLSocketParametersTest.java

2023-09-17 Thread Matthew Donovan
On Wed, 19 Jul 2023 12:03:40 GMT, Matthew Donovan wrote: > This PR refactors the SSLSocketParametersTest by removing > redundant/unnecessary classes and cleans up the logic around expected > exceptions. Hi, I'm still looking for a reviewer for this PR. Thanks! - PR Comment:

Re: RFR: 8314891: Additional Zip64 extra header validation [v5]

2023-09-17 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8314891: Additional Zip64 extra header validation [v4]

2023-09-17 Thread Lance Andersen
> Please review this PR which improves the Zip64 extra header validation: > > - Throw a ZipException If the extra len field is 0 and : > -- size, csize, or loc offset are set to 0x > -- disk starting number is set to 0x > > - We have a valid size for the Zip64 extra header but we are

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

2023-09-17 Thread Chen Liang
On Sun, 17 Sep 2023 06:57:46 GMT, ExE Boss wrote: >> Mandy Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix @Param due to the rename from default to class+method > > src/java.base/share/classes/java/lang/StackFrameInfo.java

Re: RFR: 8268829: Provide an optimized way to walk the stack with Class object only [v12]

2023-09-17 Thread ExE Boss
On Thu, 7 Sep 2023 19:27:14 GMT, Mandy Chung wrote: >> 8268829: Provide an optimized way to walk the stack with Class object only >> >> `StackWalker::walk` creates one `StackFrame` per frame and the current >> implementation >> allocates one `StackFrameInfo` and one `MemberName` objects per