On Mon, 18 Sep 2023 21:12:44 GMT, Stuart Marks wrote:
> Wording changes to make clear that the scenarios described are merely
> examples and are not normative requirements.
Looks good.
-
Marked as reviewed by bchristi (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15799#
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Al
On Thu, 21 Sep 2023 08:32:21 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316000: Move apiNotes to normative text; update @return descriptions
>
> src/java.base/share/classes/java/io/File.
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally w
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Update full name
-
Changes:
- all
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally w
On Fri, 22 Sep 2023 20:45:39 GMT, Lance Andersen wrote:
> Overall, this is fine.
>
> I would like to suggest comments to introduce all tests and DataProviders.
> Extra credit for helper methods.
>
> From a future maintainers Point of view, having more info in the tests is
> beneficial.
Thank
On Fri, 22 Sep 2023 15:27:51 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo found in code review.
>
> test/jdk/java/lang/Math/WorstCaseTests.java line 325:
>
>> 323:
>> 324:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
> details the inputs with generate the worst-case observed
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
> details the inputs with generate the worst-case observed
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote:
>> Please review this PR which converts some tests under _Calendar_ to use
>> JUnit. These tests either previously used the internal _IntlTest_, or used
>> no framework at all.
>>
>> Any files named BugXXX.java will be renamed after revie
On Fri, 22 Sep 2023 19:50:49 GMT, Justin Lu wrote:
>> Please review this PR which converts some tests under _Calendar_ to use
>> JUnit. These tests either previously used the internal _IntlTest_, or used
>> no framework at all.
>>
>> Any files named BugXXX.java will be renamed after revie
On Fri, 22 Sep 2023 19:44:00 GMT, Justin Lu wrote:
>> test/jdk/java/util/Calendar/Bug4766302.java line 32:
>>
>>> 30: import java.util.GregorianCalendar;
>>> 31:
>>> 32: @SuppressWarnings("serial")
>>
>> Is removing this OK?
>
> At first I thought so, there is no warning about a missing serial
On Thu, 21 Sep 2023 22:18:04 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: revert removal of SupressWarnings annotation
>> - Reflect review comments
>
> test/jdk/java/util/Calendar/Bug4766
> Please review this PR which converts some tests under _Calendar_ to use
> JUnit. These tests either previously used the internal _IntlTest_, or used no
> framework at all.
>
> Any files named BugXXX.java will be renamed after review.
Justin Lu has updated the pull request incrementally w
On Fri, 22 Sep 2023 06:44:16 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Review: revert removal of SupressWarnings annotation
>> - Reflect review comments
>
> test/jdk/java/util/Calendar/Bu
On Thu, 14 Sep 2023 17:06:53 GMT, Mandy Chung wrote:
> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
> intends to change the initial batch size only for a stack walker with an
> estimated stack depth. For stack walkers without user-supplied estimated
> stack depth
On Fri, 22 Sep 2023 17:32:32 GMT, Mandy Chung wrote:
>> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
>> intends to change the initial batch size only for a stack walker with an
>> estimated stack depth. For stack walkers without user-supplied estimated
>> stack d
On Fri, 22 Sep 2023 17:08:48 GMT, Mourad Abbay wrote:
>> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
>> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
> By correctly sizing an intermediate `byte[]` and making use of the internal
> `newStringNoRepl()` method, one allocation per conversion can be avoided when
> the runtime uses compact strings.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the l
> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
> intends to change the initial batch size only for a stack walker with an
> estimated stack depth. For stack walkers without user-supplied estimated
> stack depth, the initial batch size is changed to 3 which is a bug
On Thu, 14 Sep 2023 21:53:30 GMT, Brian Burkhalter wrote:
> Add a `finally` block to delete the created files. Convert the test to JUnit
> 5.
This pull request has now been integrated.
Changeset: 373cdf25
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/373cdf257de78
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Display links to Stream.flatMap and Stream.mapMul
On Fri, 22 Sep 2023 16:29:51 GMT, Jorn Vernee wrote:
>> I forgot about the change that went into mainline. Do you have a link of the
>> latest javadoc? I'd like to check how the method summary looks.
>
> Here you go:
> https://cr.openjdk.org/~jvernee/FFM_22_PR_v1/java.base/java/lang/foreign/Seg
On Tue, 19 Sep 2023 22:49:36 GMT, Naoto Sato wrote:
> Fixing a test case that fails in some time zones. Making sure the test is run
> in `UTC` zone will fix the issue. Confirmed the fix by manually setting
> machine's time zone to Europe/Dublin.
This pull request has now been integrated.
Chan
On Thu, 21 Sep 2023 18:51:50 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request in
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
On Fri, 22 Sep 2023 13:41:50 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Avoid eager use of LibFallback in FallbackLinker static block
>
> src/java.base/share/classes/java/lang/foreign/
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Thu, 21 Sep 2023 19:19:34 GMT, Joe Darcy wrote:
> The Math.hypot method claims its error bound is one ulp.
>
> The paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double
> Extended, and Quadruple Precision"
> Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> September
On Fri, 22 Sep 2023 15:19:35 GMT, Maurizio Cimadamore
wrote:
>> I don't mind changing it back to the old style, but I think the style should
>> be consistent for all the allocateFrom overloads? So, I'd have to change all
>> of them back.
>
> I forgot about the change that went into mainline. D
On Fri, 22 Sep 2023 16:02:49 GMT, Mourad Abbay wrote:
>> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
>> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Display links to Stream.flatMap and Stream.mapMul
On Mon, 31 Jul 2023 17:02:15 GMT, Brian Burkhalter wrote:
>> Limit native memory allocation and move write loop from the native layer
>> into Java. This change should make the OOME reported in the issue much less
>> likely.
>
> Brian Burkhalter has updated the pull request incrementally with on
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
> det
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
> det
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote:
> A new paper
>
> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and
> Quadruple Precision"
> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann
> https://members.loria.fr/PZimmermann/papers/accuracy.pdf
>
> det
On Fri, 22 Sep 2023 14:44:11 GMT, Glavo wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since t
On Fri, 22 Sep 2023 15:20:05 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 22 Sep 2023 15:26:45 GMT, Chen Liang wrote:
> Just curious, for `Enable-Native-Access`, if it's present on an automatic
> module `Automatic-Module-Name` jar, can it apply to only that automatic
> module instead of all unnamed modules?
No. It's only there for executable jars (run using
On Fri, 22 Sep 2023 14:35:12 GMT, Jorn Vernee wrote:
>> I think I did the same when resolving the merge
>
> I don't mind changing it back to the old style, but I think the style should
> be consistent for all the allocateFrom overloads? So, I'd have to change all
> of them back.
I forgot about
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Mon, 18 Sep 2023 14:17:30 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 22 Sep 2023 13:39:00 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Avoid eager use of LibFallback in FallbackLinker static block
>
> src/java.base/share/classes/java/lang/foreign/
On Fri, 22 Sep 2023 13:50:37 GMT, 温绍锦 wrote:
>> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 115:
>>
>>> 113: }
>>> 114: return 10 + d;
>>> 115: }
>>
>> @wenshao How about of using
>> [this](https://github.com/plokhotnyuk/jsoniter-scala/blob/6b72cf7
On Thu, 21 Sep 2023 15:35:16 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Use assertEquals
Looking good.
It may be useful t
On Fri, 22 Sep 2023 14:29:35 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Avoid eager use of LibFallback in FallbackLinker static block
>
> test/micro/org/openjdk/bench/java/lang/foreign
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and a
On Fri, 22 Sep 2023 14:10:58 GMT, Maurizio Cimadamore
wrote:
>> Also, in the panama repo I see this:
>>
>> Allocates a memory segment with the given layout and initializes it with the
>> bytes in the provided source memory segment.
>>
>> Which seems more correct - e.g. more consistent with ot
On Fri, 22 Sep 2023 14:31:30 GMT, Jorn Vernee wrote:
>> This was changed in the main line repo as a result of:
>> https://github.com/openjdk/jdk/pull/14997 Since all the other methods were
>> using `{@return ...}` I changed this new overload to that style as well.
>
> I think I did the same whe
On Fri, 22 Sep 2023 14:31:08 GMT, Jorn Vernee wrote:
>> Panama repo change:
>> https://github.com/openjdk/panama-foreign/commit/06e2017883c939188103c4dd53185417a00b2921
>>
>> But, this code was altered in a follow up merge - maybe the merge was
>> problematic?
>
> This was changed in the main l
On Mon, 18 Sep 2023 14:17:30 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 22 Sep 2023 14:08:29 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/foreign/SegmentAllocator.java line 310:
>>
>>> 308:
>>> 309: /**
>>> 310: * {@return a new memory segment with a {@linkplain
>>> MemorySegment#byteSize() byteSize()} of
>>
>> Sugges
On Fri, 22 Sep 2023 14:03:52 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Avoid eager use of LibFallback in FallbackLinker static block
>
> src/java.base/share/classes/java/lang/foreign/
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
I recommend just work in the same PR and change all `@see #mapMulti` to `@see
#mapMulti mapMulti` and `@
On Mon, 18 Sep 2023 14:17:30 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Fri, 22 Sep 2023 11:06:13 GMT, Chen Liang wrote:
>> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
>> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
>
> Then it's a bug with Intellij IDEA not able to parse these links correctly.
> It should be fixed in t
On Fri, 22 Sep 2023 11:53:18 GMT, Andriy Plokhotnyuk wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> restore HexDigits & OctalDigits
>
> src/java.base/share/classes/jdk/internal/util/DecimalDigits.java line 115:
>
>> 113:
On Mon, 18 Sep 2023 14:17:30 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Tue, 19 Sep 2023 15:35:11 GMT, Tim Prinzing wrote:
>> The socket read/write JFR events currently use instrumentation of java.base
>> code using templates in the jdk.jfr modules. This results in some java.base
>> code residing in the jdk.jfr module which is undesirable.
>>
>> JDK19 added sta
On Fri, 22 Sep 2023 11:37:18 GMT, Chen Liang wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> restore HexDigits & OctalDigits
>
> src/java.base/share/classes/java/util/FormatItem.java line 148:
>
>> 146: int len
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and a
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
Then it's a bug with Intellij IDEA not able to parse these links correctly. It
should be fixed in their
On Thu, 21 Sep 2023 16:40:59 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and a
On Fri, 22 Sep 2023 08:42:39 GMT, Chen Liang wrote:
>> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
>> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
>
> What is this patch looking to fix? The link is not broken in the first place.
> This `#mapMulti mapMu
On Sun, 17 Sep 2023 16:01:33 GMT, 温绍锦 wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
>
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
温绍锦 has updated the pull request incrementally with one additional commit since
the last revision
On Sun, 17 Sep 2023 16:01:33 GMT, 温绍锦 wrote:
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
>
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
What is this patch looking to fix? The link is not broken in the first place.
This `#mapMulti mapMulti`
On Fri, 22 Sep 2023 07:19:27 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
温绍锦 has updated the pull request incrementally with one additional commit since
the last revision
On Thu, 21 Sep 2023 18:51:50 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request in
77 matches
Mail list logo
