On Thu, 28 Sep 2023 15:01:25 GMT, Raffaello Giulietti
wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> Refactor according to rgiulietti's suggestion and add testcases
>
> Meaningful external reviews take a _lot_ of
On Mon, 2 Oct 2023 05:40:03 GMT, 温绍锦 wrote:
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make
I submitted PR #1 before, and there were too many changes. I split it into
multiple PRs with small changes. This one is one of them.
this PR removed the duplicate code for getChars in
BigDecimal#StringBuilderHelper, i also make performance faster, Here are the
numbers run on a MacBook M1
On Fri, 8 Sep 2023 14:50:15 GMT, Claes Redestad wrote:
> Seems like a step in the right direction w.r.t. code duplication. There's
> still a lot going on in this PR so it'll take some time to digest. Is there
> some way to split this into a series of enhancements for easier review? The
>
Add a new factory method so that a CatalogResolver can be created with a
resolve property on top of the Catalog object.
-
Commit messages:
- 8316996: Catalog API Enhancement: add a factory method
Changes: https://git.openjdk.org/jdk/pull/16045/files
Webrev:
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
On Wed, 4 Oct 2023 17:17:57 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. This was found during upgrading
> CLDR to v44, in which some list patterns are missing (thus to be inherited
> from parents) in Norwegian locales which could end up with infinite parent
> lookup.
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It repackages all uses across JDK
> In the Windows implementation of java.io.File.getCanonicalPath, strip any
> long path or UNC prefix before canonicalizing the remainder of the pathname.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8287843: Remove unused
On Wed, 13 Sep 2023 01:12:52 GMT, Mandy Chung wrote:
> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
> APIs if the method's variable arity modifier bit is set and
> `asVarargsCollector` fails. It will include the exception message thrown by
>
On Wed, 13 Sep 2023 17:52:22 GMT, Mandy Chung wrote:
>> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
>> APIs if the method's variable arity modifier bit is set and
>> `asVarargsCollector` fails. It will include the exception message thrown by
>>
On Wed, 13 Sep 2023 17:52:22 GMT, Mandy Chung wrote:
>> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
>> APIs if the method's variable arity modifier bit is set and
>> `asVarargsCollector` fails. It will include the exception message thrown by
>>
On Wed, 13 Sep 2023 17:52:22 GMT, Mandy Chung wrote:
>> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
>> APIs if the method's variable arity modifier bit is set and
>> `asVarargsCollector` fails. It will increase the exception message thrown
>> by
Please review the fix to the subject issue. This was found during upgrading
CLDR to v44, in which some list patterns are missing (thus to be inherited from
parents) in Norwegian locales which could end up with infinite parent lookup.
Avoiding the recursive call and changing it to a plain loop
j.t.DateTimeFormatter defines ISO_LOCAL_DATE, j.u.Formatter.DateTime also
defines ISO_STANDARD_DATE ("%tF"), and now their behavior is different outside
the range of [0,], We run the following code and we can see their different
behaviors:
```java
DateTimeFormatter formatter =
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
On Tue, 3 Oct 2023 09:08:31 GMT, Maurizio Cimadamore
wrote:
>> Aggelos Biboudis has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
On Tue, 3 Oct 2023 09:13:30 GMT, Maurizio Cimadamore
wrote:
>> Aggelos Biboudis has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
On Thu, 28 Sep 2023 13:13:31 GMT, Maurizio Cimadamore
wrote:
> This patch adds a new lint warning category, namely `-Xlint:restricted` to
> enable warnings on restricted method calls.
>
> The patch is relatively straightforward: javac marks methods that are marked
> with the `@Restricted`
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
> This is the first draft of a patch for Primitive types in patterns,
> instanceof, and switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses across JDK and tests and adds lots of missing Javadoc.
>
> This PR
23 matches
Mail list logo
