On Fri, 27 Oct 2023 16:34:20 GMT, Ioi Lam wrote:
>> Calvin Cheung has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge master
>> - skip archiving full module graph is there is an incubator module
>> - fix
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
> the main module is specified. The module name will be stored in t
On Wed, 1 Nov 2023 00:06:35 GMT, Leonid Mesnik wrote:
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder().
I'm not sure I agree with that. I think the test factory is a separate testing
dimension, independent of JV
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
Okay.
If 2min testing time is not acceptable in tier1 for vector api, I agree with
@A
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
> May I ask how long it will take to run jdk_vector_sanity?
>
> My testing in JDK-8295
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
May I ask how long it will take to run jdk_vector_sanity?
My testing in JDK-8295970 wa
Test thread factory is a mode similar to VM flags and should not be used in
ProcessTools.createLimitedTestJavaProcessBuilder(). Only
createTestJavaProcessBuilder() should use it like jtreg VM options.
Adding the test thread factory requires the injection of arguments in the
middle of the list.
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote:
> Changing from `Class c` to `Class c` removes two warnings.
Marked as reviewed by lmesnik (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1707376126
On Tue, 31 Oct 2023 09:09:37 GMT, Alan Bateman wrote:
> Thanks, it looks correctly now.
Thanks!
>
> One small question. At ModuleBootstrap L235 we set canArchive as it's okay to
> archive under specific restrictions. For completeness, shouldn't this set
> canArchive to CDS.isDumpingStaticArc
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
jdk_vector_sanity was added by JDK-8295970 to get some coverage in tier1. That
motivat
Due to their longer-than-typical running time and because the vector API is not
(yet) in the base module, move the vector API tests in tier 1 to tier 2.
-
Commit messages:
- JDK-8319195: Move tier 1 vector API regression tests to tier 2
Changes: https://git.openjdk.org/jdk/pull/164
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
As a check on the semantics of the change, `jtreg -l ...` output for tier 1 and
tier 2
On Tue, 31 Oct 2023 17:15:50 GMT, Leo Korinth wrote:
>> Updates to javadoc after improvement ideas in the review of 8315097. I have
>> also removed the incomplete invocation command line. I also removed
>> incomplete information in `executeTestJvm` and added a link to
>> `createLimitedTestJava
On Tue, 31 Oct 2023 17:15:50 GMT, Leo Korinth wrote:
>> Updates to javadoc after improvement ideas in the review of 8315097. I have
>> also removed the incomplete invocation command line. I also removed
>> incomplete information in `executeTestJvm` and added a link to
>> `createLimitedTestJava
> Updates to javadoc after improvement ideas in the review of 8315097. I have
> also removed the incomplete invocation command line. I also removed
> incomplete information in `executeTestJvm` and added a link to
> `createLimitedTestJavaProcessBuilder`
Leo Korinth has updated the pull request i
On Tue, 31 Oct 2023 16:08:54 GMT, Alan Bateman wrote:
>> JImageValidator has been recently converted to use ClassFile API and
>> original weak validation of class files was replaced with full class
>> verification.
>> Unfortunately full class verification is too strong as it includes class
>>
On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona wrote:
> JImageValidator has been recently converted to use ClassFile API and original
> weak validation of class files was replaced with full class verification.
> Unfortunately full class verification is too strong as it includes class
> assignabi
On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona wrote:
> JImageValidator has been recently converted to use ClassFile API and original
> weak validation of class files was replaced with full class verification.
> Unfortunately full class verification is too strong as it includes class
> assignabi
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
@TobiHartmann might I ask you for a review of this trivial PR, or to suggest an
a
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote:
> Changing from `Class c` to `Class c` removes two warnings.
LGTM
-
Marked as reviewed by mli (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1706582873
On Fri, 25 Aug 2023 09:37:47 GMT, Masanori Yano wrote:
> I want to add a log output similar to JDK-8301627 to Runtime.halt().
> To avoid double logging of Runtime.exit(), add a flag to indicate whether
> logging was done, and fix it so that logging is done only once.
> Could someone please revie
On Tue, 31 Oct 2023 07:19:53 GMT, Leo Korinth wrote:
> Updates to javadoc after improvement ideas in the review of 8315097. I have
> also removed the incomplete invocation command line. I also removed
> incomplete information in `executeTestJvm` and added a link to
> `createLimitedTestJavaProc
On Fri, 27 Oct 2023 10:31:35 GMT, Alan Bateman wrote:
> > Hey stuart-marks (cc liach @AlanBateman ExE-Boss), I think this discussion
> > has stalled a bit. Would it be an idea to at least push this commit through.
>
> No, as I don't think there is agreement yet on this direction. Also all of
>
On Mon, 30 Oct 2023 15:57:23 GMT, Andrew Haley wrote:
> The bug here is a thinko in `ScopedValue.scopedValueBindings()`.
>
> If the JVM runs out of resources, we throw a `VirtualMachineError`. Running
> out of resources can happen at almost any time, and can happen while
> `ScopedValue`'s inte
I will ask for a step further and add an overload to collect that takes a
Gatherer and calls gather(gatherer).collect(Collectors.singleton()) so we can
directly write
var neatlyFolded = stream.collect(fold(...));
As a user, I see value in using the more powerful Gatherer API like a collector
On Mon, 30 Oct 2023 14:54:08 GMT, Viktor Klang wrote:
> Discussed with @DougLea and adjusting the queue capacity to at least the
> number of participating threads seems like the most sensible fix.
This pull request has now been integrated.
Changeset: e05cafda
Author:Viktor Klang
Committer
On Mon, 16 Oct 2023 16:31:04 GMT, Brian Burkhalter wrote:
> The CSR was created.
Thanks. I changed the "Compatibility Risk" to medium and expanded its
description to more clearly explain the compatibility risk to fix this long
standing issue.
-
PR Comment: https://git.openjdk.org
On Mon, 30 Oct 2023 15:07:49 GMT, Viktor Klang wrote:
>> Discussed with @DougLea and adjusting the queue capacity to at least the
>> number of participating threads seems like the most sensible fix.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since t
On Tue, 31 Oct 2023 06:17:34 GMT, Calvin Cheung wrote:
> I've added the following field in `ArchivedModuleGraph` so that the
> `get(String mainModuleName)` will check the `mainModule` before returning
> `archivedModuleGraph`. `private static String mainModule;` The `mainModule`
> field is also
On Tue, 31 Oct 2023 06:11:50 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Mon, 30 Oct 2023 17:16:54 GMT, Andrew Haley wrote:
>> The bug here is a thinko in `ScopedValue.scopedValueBindings()`.
>>
>> If the JVM runs out of resources, we throw a `VirtualMachineError`. Running
>> out of resources can happen at almost any time, and can happen while
>> `ScopedValue`'s
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote:
> Changing from `Class c` to `Class c` removes two warnings.
Looks fine and trivial.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1705674609
Changing from `Class c` to `Class c` removes two warnings.
-
Commit messages:
- 8319153: Fix: Class is a raw type in ProcessTools
Changes: https://git.openjdk.org/jdk/pull/16431/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16431&range=00
Issue: https://bugs.openjdk.org/
Updates to javadoc after improvement ideas in the review of 8315097. I have
also removed the incomplete invocation command line. I also removed incomplete
information in `executeTestJvm` and added a link to
`createLimitedTestJavaProcessBuilder`
-
Commit messages:
- 8318962: Javado
> Hi All,
>
> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
> AVX512 features.
>
> Following is the summary of changes:-
>
> 1) Intrinsify sub-word gather with high performance backend implementation
> based on hybrid algorithm which initially partially unrolls s
35 matches
Mail list logo
