On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
Adding hotspot label because from the looks of this change, it appears to
require
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote:
> Changing from `Class c` to `Class c` removes two warnings.
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16431#pullrequestreview-1709548049
On Thu, 2 Nov 2023 01:00:38 GMT, Mandy Chung wrote:
> The test fails on windows because unmatched comparison of `Path.toString()`
> vs `URL.getPath().toString()` after JDK-8317965. A simple fix is to
> evaluate the JAR file path in the same way as `LoadLibraryDeadlock` does.
Marked as review
On Thu, 2 Nov 2023 02:02:18 GMT, Joe Darcy wrote:
>> Due to their longer-than-typical running time and because the vector API is
>> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit
On Thu, 2 Nov 2023 02:11:19 GMT, Jie Fu wrote:
> LGTM
>
> If tier2 is unchanged after this patch, it would be good to change the JBS
> title. Thanks.
Good point; bug and PR titles updated accordingly. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/16437#issuecomment-17900
On Thu, 2 Nov 2023 02:48:34 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
> Please review this changeset for adding support for `--module` (-m) option
> for CDS.
> Changes in the `ModuleBootstrap.java` are needed so that the
> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
> the main module is specified. The module name will be stored in t
On Thu, 2 Nov 2023 02:02:18 GMT, Joe Darcy wrote:
>> Due to their longer-than-typical running time and because the vector API is
>> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit
On Wed, 1 Nov 2023 20:36:38 GMT, Joe Darcy wrote:
>> I would suggest to determine the set of tests which run "at most 10 seconds
>> total" and run only them in tier1.
>> Also taking into account API coverage.
>
>> I would suggest to determine the set of tests which run "at most 10 seconds
>> to
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
--
The test fails on windows because unmatched comparison of `Path.toString()` vs
`URL.getPath().toString()` after JDK-8317965. A simple fix is to evaluate the
JAR file path in the same way as `LoadLibraryDeadlock` does.
-
Commit messages:
- 8319265: TestLoadLibraryDeadlock.java fai
On Wed, 1 Nov 2023 17:54:00 GMT, Mandy Chung wrote:
> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for 5
> seconds and then grab the output. Then run `jcmd` to dump the thread stacks
> in case there is a deadlock. The test ignores and swallows any exception
> which m
On Wed, 1 Nov 2023 14:52:23 GMT, Raffaello Giulietti
wrote:
>> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
>> improving guarantees of internal invariants.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the las
On Wed, 1 Nov 2023 20:36:38 GMT, Joe Darcy wrote:
>> I would suggest to determine the set of tests which run "at most 10 seconds
>> total" and run only them in tier1.
>> Also taking into account API coverage.
>
>> I would suggest to determine the set of tests which run "at most 10 seconds
>> to
Please review this simple change which refines the specification of some
NumberFormat methods (with unsupported operations) to separate the API and
implementation specification.
-
Commit messages:
- cleanup setRoundingMode()
- Merge branch 'master' into JDK-8318466-NumberFormat-Un
On Thu, 5 Oct 2023 20:44:55 GMT, Justin Lu wrote:
> Please review this PR which updates ChoiceFormat and MessageFormat to no
> longer call overridable methods in their constructors.
>
> The overridable methods called in the constructors are:
> _ChoiceFormat::applyPattern_, _ChoiceFormat::setCh
On Wed, 1 Nov 2023 19:11:28 GMT, Vladimir Kozlov wrote:
> I would suggest to determine the set of tests which run "at most 10 seconds
> total" and run only them in tier1. Also taking into account API coverage.
Okay; I think preserving a handful of tests to check for a dead-on-arrival
vector ch
On Wed, 1 Nov 2023 19:46:33 GMT, Mandy Chung wrote:
>> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for
>> 5 seconds and then grab the output. Then run `jcmd` to dump the thread
>> stacks in case there is a deadlock. The test ignores and swallows any
>> exception whi
> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for 5
> seconds and then grab the output. Then run `jcmd` to dump the thread stacks
> in case there is a deadlock. The test ignores and swallows any exception
> which makes it hard to diagnose test issues.
>
> This PR si
On Wed, 1 Nov 2023 19:15:15 GMT, Mandy Chung wrote:
>> test/jdk/java/lang/ClassLoader/loadLibraryDeadlock/TestLoadLibraryDeadlock.java
>> line 115:
>>
>>> 113: Collections.addAll(commands, java);
>>> 114: Collections.addAll(commands, Utils.getTestJavaOpts());
>>> 115: Co
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
I would suggest to determine the set of tests which run "at most 10 seconds
total" and
On Wed, 1 Nov 2023 18:35:00 GMT, Roger Riggs wrote:
>> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for
>> 5 seconds and then grab the output. Then run `jcmd` to dump the thread
>> stacks in case there is a deadlock. The test ignores and swallows any
>> exception whi
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
Address changes from JEP 445 to JEP 463.
- Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
- Don't mark class on read.
- Remove reflection and annotation processing related to unnamed classes.
- Simplify main method search.
-
Commit messages:
- Implicit classes
On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has updated the pull request inc
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
jdk_vector_sanity was added to tier1 to catch issues early in GHA.
See #10879 and discu
On Wed, 1 Nov 2023 17:54:00 GMT, Mandy Chung wrote:
> `TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for 5
> seconds and then grab the output. Then run `jcmd` to dump the thread stacks
> in case there is a deadlock. The test ignores and swallows any exception
> which m
`TestLoadLibraryDeadlock.java` test runs `LoadLibraryDeadlock` and wait for 5
seconds and then grab the output. Then run `jcmd` to dump the thread stacks in
case there is a deadlock. The test ignores and swallows any exception which
makes it hard to diagnose test issues.
This PR simplifies the
On Wed, 1 Nov 2023 14:10:10 GMT, Maurizio Cimadamore
wrote:
> This PR fixes an inexact var handle call that sneaked in as part of
> https://git.openjdk.org/jdk/pull/16224.
>
> As some default methods were moved from `MemorySegment` to
> `AbstractMemorySegmentImpl`, the type of `this` has chan
Prevent a `NegativeArraySizeException` in `BigDecimal.toPlainString()`,
throwing `OutOfMemoryError` instead to indicate that the resulting `String`
would be too large.
-
Commit messages:
- 8318915: Enhance checks in BigDecimal.toPlainString()
Changes: https://git.openjdk.org/jdk/p
On Tue, 17 Oct 2023 14:17:20 GMT, Martin Doerr wrote:
>> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
>> double values have only 4 Byte alignment within structures. This PR is based
>> on JDK22 version of the FFI.
>
> Martin Doerr has updated the pull request inc
> This is the proposed patch for Primitive types in patterns, instanceof, and
> switch (Preview).
>
> Draft spec here:
> https://cr.openjdk.org/~abimpoudis/instanceof/jep455-20231030/specs/instanceof-jls.html
Aggelos Biboudis has updated the pull request incrementally with one additional
commi
> Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
> improving guarantees of internal invariants.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Static Random instance.
-
Changes:
- al
On Wed, 1 Nov 2023 14:10:10 GMT, Maurizio Cimadamore
wrote:
> This PR fixes an inexact var handle call that sneaked in as part of
> https://git.openjdk.org/jdk/pull/16224.
>
> As some default methods were moved from `MemorySegment` to
> `AbstractMemorySegmentImpl`, the type of `this` has chan
This PR fixes an inexact var handle call that sneaked in as part of
https://git.openjdk.org/jdk/pull/16224.
As some default methods were moved from `MemorySegment` to
`AbstractMemorySegmentImpl`, the type of `this` has changed, and this made all
the var handle calls in the memory segment access
On Tue, 31 Oct 2023 17:15:50 GMT, Leo Korinth wrote:
>> Updates to javadoc after improvement ideas in the review of 8315097. I have
>> also removed the incomplete invocation command line. I also removed
>> incomplete information in `executeTestJvm` and added a link to
>> `createLimitedTestJava
Enhance `java.math.BigInteger` constructors taking a `byte[]` argument by
improving guarantees of internal invariants.
-
Commit messages:
- Added @bug to test.
- Refactored test to JUnit.
- 8319174: Enhance robustness of some j.m.BigInteger constructors
- Merge branch 'master'
-
On Tue, 31 Oct 2023 20:45:11 GMT, Calvin Cheung wrote:
> Do you prefer the `canArchive` setting be inside `if
> (CDS.isDumpingStaticArchive())` like the following?
>
> ```
> if (CDS.isDumpingStaticArchive())
> canArchive = true;
> ```
That's fine. It has been harmless to have canAr
On Wed, 1 Nov 2023 04:34:35 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
> This PR proposes removing the restriction that only heap `MemorySegment`
> wrapping a `byte` array can be accessed by Vectors. Now any array type can be
> used provided the element alignment constraints are respected.
Per Minborg has updated the pull request incrementally with one additional
On Mon, 12 Jun 2023 17:28:44 GMT, Naoto Sato wrote:
>> One other thing to consider...
>> If the BaseLocale entries are being GC'd sooner, then perhaps the value of
>> the String.intern() is reduced.
>> Eliminating `.intern90` would make creating a normalized BaseLocale faster.
>
>> One other thi
On Wed, 1 Nov 2023 00:06:35 GMT, Leonid Mesnik wrote:
> Test thread factory is a mode similar to VM flags and should not be used in
> ProcessTools.createLimitedTestJavaProcessBuilder(). Only
> createTestJavaProcessBuilder() should use it like jtreg VM options.
>
> Adding the test thread factor
42 matches
Mail list logo
