Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v8]

2023-11-18 Thread Shaojin Wen
On Sun, 19 Nov 2023 01:52:13 GMT, Naoto Sato wrote: >> JapaneseChronology is an IsoChronology so run the test again (before >> committing) to make sure. > > `JapaneseChronology` is not extending `IsoChronology`, and that is the gist > of the change I suggested. I added the testcase of

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v8]

2023-11-18 Thread Naoto Sato
On Sat, 18 Nov 2023 14:56:47 GMT, Roger Riggs wrote: >> Now I tried and it didn't compile  It should have been >> `t.query(TemporalQueries.chronology()) instanceof IsoChronology` > > JapaneseChronology is an IsoChronology so run the test again (before > committing) to make sure.

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v24]

2023-11-18 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v23]

2023-11-18 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v10]

2023-11-18 Thread Shaojin Wen
> j.u.Formatter now prints "%tF" (iso standard date) and the result is > incorrect when processing year < 0 or year > Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: add JapaneseChronology testcase - Changes: -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v22]

2023-11-18 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFE: support safely wrapping restricted FFM calls

2023-11-18 Thread Rob Spoor
On 18/11/2023 06:46, Kasper Nielsen wrote: Hi Rob, Delegating caller sensitive methods can be tricky. Besides the obvious solutions with StackWalker and/or Lookup objects I've sometimes used an abstract class that must be extended by users of my library. This may be more trouble in your case

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v8]

2023-11-18 Thread Roger Riggs
On Fri, 17 Nov 2023 23:35:37 GMT, Naoto Sato wrote: >> Haven't tried, but I think `t.getChronology() instanceof IsoChronology` >> should work > > Now I tried and it didn't compile  It should have been > `t.query(TemporalQueries.chronology()) instanceof IsoChronology` JapaneseChronology is an

Re: RFR: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format [v9]

2023-11-18 Thread Shaojin Wen
> j.u.Formatter now prints "%tF" (iso standard date) and the result is > incorrect when processing year < 0 or year > Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: use t.query(TemporalQueries.chronology()) instanceof

Re: RFR: 8320348: java.io.File.getAbsolutePath fails if working directory is not on drive C

2023-11-18 Thread Matthias Baesken
On Fri, 17 Nov 2023 22:04:58 GMT, Brian Burkhalter wrote: > @MBaesken I would appreciate it if you would try out this proposed change > to see whether it fixes the problem that you reported. Thanks! Hi Brian, I added your patch to our tests. - PR Comment:

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-18 Thread Jorn Vernee
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-18 Thread suchismith1993
On Fri, 17 Nov 2023 15:39:49 GMT, Magnus Ihse Bursie wrote: > The syslookup.c solution for Windows looks interesting. While it is still a > hard-coded list, at least you will get compile time errors if the include > file changes to mismatch with the symbols... I don't think AIX has a way to