On Mon, 11 Dec 2023 09:15:50 GMT, Stefan Karlsson wrote:
> [JDK-8315097](https://bugs.openjdk.org/browse/JDK-8315097): 'Rename
> createJavaProcessBuilder' changed the name of the ProcessTools helper
> functions used to create `ProcessBuilder`s used to spawn new java test
> processes.
>
> We n
On Fri, 15 Dec 2023 01:16:55 GMT, Joshua Cao wrote:
> ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
> `transfer()`. When coming from the copy constructor, the Map is empty, so
> there is nothing to transfer. But `transfer()` will still copy all the empty
> nodes fr
On Tue, 2 Jan 2024 13:53:39 GMT, Alan Bateman wrote:
> -Djdk.tracePinnedThreads is a debugging option that dates from early
> development in the loom repo to identify pinned threads. It has several
> issues and this tracing option will eventually be removed (use the JFR events
> instead). Seve
On Tue, 2 Jan 2024 13:53:39 GMT, Alan Bateman wrote:
> -Djdk.tracePinnedThreads is a debugging option that dates from early
> development in the loom repo to identify pinned threads. It has several
> issues and this tracing option will eventually be removed (use the JFR events
> instead). Seve
On Tue, 2 Jan 2024 13:53:39 GMT, Alan Bateman wrote:
> -Djdk.tracePinnedThreads is a debugging option that dates from early
> development in the loom repo to identify pinned threads. It has several
> issues and this tracing option will eventually be removed (use the JFR events
> instead). Seve
Most functions in ProcessTools are declared to throw Exceptions, or one of its
subclasses. However, there are a small number of functions that are
unnecessarily declared to throw Throwable instead of Exception. I propose that
we change them to also be declared to throw Exception.
This is a triv
On Wed, 13 Dec 2023 22:20:55 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Tue, 2 Jan 2024 15:22:05 GMT, Alan Bateman wrote:
>> A lot of test changes have accumulated in the loom repo, this includes both
>> new tests and updates to existing tests. Some of these updates can be
>> brought to the main line. This update brings over:
>>
>> - The existing tests for pinn
In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
cleanup has been proposed before (and was done in the change). But there are a
number of other places in the codebase where the import is done and still the
unneeded fully qualified class name "java.util.Arrays" is used so
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Thank you,
> Adam
Adam Sot
On Sun, 24 Dec 2023 04:07:07 GMT, Chen Liang wrote:
>> This code is part of the **ClassFile API**’s internals, and so it doesn’t
>> have access to `ProxyGenerator`’s cached `MethodTypeDesc`s, only the
>> underlying `Utf8Entry`, so it’d need to be parsed.
>
> I see that now Class return type and
On Wed, 3 Jan 2024 11:39:01 GMT, Jaikiran Pai wrote:
> Are these heap sizing changes to reduce the resource usage of this test or is
> it to try and trigger any potential issue that this test verifies?
The heap usage for this one can vary quite a bit, some of the lower
optimization modes lead
On Tue, 2 Jan 2024 15:22:05 GMT, Alan Bateman wrote:
>> A lot of test changes have accumulated in the loom repo, this includes both
>> new tests and updates to existing tests. Some of these updates can be
>> brought to the main line. This update brings over:
>>
>> - The existing tests for pinn
On Wed, 3 Jan 2024 11:53:24 GMT, Jaikiran Pai wrote:
> Just one question - doesn't the use of a new native code in the test library
> (the `libVThreadPinner.c`) require any build changes (I'm not too familiar
> with that part)?
Magnus did some work in the make files some time ago to build nati
On Wed, 3 Jan 2024 11:53:43 GMT, Alan Bateman wrote:
> It's been bumped to 1.5g in the loom repo for some time.
Ah, I misread that change previously as reducing it from `1g` to `150m`, while
infact this change is increasing it to `1500m`. Given your reference to
JDK-8303635, the change looks
On Wed, 3 Jan 2024 09:51:24 GMT, Stefan Karlsson wrote:
> Most functions in ProcessTools are declared to throw Exceptions, or one of
> its subclasses. However, there are a small number of functions that are
> unnecessarily declared to throw Throwable instead of Exception. I propose
> that we c
On Sun, 24 Dec 2023 03:14:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 737:
>
>> 735:
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Thank you,
> Adam
Adam Sot
On Wed, 3 Jan 2024 11:41:20 GMT, Matthias Baesken wrote:
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> th
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> the unneeded fully qualified class name "java.util.Arrays" is
On Fri, 15 Dec 2023 01:16:55 GMT, Joshua Cao wrote:
> ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
> `transfer()`. When coming from the copy constructor, the Map is empty, so
> there is nothing to transfer. But `transfer()` will still copy all the empty
> nodes fr
> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
> cleanup has been proposed before (and was done in the change). But there are
> a number of other places in the codebase where the import is done and still
> the unneeded fully qualified class name "java.util.Arrays" is
On Wed, 20 Dec 2023 10:40:23 GMT, Serguei Spitsyn wrote:
>>> You can't do this! The Java code knows nothing about JVM TI being
>>> enabled/disabled and will call this function unconditionally.
>>
>> Indeed. I wonder if anyone is testing minimal builds to catch issues like
>> this.
>
> Good cat
On Wed, 3 Jan 2024 13:55:24 GMT, Thomas Wuerthinger wrote:
> Are these new compiler intrinsics required or an optional performance
> optimization?
Performance. If the intrinsic isn't there then some methods executed on virtual
threads, or on a virtual thread as the target for some op, will ha
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
On Fri, 15 Dec 2023 01:16:55 GMT, Joshua Cao wrote:
> ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
> `transfer()`. When coming from the copy constructor, the Map is empty, so
> there is nothing to transfer. But `transfer()` will still copy all the empty
> nodes fr
On Sat, 16 Dec 2023 17:25:20 GMT, Alan Bateman wrote:
> A lot of test changes have accumulated in the loom repo, this includes both
> new tests and updates to existing tests. Some of these updates can be brought
> to the main line. This update brings over:
>
> - The existing tests for pinning
On Wed, 3 Jan 2024 06:43:22 GMT, Joe Darcy wrote:
> As recently discussed on core libs, sealed-ness information could be included
> in the Class.toGenericString() output, analagous to how "modifiers" that also
> correspond to JVM access flags are handled.
>
> This is the initial spec, implemen
On Wed, 3 Jan 2024 14:59:33 GMT, Roger Riggs wrote:
>> As recently discussed on core libs, sealed-ness information could be
>> included in the Class.toGenericString() output, analagous to how "modifiers"
>> that also correspond to JVM access flags are handled.
>>
>> This is the initial spec, i
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
On Wed, 3 Jan 2024 17:13:02 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17249#pullrequestreview-1802749494
A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java.
-
Commit messages:
- 8322963: ProblemList java/io/BufferedInputStream/TransferTo.java
Changes: https://git.openjdk.org/jdk/pull/17249/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17249&range=00
Is
On Wed, 3 Jan 2024 17:13:02 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java.
This pull request has now been integrated.
Changeset: cc9ab5f1
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/cc9ab5f1976486f0a
On Wed, 3 Jan 2024 17:14:42 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList java/io/BufferedInputStream/TransferTo.java.
>
> Marked as reviewed by bpb (Reviewer).
@bplb - Thanks for the lightning fast review!
-
PR Comment: https://git.openjdk.org/jdk/pull/17249#issueco
On Tue, 2 Jan 2024 08:55:37 GMT, Alan Bateman wrote:
> Missed by JDK-8312498, VirtualThread::tryGetStackTrace doesn't handle the
> TIMED_PINNED state so it's possible for Thread::getStackTrace to throw
> InternalError when invoked on a virtual thread that quickly transitions from
> unmounted t
On Wed, 3 Jan 2024 18:01:59 GMT, Brian Burkhalter wrote:
> The final position instead of the number of bytes to write was being passed
> to `ByteArrayOuputStream.write(byte[],int,int)`.
Everyone was apparently caught off guard as previously
`Arrays.copyOfRange(byte[],int,int)` had been used he
The final position instead of the number of bytes to write was being passed to
`ByteArrayOuputStream.write(byte[],int,int)`.
-
Commit messages:
- 8322877: java/io/BufferedInputStream/TransferTo.java failed with
IndexOutOfBoundsException
Changes: https://git.openjdk.org/jdk/pull/17
On Wed, 3 Jan 2024 14:52:48 GMT, Roger Riggs wrote:
>> As recently discussed on core libs, sealed-ness information could be
>> included in the Class.toGenericString() output, analagous to how "modifiers"
>> that also correspond to JVM access flags are handled.
>>
>> This is the initial spec, i
On Wed, 3 Jan 2024 18:01:59 GMT, Brian Burkhalter wrote:
> The final position instead of the number of bytes to write was being passed
> to `ByteArrayOuputStream.write(byte[],int,int)`.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17250#pul
On Wed, 3 Jan 2024 16:40:32 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/lang/Class.java line 264:
>>
>>> 262: /**
>>> 263: * Returns a string describing this {@code Class}, including
>>> 264: * information about modifiers, {@linkplain #isSealed() sealing},
>>> and
On Wed, 3 Jan 2024 06:43:22 GMT, Joe Darcy wrote:
> As recently discussed on core libs, sealed-ness information could be included
> in the Class.toGenericString() output, analagous to how "modifiers" that also
> correspond to JVM access flags are handled.
>
> This is the initial spec, implemen
On Wed, 3 Jan 2024 18:16:24 GMT, Joe Darcy wrote:
> Since it doesn't seem possible to do so, I did not attempt to relay
> "non-sealed" information in this PR :-)
Naively, I thought that something like this is possible _in principle_; I might
be mistaken though:
diff --git a/src/java.base/shar
Fix the get (return) operation by using the same method as that used for
checking the values of the DTD features during the resolution process.
Note: this patch also addresses the issue reported in
https://bugs.openjdk.org/browse/JDK-8322216
Test: new test added covers DTD properties for SAX/DO
On Wed, 3 Jan 2024 18:01:59 GMT, Brian Burkhalter wrote:
> The final position instead of the number of bytes to write was being passed
> to `ByteArrayOuputStream.write(byte[],int,int)`.
Marked as reviewed by stsypanov (Author).
-
PR Review: https://git.openjdk.org/jdk/pull/17250#p
On Wed, 3 Jan 2024 14:34:50 GMT, Aleksey Shipilev wrote:
>> ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
>> `transfer()`. When coming from the copy constructor, the Map is empty, so
>> there is nothing to transfer. But `transfer()` will still copy all the empty
>>
On Sat, 30 Dec 2023 20:51:43 GMT, Chen Liang wrote:
>I think this ticket should focus on adding the new constructor as part of the
>API.
Okay. I would think the code would avoid heapify when the caller does foolish
things with this API such as:
SortedSet ss = filledSortedSet();
PriorityQueue
On Sun, 15 Oct 2023 07:40:06 GMT, himichael wrote:
> sing a physical machine, I am using a virtual machine, this virtual machine
> supports the AVX512 instruction set.
> How do I open libsimdsort ?
@himichael Did you ever resolve your issue? I am using JDK22 from SDKMan and
have the same error
On Wed, 3 Jan 2024 18:01:59 GMT, Brian Burkhalter wrote:
> The final position instead of the number of bytes to write was being passed
> to `ByteArrayOuputStream.write(byte[],int,int)`.
This pull request has now been integrated.
Changeset: 54b3ceec
Author:Brian Burkhalter
URL:
http
> ConcurrentHashMap's copy constructor calls `putAll()` -> `tryPresize()` ->
> `transfer()`. When coming from the copy constructor, the Map is empty, so
> there is nothing to transfer. But `transfer()` will still copy all the empty
> nodes from the old table to the new table.
>
> This patch avo
On Wed, 3 Jan 2024 19:52:34 GMT, Joshua Cao wrote:
>> test/micro/org/openjdk/bench/java/util/concurrent/Maps.java line 122:
>>
>>> 120: public void testCopyConstructor() {
>>> 121: ConcurrentHashMap clone = new
>>> ConcurrentHashMap<>(staticMap);
>>> 122: dummy = clone;
>>
On Wed, 3 Jan 2024 19:31:16 GMT, Joe Wang wrote:
> Fix the get (return) operation by using the same method as that used for
> checking the values of the DTD features during the resolution process.
>
> Note: this patch also addresses the issue reported in
> https://bugs.openjdk.org/browse/JDK-8
On Wed, 3 Jan 2024 19:44:51 GMT, Pavel Rappo wrote:
>> I think the best place, or least-bad place, to discuss the "modifier"
>> ordering of sealed/non-sealed would be an informative note on
>> Modifier.toString(int) -- "The sealed/non-sealed Java language modifiers are
>> not represented in th
On Wed, 3 Jan 2024 22:20:15 GMT, Joe Darcy wrote:
>>> Since it doesn't seem possible to do so, I did not attempt to relay
>>> "non-sealed" information in this PR :-)
>>
>> Naively, I thought that something like this is possible _in principle_; I
>> might be mistaken though:
>>
>> diff --git a
Please review this PR which splits up the _LocaleProvidersRun_ test file for
performance and maintenance reasons.
_LocaleProvidersRun_ which tests against the various Locale Providers (CLDR,
HOST, SPI, etc.) was getting rather long, as all related bugs were added to the
single test file. To imp
Hey David,
> AFAICS java.library.path (and sun.boot.library.path) are input
> properties that can be set by the user. There are no "default" values
> for these properties as such.
>
Although they can be set by the user, they have default values.
For Linux, the default value is set here:
https:
On Wed, 3 Jan 2024 19:31:16 GMT, Joe Wang wrote:
> Fix the get (return) operation by using the same method as that used for
> checking the values of the DTD features during the resolution process.
>
> Note: this patch also addresses the issue reported in
> https://bugs.openjdk.org/browse/JDK-8
Hi,
Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only
targets.
Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
instruction set.
These are very frequently used operation in columnar database filter operation.
Implementation uses a lookup table
> Hi,
>
> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only
> targets.
> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
> instruction set.
> These are very frequently used operation in columnar database filter
> operation.
>
> Implementation
On Tue, 2 Jan 2024 08:55:37 GMT, Alan Bateman wrote:
> Missed by JDK-8312498, VirtualThread::tryGetStackTrace doesn't handle the
> TIMED_PINNED state so it's possible for Thread::getStackTrace to throw
> InternalError when invoked on a virtual thread that quickly transitions from
> unmounted t
On 4/01/2024 1:36 pm, Glavo wrote:
Hey David,
AFAICS java.library.path (and sun.boot.library.path) are input
properties that can be set by the user. There are no "default" values
for these properties as such.
Although they can be set by the user, they have default values.
For Linux
60 matches
Mail list logo
