Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v7]

2024-01-19 Thread Sandhya Viswanathan
On Fri, 19 Jan 2024 19:03:31 GMT, Jatin Bhateja wrote: >> Hi, >> >> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 >> only targets. >> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2 >> instruction set. >> These are very frequently used APIs

Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v7]

2024-01-19 Thread Sandhya Viswanathan
On Fri, 19 Jan 2024 19:03:31 GMT, Jatin Bhateja wrote: >> Hi, >> >> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 >> only targets. >> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2 >> instruction set. >> These are very frequently used APIs

Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v7]

2024-01-19 Thread Sandhya Viswanathan
On Fri, 19 Jan 2024 19:03:31 GMT, Jatin Bhateja wrote: >> Hi, >> >> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 >> only targets. >> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2 >> instruction set. >> These are very frequently used APIs

Re: RFR: 8323699: MessageFormat.toPattern() generates non-equivalent MessageFormat pattern [v3]

2024-01-19 Thread Archie Cobbs
> Please consider this fix to ensure that going from `MessageFormat` to pattern > string via `toPattern()` and then back via `new MessageFormat()` results in a > format that is equivalent to the original. > > The quoting and escaping rules for `MessageFormat` pattern strings are really >

Re: RFR: 8323699: MessageFormat.toPattern() generates non-equivalent MessageFormat pattern [v3]

2024-01-19 Thread Archie Cobbs
On Fri, 19 Jan 2024 23:30:43 GMT, Archie Cobbs wrote: >> Please consider this fix to ensure that going from `MessageFormat` to >> pattern string via `toPattern()` and then back via `new MessageFormat()` >> results in a format that is equivalent to the original. >> >> The quoting and escaping

Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v7]

2024-01-19 Thread Jatin Bhateja
> Hi, > > Patch optimizes non-subword vector compress and expand APIs for x86 AVX2 only > targets. > Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2 > instruction set. > These are very frequently used APIs in columnar database filter operation. > > Implementation uses a

Re: RFR: 8322768: Optimize non-subword vector compress and expand APIs for AVX2 target. [v5]

2024-01-19 Thread Jatin Bhateja
On Fri, 19 Jan 2024 07:43:18 GMT, Emanuel Peter wrote: >> For long/double each permute row is 32 byte in size, so a shift by 5 to >> compute row address. > > Ah right. Maybe we could say `32byte = 4 long = 4 * 64bit`. > Because "64bit row" sounds like the whole row is only 64 bit long. It is >

Integrated: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static

2024-01-19 Thread Serguei Spitsyn
On Mon, 8 Jan 2024 07:55:45 GMT, Serguei Spitsyn wrote: > The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be > static. > The method disables/enables suspend of the current virtual thread, a no-op if > the current thread is a platform thread. It is confusing for this to

Re: RFR: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static [v2]

2024-01-19 Thread Serguei Spitsyn
On Thu, 11 Jan 2024 13:09:39 GMT, Serguei Spitsyn wrote: >> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be >> static. >> The method disables/enables suspend of the current virtual thread, a no-op >> if the current thread is a platform thread. It is confusing for

Re: RFR: 8322149: ConcurrentHashMap smarter presizing for copy constructor and putAll [v3]

2024-01-19 Thread Joshua Cao
On Thu, 18 Jan 2024 07:17:20 GMT, ExE Boss wrote: >> src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java line >> 1088: >> >>> 1086: public void putAll(Map m) { >>> 1087: if (table != null) { >>> 1088: tryPresize(size() + m.size()); >> >> Is overflow

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v7]

2024-01-19 Thread Roger Riggs
On Fri, 19 Jan 2024 18:23:40 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v7]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Integrated: 8159927: Add a test to verify JMOD files created in the images do not have debug symbols

2024-01-19 Thread Mandy Chung
On Wed, 17 Jan 2024 20:51:23 GMT, Mandy Chung wrote: > The build excludes the native debug symbols in JMOD files created for JDK > modules (see make/CreateJmods.gmk). This PR adds a test to verify that > native debug symbols are excluded as expected. This pull request has now been

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Raffaello Giulietti
On Fri, 19 Jan 2024 14:14:26 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static [v2]

2024-01-19 Thread Alan Bateman
On Thu, 11 Jan 2024 13:09:39 GMT, Serguei Spitsyn wrote: >> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be >> static. >> The method disables/enables suspend of the current virtual thread, a no-op >> if the current thread is a platform thread. It is confusing for

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v6]

2024-01-19 Thread Raffaello Giulietti
On Fri, 19 Jan 2024 14:10:48 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static [v2]

2024-01-19 Thread Patricio Chilano Mateo
On Thu, 11 Jan 2024 13:09:39 GMT, Serguei Spitsyn wrote: >> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be >> static. >> The method disables/enables suspend of the current virtual thread, a no-op >> if the current thread is a platform thread. It is confusing for

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v5]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v4]

2024-01-19 Thread Raffaello Giulietti
On Fri, 19 Jan 2024 12:26:51 GMT, Jim Laskey wrote: >> Currently String::translateEscapes does not support unicode escapes, >> reported as a IllegalArgumentException("Invalid escape sequence: ..."). >> String::translateEscapes should translate unicode escape sequences to >> provide full

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v4]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: JDK-8263261 Extend String::translateEscapes to support unicode escapes [v3]

2024-01-19 Thread Jim Laskey
> Currently String::translateEscapes does not support unicode escapes, reported > as a IllegalArgumentException("Invalid escape sequence: ..."). > String::translateEscapes should translate unicode escape sequences to provide > full coverage, Jim Laskey has updated the pull request

Re: RFR: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin [v2]

2024-01-19 Thread Richard Reingruber
On Fri, 19 Jan 2024 07:57:36 GMT, Alan Bateman wrote: > > I noticed that VirtualThread overrides `isInterrupted` > > Is there a reason to have this override? > > It was necessary at one point but no reason to now except to keep it close at > the source level with the other methods that access

Re: RFR: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin [v2]

2024-01-19 Thread Alan Bateman
On Fri, 19 Jan 2024 01:56:06 GMT, David Holmes wrote: > Yep my bad on the VM side of things - no change there. But in the nioBlocker > case doesn't this inherently make things more racy? Now maybe those races are > allowed, but this might lead to a change in behaviour. I/O threads always

Re: RFR: 8323782: Race: Thread::interrupt vs. AbstractInterruptibleChannel.begin [v2]

2024-01-19 Thread Alan Bateman
On Wed, 17 Jan 2024 15:38:22 GMT, Richard Reingruber wrote: >> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for >> correct (Dekker scheme) synchronization with concurrent execution of >>