RFR: 8326126: Update the java manpage with the changes from JDK-8322478

2024-02-18 Thread David Holmes
Please reviews these manpage updates in relation to "JEP 458: Launch Multi-File Source-Code Programs". The manpage sources had previously been updated internally at Oracle under JDK-8322478, but the open troff file was not regenerated at the time in mainline (it was for JDK 22). The main gist

Re: RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v11]

2024-02-18 Thread Jaikiran Pai
On Sun, 17 Dec 2023 23:11:10 GMT, Chen Liang wrote: >> Summaries: >> 1. A few recommendations about updating the constant API is made at >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html >> and I may update this patch shall the API changes be integrated before >>

Re: RFR: JDK-8252802: java launcher should set MALLOCOPTIONS and LDR_CNTRL in order to use 64KB pages on AIX

2024-02-18 Thread Alan Bateman
On Mon, 19 Feb 2024 05:52:22 GMT, Varada M wrote: > DeCapo Benchmark Results (3 runs) : > > Before : > = DaCapo 9.12 h2 PASSED in 281402 msec = > = DaCapo 9.12 h2 PASSED in 269818 msec = > = DaCapo 9.12 h2 PASSED in 279279 msec = > > After: > = DaCapo 9.12 h2

Re: RFR: 8318812: LauncherHelper.checkAndLoadMain closes jar file that's about to be re-opened [v2]

2024-02-18 Thread Jaikiran Pai
On Thu, 15 Feb 2024 06:29:24 GMT, Christian Stein wrote: >> Please review this PR that makes the launcher helper keep a reference to the >> executable JAR file active after extracting the name of the main class and >> returning it as Class instance. Now, when loading classes from the JAR file,

Re: RFR: 8326099: GZIPOutputStream should use Deflater.getBytesRead() instead of Deflater.getTotalIn()

2024-02-18 Thread Jaikiran Pai
On Sat, 17 Feb 2024 12:08:38 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR in preparation for deprecating > `Deflater.getTotalIn()` in JDK-8326096. > > This PR replaces `GZIPOutputStream.writeTrailer`'s call to > `Deflater.getTotalIn()` with a call to `Deflater.getBytesRead()`

Re: RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut [v2]

2024-02-18 Thread Jaikiran Pai
On Sun, 18 Feb 2024 10:56:03 GMT, Eirik Bjørsnøs wrote: >> Please review this test-only cleanup PR in preparation for deprecating >> `Deflater.getTotalOut()` in JDK-8326096. >> >> This PR replaces various calls >> in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to >>

RFR: JDK-8252802: java launcher should set MALLOCOPTIONS and LDR_CNTRL in order to use 64KB pages on AIX

2024-02-18 Thread Varada M
DeCapo Benchmark Results (3 runs) : Before : = DaCapo 9.12 h2 PASSED in 281402 msec = = DaCapo 9.12 h2 PASSED in 269818 msec = = DaCapo 9.12 h2 PASSED in 279279 msec = After: = DaCapo 9.12 h2 PASSED in 279192 msec = = DaCapo 9.12 h2 PASSED in 269769 msec

Re: RFR: 8325679: Optimize ArrayList subList sort

2024-02-18 Thread Attila Szegedi
On Wed, 14 Feb 2024 23:37:03 GMT, Stuart Marks wrote: >> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and >> will thus fall back to slower default method of `List.sort()` instead of >> sorting a range of the array in-place in its backing root `ArrayList`. >> >> This

Re: RFR: 8325679: Optimize ArrayList subList sort [v2]

2024-02-18 Thread Attila Szegedi
> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and will > thus fall back to slower default method of `List.sort()` instead of sorting a > range of the array in-place in its backing root `ArrayList`. > > This doesn't change observable behavior, so haven't added tests,

Re: RFR: 8180892: Correct handling of annotations on parameters [v2]

2024-02-18 Thread Chen Liang
On Wed, 26 Apr 2023 14:46:53 GMT, Chen Liang wrote: >> This patch aims to correct handling of annotations on parameters with the >> help of `MethodParameters` attribute, which will be always available once >> #9862 is integrated. >> >> It utilizes and expands upon the existing parameter

Re: RFR: 8180892: Correct handling of annotations on parameters [v3]

2024-02-18 Thread Chen Liang
> This patch aims to correct handling of annotations on parameters with the > help of `MethodParameters` attribute, which will be always available once > #9862 is integrated. > > It utilizes and expands upon the existing parameter matching logic present in >

Re: RFR: 8323707: Adjust Classfile API's type arg model to better represent the embodied type [v2]

2024-02-18 Thread Chen Liang
> API changes as discussed on the mailing list: > https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html > > Additional questions: > 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE` Chen Liang has updated the pull request with a new target base due to a merge

Re: OpenJDK 17: Loitering AbstractQueuedSynchronizer$ConditionNode instances (also on latest master branch) [JDK-8325754]

2024-02-18 Thread Frank Kretschmer
Hello Jaikiran, hello Viktor, in the meantime, I've seen that the JBS issue has been assigned to Viktor Klang. @Viktor: I totally agree with your comment that the proposed solution may not be the best possible option, and that further explorations were required. My intention to propose

Re: RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut [v2]

2024-02-18 Thread Eirik Bjørsnøs
On Sun, 18 Feb 2024 10:56:03 GMT, Eirik Bjørsnøs wrote: >> Please review this test-only cleanup PR in preparation for deprecating >> `Deflater.getTotalOut()` in JDK-8326096. >> >> This PR replaces various calls >> in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to >>

Re: RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut [v2]

2024-02-18 Thread Eirik Bjørsnøs
> Please review this test-only cleanup PR in preparation for deprecating > `Deflater.getTotalOut()` in JDK-8326096. > > This PR replaces various calls > in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to > `Deflater.getTotalOut()` with calls to `Deflater.getBytesWritten()` when >

Re: RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut

2024-02-18 Thread Alan Bateman
On Sat, 17 Feb 2024 13:00:08 GMT, Eirik Bjørsnøs wrote: > Please review this test-only cleanup PR in preparation for deprecating > `Deflater.getTotalOut()` in JDK-8326096. > > This PR replaces various calls > in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to >