Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-03-03 Thread Julian Waters
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a

jpackage requests permission via a dialog

2024-03-03 Thread Alan Snyder
I tried using jpackage on macOS to create a DMG (which I have not done before) and was surprised when a system dialog was displayed requesting permission for Terminal to control Finder. I found this issue described in JDK-8231855, which was closed without explanation as “not an issue”. It

Re: Any plans to make resource leaks easier to detect?

2024-03-03 Thread David Alayachew
And as a side note, I did some pretty in-depth research on the topic, and stumbled on this post on the lambda mailing list during Java 8's creation. I am adding it, as it seems to be considering many of the same concerns I have now.

Any plans to make resource leaks easier to detect?

2024-03-03 Thread David Alayachew
Hello Amber Dev Team and Core Libs Dev Team, I am making my own implementation of java.util.stream.Stream that reads data from the internet lazily. It's basically java.nio.file.Files.lines(...), but the file is on the internet instead. Here is a StackOverflow post I made that basically gave birth

Re: RFR: 8326096: Deprecate getTotalIn, getTotalOut methods of java.util.zip.Inflater, java.util.zip.Deflater [v12]

2024-03-03 Thread Lance Andersen
On Sat, 2 Mar 2024 18:51:16 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which proposes that we officially deprecate the >> following four methods in the `java.util.zip` package: >> >> * `Inflater.getTotalIn()` >> * `Inflater.getTotalOut()` >> * `Deflater.getTotalIn()` >> *

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-03-03 Thread Claudio Nieder
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-03-03 Thread Claudio Nieder
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a

Re: RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries [v2]

2024-03-03 Thread David Holmes
On Fri, 1 Mar 2024 13:58:08 GMT, Erik Joelsson wrote: >> Executables and dynamic libraries on Linux can encode a search path that the >> dynamic linker will use when looking up library dependencies, generally >> referred to as an "rpath". In the JDK we use this with the $ORIGIN feature >> to

Re: RFR: 8316493: Remove the caching fields in AbstractMap [v11]

2024-03-03 Thread Chen Liang
On Fri, 10 Nov 2023 08:17:22 GMT, Per Minborg wrote: >> This PR outlines a solution for making immutable maps `@ValueBased` by >> removing cacheing of certain values in `AbstractMap`. >> >> By removing these caching fields in `AbstractMap`, we can make the immutable >> maps `@ValueBased` and

Re: RFR: 8326096: Deprecate getTotalIn, getTotalOut methods of java.util.zip.Inflater, java.util.zip.Deflater [v12]

2024-03-03 Thread Alan Bateman
On Sat, 2 Mar 2024 18:51:16 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which proposes that we officially deprecate the >> following four methods in the `java.util.zip` package: >> >> * `Inflater.getTotalIn()` >> * `Inflater.getTotalOut()` >> * `Deflater.getTotalIn()` >> *

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-03-03 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a

Re: RFR: 8326583: Remove over-generalized DefineNativeToolchain solution [v4]

2024-03-03 Thread Magnus Ihse Bursie
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote: >> The idea of setting up general "toolchains" in the native build was good, >> but it turned out that we really only need a single toolchain, with a single >> twist: if it should use CC or CPP to link. This is better described by a