Re: RFR: 8327994: Update code gen in CallGeneratorHelper [v2]

2024-03-16 Thread Jorn Vernee
> Update the code gen code in CallGeneratorHelper to reflect the latest state > of the libTest(Downcall/Upcall)(Stack).c and shared.h files. > > - The previous code wanted users to pipe stdout into a file. But, since we > have 5 files that need to be created, and the names of those files is > i

Re: RFR: 8327994: Update code gen in CallGeneratorHelper [v2]

2024-03-16 Thread Andrey Turbanov
On Sat, 16 Mar 2024 15:41:06 GMT, Jorn Vernee wrote: >> Update the code gen code in CallGeneratorHelper to reflect the latest state >> of the libTest(Downcall/Upcall)(Stack).c and shared.h files. >> >> - The previous code wanted users to pipe stdout into a file. But, since we >> have 5 files t

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v20]

2024-03-16 Thread Mandy Chung
On Fri, 15 Mar 2024 10:53:29 GMT, Severin Gehwolf wrote: > Wasn't the intention to make "creating a linkable runtime image" a build only > decision and make the relevant infrastructure classes build-only artefacts? Build-only decision means that the linkable runtime image is only produced by J

Re: RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v20]

2024-03-16 Thread Mandy Chung
On Fri, 15 Mar 2024 09:55:15 GMT, Severin Gehwolf wrote: > > If `--enable-runtime-link-image` is enabled, the JDK image does not include > > the packaged modules. > > That's not true. Right now `--enable-runtime-link-image` modifies how the > `lib/modules` image looks like (adds a bunch of ext

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-16 Thread Stuart Marks
On Wed, 31 Jan 2024 01:13:18 GMT, Brent Christian wrote: >> src/java.base/share/classes/java/lang/ref/package-info.java line 109: >> >>> 107: * >>> 108: * The clearing of a reference by the garbage collector >>> happens-before >>> 109: * the garbage collector enqueues the reference. >> >> I

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v13]

2024-03-16 Thread Stuart Marks
On Thu, 14 Mar 2024 23:23:07 GMT, Brent Christian wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >>

Re: RFR: 8325163: Enable -Wpedantic on clang [v2]

2024-03-16 Thread Magnus Ihse Bursie
On Mon, 5 Feb 2024 10:58:17 GMT, Magnus Ihse Bursie wrote: >> Inspired by (the later backed-out) >> [JDK-8296115](https://bugs.openjdk.org/browse/JDK-8296115), I propose to >> enable `-Wpedantic` for clang. This has already found some irregularities in >> the code, like mistakenly using `#impo

Re: RFR: 8327839: Crash with unboxing and widening primitive conversion in switch

2024-03-16 Thread Andrey Turbanov
On Tue, 12 Mar 2024 14:06:11 GMT, Aggelos Biboudis wrote: > In cases where the compiler needs to unbox a `long`, `float`, `double` and > then run the exactness check, we were getting a crash. While the selector > value is always boxed, the type (which controls the execution flow) was not, > b

Re: RFR: 8328074: Add jcheck whitespace checking for assembly files [v4]

2024-03-16 Thread Sandhya Viswanathan
On Wed, 13 Mar 2024 11:59:36 GMT, Magnus Ihse Bursie wrote: >> As part of the ongoing effort to enable jcheck whitespace checking to all >> text files, it is now time to address assembly (.S) files. The hotspot >> assembly files were fixed as part of the hotspot mapfile removal, so only a >> s