On Wed, 10 Apr 2024 23:51:34 GMT, Tim Prinzing wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
On Wed, 10 Apr 2024 20:20:36 GMT, Justin Lu wrote:
>> Please review this PR and associated
>> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
>> parsing for NumberFormat.
>>
>> The concrete subclasses that will utilize this leniency value are
>> `DecimalFormat` and
On Wed, 21 Feb 2024 02:18:08 GMT, Chris Hennick wrote:
>> This provides a slightly more accurate bounding limit for
>> `computeNextExponentialSoftCapped` when calling it from
>> `computeNextGaussian`. This could cause the `while
>> (computeNextExponentialSoftCapped(rng, limit) < limit)` check
On Mon, 8 Apr 2024 19:11:19 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performance
On Mon, 8 Apr 2024 19:11:19 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performance
> I added `@since` tags for methods/constructors that do not match the `@since`
> of the enclosing class.
>
> The `write` method already existed in `PrintStream` in earlier versions and
> instances of it could always call this method, since it extends
> `FilterOutputStream` [which has the
> me
On Fri, 5 Apr 2024 09:17:18 GMT, Jatin Bhateja wrote:
> Few early comments.
>
> Please update the copyright year of all the modified files.
>
> You can even consider splitting this into two patches, Java side changes in
> one and x86 optimized intrinsic in next one.
Thanks Jatin, will fix!
-
> Added mirror event with static methods: jdk.internal.event.SelectionEvent
> that provides the duration of select calls and the count of how many keys are
> available.
>
> Emit the event from SelectorImpl::lockAndDoSelect
>
> Test at jdk.jfr.event.io.TestSelectionEvents
Tim Prinzing has updat
> Add notes for `HashMap::putAll()` conservative resizing.
>
> Note: everything below this line is from the original change. After
> discussion, we decided to keep the conservative resizing, but we should add
> an `@implNote` for the decision.
>
> ---
>
> This change mirrors what we did for Co
On Fri, 5 Apr 2024 15:57:24 GMT, Volker Simonis wrote:
>> I tried looking at the docs with `make docs-image`, but I can't test that
>> the syntax/links are actually correct because `@implNote` does not actually
>> show up in the web pages. As I understand from [the original
>> proposal](https:
Please review this PR which is a large spec reformatting for
_java.text.NumberFormat_ and related subclasses, specifically DecimalFormat and
CompactNumberFormat.
The motivation for this change was the difficulty of readability for these
classes. This PR consists of changes such as better separa
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8327703) which introduces strict
> parsing for NumberFormat.
>
> The concrete subclasses that will utilize this leniency value are
> `DecimalFormat` and `CompactNumberFormat`. Strict leniency allows for parsing
On Wed, 10 Apr 2024 18:07:33 GMT, Suchismith Roy wrote:
> > BUILD_JDK_JTREG_OUTPUT_DIR
>
> I agree. How can i fetch this path ? I tried
> System.getEnv("BUILD_JDK_JTREG_OUTPUT_DIR") But it doesn't seem to work.
Hmm. Good question. Maybe it can get extracted from the library path. I noticed
th
> This PR implements Gatherer-inspired encoding of `flatMap` that shows that it
> is both competitive performance-wise as well as improve correctness.
>
> Below is the performance of `Stream::flatMap` (for reference types):
>
> Before this PR:
>
> Benchmark(size) Mode Cnt
On Wed, 10 Apr 2024 16:46:30 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
On Mon, 8 Apr 2024 19:11:19 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performance
On Wed, 10 Apr 2024 17:18:55 GMT, Anthony Scarpino
wrote:
> In `ECOperations.java`, if I understand this correctly, it is to replace the
> existing `PointMultiplier` with montgomery-based PointMuliplier. But when I
> look at the code, I see both are still options. If I read this correctly, it
On Wed, 10 Apr 2024 16:17:32 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minim
> # Issue
> - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were
> made to the method signatures but this modification isn't reflected in the @
> since tags. The @ since tags need to be updated.
>
> I changed the `@since` tags to better accurately show when the methods were
On Wed, 10 Apr 2024 16:33:53 GMT, Suchismith Roy wrote:
> I have referred to the lib directory under jdk and not jtreg anymore.
> Wouldn't that be fine ?
I don't think writing to the jdk is a good design. People may even want to
write protect it.
-
PR Comment: https://git.openjdk
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256withECDSA1024 256
>
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
Fi
On Wed, 10 Apr 2024 15:40:02 GMT, Martin Doerr wrote:
> JTREG usually places libraries here:
>
> https://github.com/openjdk/jdk/blob/279ed0ddd505fb3052b818f755b4b220ed5557e6/make/test/JtregNativeJdk.gmk#L47
>
>
> Files can get copied by `Files.copy`:
> https://docs.oracle.com/javase/8/docs/ap
On Wed, 10 Apr 2024 12:27:33 GMT, Naoto Sato wrote:
>> Hello Naoto, I had used `InstantSeconds` to keep it consistent with how a
>> similar doc is used for the `EPOCH_DAY` field. Let me know if you still
>> prefer this to be `INSTANT_SECONDS` and I will update it.
>
> With the @code tag, I init
> Can I please get a review of this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>
> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
> initialized to have a minimum and maximum values of `Long.MIN_VALUE` and
> `LONG.MAX_VA
On Tue, 9 Apr 2024 08:37:29 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8212895?
>>
>> As noted in that issue, the `ChronoField.INSTANT_SECONDS` currently is
>> initialized to have a minimu
> Please review this simple cleanup which removes the
> `AbstractLinker::linkerByteOrder` method. It was only used in
> `AixPPC64Linker`, where we know it will always return `ByteOrder.BIG_ENDIAN`
> so we can just replace the call with that.
>
> Testing: Local run of `run-test-jdk_foreign`.
Jo
On Wed, 10 Apr 2024 15:38:22 GMT, Jorn Vernee wrote:
> Please review this simple cleanup which removes the
> `AbstractLinker::linkerByteOrder` method. It was only used in
> `AixPPC64Linker`, where we know it will always return `ByteOrder.BIG_ENDIAN`
> so we can just replace the call with that.
On Wed, 10 Apr 2024 11:06:21 GMT, Suchismith Roy wrote:
>> Allow support for both .a and .so files in AIX.
>> If .so file is not found, allow fallback to .a extension.
>> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
>
> Suchismith Roy has updated the pull request incremen
Please review this simple cleanup which removes the
`AbstractLinker::linkerByteOrder` method. It was only used in `AixPPC64Linker`,
where we know it will always return `ByteOrder.BIG_ENDIAN` so we can just
replace the call with that.
Testing: Local run of `run-test-jdk_foreign`.
-
On Wed, 10 Apr 2024 15:17:19 GMT, Jan Lahoda wrote:
>> Good catch. Since this was tweaked to be a public API as part of the string
>> template feature, I've reverted this code to what it was prior to string
>> template. That is, now this is a private static final constant, with
>> initializer
On Wed, 10 Apr 2024 12:49:11 GMT, Per Minborg wrote:
> This PR proposes to add two overloads `MemorySegment::reinterpretate` to
> allow aligned reinterpretation.
Should we add the full set of overloads? E.g.
reinterpret(arena, cleanup)
reinterpret(size)
reinterpret(size, arena, cleanup)
reinter
On Wed, 10 Apr 2024 15:19:31 GMT, Jorn Vernee wrote:
>> This PR proposes to add two overloads `MemorySegment::reinterpretate` to
>> allow aligned reinterpretation.
>
> test/jdk/java/foreign/TestSegments.java line 396:
>
>> 394: AtomicInteger counter = new AtomicInteger();
>> 395:
On Wed, 10 Apr 2024 12:49:11 GMT, Per Minborg wrote:
> This PR proposes to add two overloads `MemorySegment::reinterpretate` to
> allow aligned reinterpretation.
src/java.base/share/classes/jdk/internal/foreign/SegmentFactories.java line 72:
> 70: sessionImpl.addCloseAction(action)
On Wed, 10 Apr 2024 10:44:13 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java line
>> 120:
>>
>>> 118: * @since 21
>>> 119: */
>>> 120: public static final int MAX_INDY_CONCAT_ARG_SLOTS;
>>
>> May this value change in the f
On Wed, 10 Apr 2024 08:41:19 GMT, Christian Stein wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more tests for ambiguities.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.propertie
> This is an implementation of JEP JDK-8315129: Module Import Declarations
> (Preview). Please see the JEP for details:
> https://bugs.openjdk.org/browse/JDK-8315129
>
> It is mostly straightforward - the module imports are parsed, and then
> expanded to import-on-demand in `TypeEnter`.
> There
On Wed, 10 Apr 2024 11:52:31 GMT, Maurizio Cimadamore
wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding more tests for ambiguities.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java line 7
On Thu, 4 Apr 2024 16:46:32 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
This PR proposes to add two overloads `MemorySegment::reinterpretate` to allow
aligned reinterpretation.
-
Commit messages:
- Update copyright year
- Add MemorySegment::reinterpretate overloads for alignment constraints
Changes: https://git.openjdk.org/jdk/pull/18717/files
Webre
On Wed, 10 Apr 2024 01:31:36 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/time/temporal/ChronoField.java line 590:
>>
>>> 588: * This is necessary to ensure interoperation between calendars.
>>> 589: *
>>> 590: * Range of {@code InstantSeconds} is between {@link I
On Tue, 9 Apr 2024 13:38:29 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and the
On Tue, 9 Apr 2024 23:45:39 GMT, Scott Gibbons wrote:
> Is there any way to disable some of the optimizations C2 will attempt on the
> IR? We need to maintain atomicity, so vectorization shouldn't occur, for
> instance. This seems like a rat-hole that would need constant maintenance as
> C2 op
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
te
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
te
On Wed, 10 Apr 2024 10:45:55 GMT, Jaikiran Pai wrote:
>> Mahendra Chhipa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented review comments.
>> Updated EscapePath test.
>
> test/jdk/javax/naming/spi/providers/InitialContextTes
On Thu, 4 Apr 2024 17:16:22 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>> test/
> This PR removes support for the string template feature from the Java
> compiler and the Java SE API, as discussed here:
>
> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit s
> This PR removes support for the string template feature from the Java
> compiler and the Java SE API, as discussed here:
>
> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit s
On Thu, 4 Apr 2024 17:16:22 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>> test/
On Tue, 9 Apr 2024 20:22:34 GMT, Chen Liang wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert StringConcatFactory field to before string template
>
> src/java.base/share/classes/java/lang/invoke/StringC
On Thu, 4 Apr 2024 17:16:22 GMT, Mahendra Chhipa wrote:
>> Updated following tests to use ProcessTools methods:
>> test/jdk/java/lang/Thread/UncaughtExceptionsTest.java
>> test/jdk/java/lang/annotation/LoaderLeakTest.java
>> test/jdk/java/rmi/reliability/benchmark/bench/rmi/Main.java
>> test/
> This PR removes support for the string template feature from the Java
> compiler and the Java SE API, as discussed here:
>
> https://mail.openjdk.org/pipermail/amber-spec-experts/2024-April/004106.html
Maurizio Cimadamore has updated the pull request incrementally with one
additional commit s
> Allow support for both .a and .so files in AIX.
> If .so file is not found, allow fallback to .a extension.
> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516)
Suchismith Roy has updated the pull request incrementally with one additional
commit since the last revision:
te
On Tue, 9 Apr 2024 13:38:29 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and the
On Tue, 9 Apr 2024 21:03:57 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update the copyright year to 2024
>
> Trivially, what's the reason you capitalised the word "tags" in the PR title
> an
On Tue, 9 Apr 2024 10:01:59 GMT, Suchismith Roy wrote:
>> test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java
>> line 37:
>>
>>> 35: File awtSharedObjectPath = new File("/test/lib/libawt.so");
>>> 36: File awtArchivePath = new File("/test/lib/lib
On Tue, 9 Apr 2024 17:26:46 GMT, Alan Bateman wrote:
> If we expand the tracing then I think it should be consistent with the
> existing tracing.
I just added some tracing calls where I missed them. Do you think I should do
some more adjustments ?
Btw. is the `GetApplicationHomeFromDll` (
58 matches
Mail list logo
