> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`,
> with the (hopefully) obvious semantics, plus the corresponding wiring to make
> those work. This may become part of JEP 495:
> https://openjdk.org/jeps/495
Jan Lahoda has updated the pull request incrementally with on
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up references to "JRE"
> from the launcher's code?
>
> No functional changes have been introduced in this change.
>
> No new tests have been introduced and existing tests in tier1, tie
Can I please get a review of this change which cleans up references to "JRE"
from the launcher's code?
No functional changes have been introduced in this change.
No new tests have been introduced and existing tests in tier1, tier2 and tier3
continue to pass in our CI against Linux, macosx and W
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 18 Oct 2024 10:01:59 GMT, Shaojin Wen wrote:
> Cache commonly used classDesc to avoid creating ReferenceClassDescImpl every
> time
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21580
On Thu, 24 Oct 2024 16:31:20 GMT, Jorn Vernee wrote:
>> This PR includes changes to ensure `Code:` block indentation in `javap`for
>> the `-verbose` case and non `-verbose` case is the same, which currently
>> does not hold.
>>
>> Current behaviour of `javap` differs with and without `-verbose
On Thu, 24 Oct 2024 14:57:19 GMT, Jonathan Lampérth wrote:
> This PR includes changes to ensure `Code:` block indentation in `javap`for
> the `-verbose` case and non `-verbose` case is the same, which currently does
> not hold.
>
> Current behaviour of `javap` differs with and without `-verbos
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 23 Oct 2024 22:14:13 GMT, Jiangli Zhou wrote:
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
@iklam Would it be possible to comment on this? If the s
On Thu, 24 Oct 2024 07:11:16 GMT, David Holmes wrote:
> > the way I did it I'd have to force push
>
> That should not be the case. You can just anti-delta changes.
I did it in a really inefficient way, by checking out all files except for the
files that I wanted to stay. I could not figure out
On Thu, 24 Oct 2024 17:27:33 GMT, Alexey Ivanov wrote:
> > I think we have finally decided that jtreg tag will come after copyright
> > and before imports...Applicable for all modified javax_swing tests in this
> > PR...
>
> Did we agree on that?
Atleast client-dev team did..
See this initial
On Thu, 24 Oct 2024 21:08:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Wed, 23 Oct 2024 08:58:30 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdirectory of the input directory.
>
> jpackage will produce a
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdirectory of the input directory.
>
> jpackage will produce a
On Thu, 24 Oct 2024 13:41:13 GMT, Emanuel Peter wrote:
>> To exercise non memory operand pattern we need a vector operation padding
>> layer after load vector, this will always ensure that selector pick all
>> register operands flavor of instruction. Since its a generic limitation, do
>> you t
On Thu, 24 Oct 2024 22:07:52 GMT, Magnus Ihse Bursie wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
On Thu, 29 Aug 2024 01:30:55 GMT, Shaojin Wen wrote:
> A small optimization to simplify the implementation logic of
> LambdaForm$BasicType#basicType method can reduce the call stack and reduce
> the overall bytecode size.
>
> Below is the compiler log
>
> * baseline
>
> @ 1 java.lang.invo
On Fri, 25 Oct 2024 01:38:55 GMT, Henry Jen wrote:
> Check output for including values rather than exact match.
> Also include the manpage change and revert the problem list.
Marked as reviewed by jpai (Reviewer).
test/jdk/tools/jar/MultipleManifestTest.java line 203:
> 201:
> 202: priva
On Fri, 25 Oct 2024 03:01:50 GMT, Chen Liang wrote:
>> This PR includes changes to ensure `Code:` block indentation in `javap`for
>> the `-verbose` case and non `-verbose` case is the same, which currently
>> does not hold.
>>
>> Current behaviour of `javap` differs with and without `-verbose`
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Mon, 21 Oct 2024 09:12:25 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replacing flag based checks with CPU feature checks in IR validation test.
>
> Wow this is really a very moving targe
Check output for including values rather than exact match.
Also include the manpage change and revert the problem list.
-
Commit messages:
- 8342930: New tests from JDK-8335912 are failing
Changes: https://git.openjdk.org/jdk/pull/21697/files
Webrev: https://webrevs.openjdk.org/?
This PR includes changes to ensure `Code:` block indentation in `javap`for the
`-verbose` case and non `-verbose` case is the same, which currently does not
hold.
Current behaviour of `javap` differs with and without `-verbose` in the
following way:
**Command**: `javap -c -XDdetails:stackMaps A
Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM reasonable
or necessary flags, but when deploying and running micros we often want to add
or replace flags to tune to the machine, test different GCs, etc. The
inconsistent use of the different `jvmArgs` options make it error p
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote:
> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM
> reasonable or necessary flags, but when deploying and running micros we often
> want to add or replace flags to tune to the machine, test different GCs, etc.
> The i
On Thu, 24 Oct 2024 02:41:43 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Thre
- It is not clear on which macOS versions codesign fails if application bundle
contains additional content.
- As a result test was modified to generate only application image, since PKG
or DMG cannot be generated if signing fails. Exit code of jpackage is ignored,
but generated application image
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 03:38:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 08:08:56 GMT, Stefan Karlsson wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix comment in objectMonitor.hpp and javaThread.hpp
>> - Skip printing tid when not available
>
> src/h
On Wed, 23 Oct 2024 18:36:01 GMT, Viktor Klang wrote:
> Having opted in to allow setting an SM is a clearer signal.
Targeting jdk23u instead of here. Closing.
-
PR Comment: https://git.openjdk.org/jdk/pull/21668#issuecomment-2435598811
> Please review a doc-only change to fix the order of javadoc @param tags in in
> various OpenJDK modules. This is the third and last PR to fix the order of
> @param tags in OpenJDK libraries.
>
> We are working on a javadoc feature to add an opt-in doclint warning for
> @param tags that don't
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote:
> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM
> reasonable or necessary flags, but when deploying and running micros we often
> want to add or replace flags to tune to the machine, test different GCs, etc.
> The i
On Thu, 24 Oct 2024 21:08:26 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 05:51:38 GMT, Ioi Lam wrote:
>> @iklam Would it be possible to comment on this? If the system properties to
>> configure the range of integer cache are set at runtime, does it just not
>> use this archived object graph? I'm wondering if it should disable CDS?
>
>> @iklam Wo
On Thu, 24 Oct 2024 02:57:18 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Virt
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote:
> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM
> reasonable or necessary flags, but when deploying and running micros we often
> want to add or replace flags to tune to the machine, test different GCs, etc.
> The i
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
On Wed, 23 Oct 2024 01:40:59 GMT, Jiangli Zhou wrote:
> > When trying to sort out the LDFLAGS issues, it turned out that I could not
> > run the linux launcher at all, not even when checking out older commits of
> > this PR. I am almost at a loss here; I assume that this worked when I
> > crea
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>>
On Thu, 24 Oct 2024 16:11:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 16:35:44 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 21:08:47 GMT, Patricio Chilano Mateo
wrote:
>> I guess I don't understand where this piece code fits in the overall
>> transition of the virtual thread to being parked. I would have expected the
>> LockStack to already have been moved by the time we switch identities to the
On Thu, 24 Oct 2024 08:26:12 GMT, Alan Bateman wrote:
>> So really UNBLOCKED is UNBLOCKING and mirrors BLOCKING , so we have:
>>
>> RUNNING -> BLOCKING -> BLOCKED
>> BLOCKED -> UNBLOCKING -> RUNNABLE
>>
>> I'm just trying to get a better sense of what we can infer if we see these
>> "transitio
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Thu, 24 Oct 2024 02:55:18 GMT, David Holmes wrote:
>>> Also JavaThread::_lock_id in the VM means "the java.lang.Thread thread-id
>>> to use for locking" - correct?
>>>
>> Yes.
>
> I guess I don't understand where this piece code fits in the overall
> transition of the virtual thread to being
On Thu, 24 Oct 2024 05:10:56 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix comment in objectMonitor.hpp and javaThread.hpp
>> - Skip printing tid when not available
>
> src/hots
On Thu, 24 Oct 2024 06:18:10 GMT, David Holmes wrote:
>> So the value stored in _owner has to be ANONYMOUS_OWNER. We cannot store the
>> BasicLock* in there as before since it can clash with some other thread's
>> tid. We store it in the new field _stack_locker instead.
>
> Right I understand w
On Thu, 24 Oct 2024 17:58:55 GMT, Harshitha Onkar wrote:
> It was missed when `-Djava.security.manager=allow` was removed.
It wasn't intentional then, was it?
> Out of curiosity: does it have any impact on the performance of CI testing if
> tests are run in /othervm mode when it is not needed?
On Fri, 18 Oct 2024 14:42:39 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, with
the (hopefully) obvious semantics, plus the corresponding wiring to make those
work. This may become part of JEP 495:
https://openjdk.org/jeps/495
-
Commit messages:
- Adding support for IO.readln()
-
On Thu, 24 Oct 2024 14:57:19 GMT, Jonathan Lampérth wrote:
> This PR includes changes to ensure `Code:` block indentation in `javap`for
> the `-verbose` case and non `-verbose` case is the same, which currently does
> not hold.
>
> Current behaviour of `javap` differs with and without `-verbos
On Wed, 23 Oct 2024 18:36:01 GMT, Viktor Klang wrote:
> Having opted in to allow setting an SM is a clearer signal.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/21668
On Wed, 23 Oct 2024 21:54:25 GMT, Sean Mullan wrote:
>> test/jdk/java/lang/RuntimeTests/exec/ExecCommand.java line 241:
>>
>>> 239: Properties props = System.getProperties();
>>> 240: props.setProperty(JDK_LANG_PROCESS_ALLOW_AMBIGUOUS_COMMANDS,
>>> "");
>>> 241: System.s
We were made aware of the fact the `TestLargeStub::testUpcall` was not actually
calling `Linker::upcallStub`. This PR addresses that issue.
-
Commit messages:
- Call upcallStub method in TestLargeStub::upcallStub
Changes: https://git.openjdk.org/jdk/pull/21691/files
Webrev: https
On Fri, 18 Oct 2024 19:03:30 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 14:55:57 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 13:52:57 GMT, Claes Redestad wrote:
> Many OpenJDK micros use `@Fork(jvmArgs/-Append/-Prepend)` to add JVM
> reasonable or necessary flags, but when deploying and running micros we often
> want to add or replace flags to tune to the machine, test different GCs, etc.
> The i
On Thu, 24 Oct 2024 15:09:00 GMT, Viktor Klang wrote:
> Make final adjustments to drop PreviewFeature and updating the @ since
> markers.
src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 79:
> 77: @JEP(number=466, title="ClassFile API", status="Second Preview")
>
On Wed, 23 Oct 2024 04:46:51 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Thu, 24 Oct 2024 13:59:58 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/x86.ad line 10593:
>>
>>> 10591: match(Set dst (SaturatingAddV src1 src2));
>>> 10592: match(Set dst (SaturatingSubV src1 src2));
>>> 10593: format %{ "vector_addsub_saturating_subword $dst, $src1, $src2" %}
>>
On Thu, 17 Oct 2024 20:14:05 GMT, Justin Lu wrote:
> Please review this PR which improves the readObject logic for
> _j.text.MessageFormat_.
>
> No offset should be larger than the pattern length. We already ensure the
> offsets when consumed backwards are equal/descending. The existing
> fir
> Modify `FileInputStream` (FIS) to fall back to the superclass implementations
> of `readAllBytes()`, `readNBytes(int)`, `skip()`, and `transferTo` when the
> input source would otherwise fail with "Illegal Seek" in the FIS
> implementation, such as for the standard input or a named pipe.
Bria
On Thu, 24 Oct 2024 05:51:38 GMT, Ioi Lam wrote:
> > @iklam Would it be possible to comment on this? If the system properties to
> > configure the range of integer cache are set at runtime, does it just not
> > use this archived object graph? I'm wondering if it should disable CDS?
>
> A bette
On Thu, 24 Oct 2024 13:41:13 GMT, Emanuel Peter wrote:
>> To exercise non memory operand pattern we need a vector operation padding
>> layer after load vector, this will always ensure that selector pick all
>> register operands flavor of instruction. Since its a generic limitation, do
>> you t
On Thu, 24 Oct 2024 14:00:39 GMT, Jaikiran Pai wrote:
>> readAllBytes reads to EOF so there isn't any benefit to caching. I think the
>> main thing with this PR is whether canSeek is the right thing to use.
>
> Hello Alan, I didn't just mean the readAllBytes. The rest of the changes in
> this P
On Thu, 24 Oct 2024 13:31:00 GMT, Jatin Bhateja wrote:
>> Also: why did we not add these `Long.minUnsigned` etc? I guess that was
>> already discussed?
>> Because we can easily also use this with the auto-vectorizer or more
>> generally. Saturating and unsigned ops are generally useful I think.
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
On Thu, 24 Oct 2024 13:36:53 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 37 commits:
>>
>> - Review resolutions.
>> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK
On Wed, 23 Oct 2024 22:15:34 GMT, Kevin Bourrillion wrote:
> An issue with the simple name `of` is that we may encounter calls like this:
>
> `Reader.of("/usr/share/dict/words")`
>
> ... that may look like they do something different. I can't say whether we
> should consider this a serious iss
On Thu, 24 Oct 2024 13:56:10 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/FileInputStream.java line 334:
>>
>>> 332: @Override
>>> 333: public byte[] readAllBytes() throws IOException {
>>> 334: if (!canSeek())
>>
>> Since `canSeek()` is implemented as a nativ
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unused warnings and addressed all of them by commenting out th
On Wed, 23 Oct 2024 06:14:52 GMT, Chen Liang wrote:
>> @cl4es discovered that Stack Map generation in ClassFile API uses
>> `componentType` and `arrayType` for `aaload` `aastore` instructions, which
>> are currently quite slow. We can split out array class descriptors from
>> class or interfac
On Wed, 23 Oct 2024 11:58:26 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/invoke/RevealDirectTest.java line 33:
>>
>>> 31: * @test
>>> 32: * @summary verify Lookup.revealDirect on a variety of input handles,
>>> with security manager
>>> 33: * @run
>>> main/othervm/policy=jtreg.security.p
On Mon, 21 Oct 2024 22:51:54 GMT, Mandy Chung wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 97 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Change apiNote to de
On Thu, 24 Oct 2024 11:29:01 GMT, Jaikiran Pai wrote:
>> Modify `FileInputStream` (FIS) to fall back to the superclass
>> implementations of `readAllBytes()`, `readNBytes(int)`, `skip()`, and
>> `transferTo` when the input source would otherwise fail with "Illegal Seek"
>> in the FIS implement
On Thu, 24 Oct 2024 13:36:50 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>
On Thu, 24 Oct 2024 06:31:00 GMT, Emanuel Peter wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMath.java
>> line 32:
>>
>>> 30: * @since 24
>>> 31: */
>>> 32: public final class VectorMath {
>>
>> I think this class could have been split into a separate RFE, to
On Thu, 24 Oct 2024 06:46:32 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Factor out IR tests and Transforms to follow-up PRs.
>
> src/hotspot/cpu/x86/x86.ad line 10790:
>
>> 10788: predic
> Hi All,
>
> As per the discussion on panama-dev mailing list[1], patch adds the support
> for following new vector operators.
>
>
> . SUADD : Saturating unsigned addition.
> . SADD: Saturating signed addition.
> . SUSUB : Saturating unsigned subtraction.
> . SSUB
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Thu, 24 Oct 2024 12:17:41 GMT, Hannes Wallnöfer wrote:
>> Please review a doc-only change to fix the order of javadoc @param tags in
>> in various OpenJDK modules. This is the third and last PR to fix the order
>> of @param tags in OpenJDK libraries.
>>
>> We are working on a javadoc featur
Test java/io/IO/IO.java fails on Linux ppc64le because of issues with 'expect' .
-
Commit messages:
- JDK-8342938
Changes: https://git.openjdk.org/jdk/pull/21678/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21678&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8342
On Tue, 22 Oct 2024 13:36:43 GMT, Hannes Wallnöfer wrote:
> Please review a doc-only change to fix the order of javadoc @param tags in in
> various OpenJDK modules. This is the third and last PR to fix the order of
> @param tags in OpenJDK libraries.
>
> We are working on a javadoc feature to
On Wed, 23 Oct 2024 22:52:52 GMT, Brian Burkhalter wrote:
> Modify `FileInputStream` (FIS) to fall back to the superclass implementations
> of `readAllBytes()`, `readNBytes(int)`, `skip()`, and `transferTo` when the
> input source would otherwise fail with "Illegal Seek" in the FIS
> implement
On Thu, 24 Oct 2024 07:15:53 GMT, Alan Bateman wrote:
>> but you won't see access_controller_klass or priviledged_action_klass
>> frames, so no need to skip them? Not sure why you'd want to skip class
>> loader frames here.
>
> Right, although you might have to wait until there is more cleanup
On Wed, 23 Oct 2024 20:36:23 GMT, Patricio Chilano Mateo
wrote:
>> Sorry, I should add context on why this is needed. The problem is that
>> inside this temporal transition we could try to acquire some monitor. If the
>> monitor is not inflated we will try to use the LockStack, but the LockSta
On Tue, 15 Oct 2024 20:22:52 GMT, Magnus Ihse Bursie wrote:
>> As a prerequisite for Hermetic Java, we need a statically linked `java`
>> launcher. It should behave like the normal, dynamically linked `java`
>> launcher, except that all JDK native libraries should be statically, not
>> dynamic
On Tue, 22 Oct 2024 11:06:44 GMT, Jan Lahoda wrote:
>> Currently, running `java` without any parameters will lead to an output that
>> is a full `--help`, which is over 100 lines (on my computer at least), and
>> it feels overwhelming. And many people might actually want to run
>> JShell/REPL,
On Thu, 24 Oct 2024 08:51:47 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Wed, 23 Oct 2024 18:36:01 GMT, Viktor Klang wrote:
> Having opted in to allow setting an SM is a clearer signal.
The change looks okay but the code will be removed after JEP 486 integrates. So
better to re-base for jdk23u, even though this business of setting a SM
mid-flight is (and always
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
On Thu, 24 Oct 2024 02:47:14 GMT, David Holmes wrote:
>> Not really, it is the state we set when the virtual thread is mounted and
>> runs again. In this case it will just run to re-contest for the monitor.
>
> So really UNBLOCKED is UNBLOCKING and mirrors BLOCKING , so we have:
>
> RUNNING ->
On Thu, 24 Oct 2024 03:38:21 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
1 - 100 of 110 matches
Mail list logo
