On Wed, 4 Jun 2025 13:12:33 GMT, Shaojin Wen wrote:
>> Some static final arrays of BigInteger and BigDecimal are stable and
>> immutable. We should add `@Stable` to give the optimizer more information
>
> Shaojin Wen has updated the pull request with a new target base due to a
> merge or a reba
On Mon, 21 Jul 2025 00:32:24 GMT, simon wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/ClassFileVersionImpl.java
>> line 54:
>>
>>> 52: public Optional formatVersion() {
>>> 53: try {
>>> 54: return
>>> Optional.of(ClassFileFormatVersion.fromMajor(maj
On Mon, 21 Jul 2025 00:11:20 GMT, Chen Liang wrote:
>> 8355652: add new method to return ClassFileFormatVersion from
>> ClassFileVersion.
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer)
On Sun, 20 Jul 2025 22:19:07 GMT, simon wrote:
> 8355652: add new method to return ClassFileFormatVersion from
> ClassFileVersion.
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] C
On Sun, 20 Jul 2025 23:36:53 GMT, Chen Liang wrote:
> > I think we should create some unit tests for this API and classes involved.
> > Where do you think that is the most appropriate location in the project to
> > do it?
>
> Unit tests for `java.lang.classfile` reside in `test/jdk/jdk/classfi
On Sun, 20 Jul 2025 23:30:50 GMT, simon wrote:
> I think we should create some unit tests for this API and classes involved.
> Where do you think that is the most appropriate location in the project to do
> it?
Unit tests for `java.lang.classfile` reside in `test/jdk/jdk/classfile`. They
can
On Sun, 20 Jul 2025 22:19:07 GMT, simon wrote:
> 8355652: add new method to return ClassFileFormatVersion from
> ClassFileVersion.
> -
> ### Progress
> - [ ] Change must be properly reviewed (1 review required, with at least 1
> [Reviewer](https://openjdk.org/bylaws#reviewer))
> - [x] C
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Formatting changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24898/files
- new:
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Minor change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24898/files
- new: https:
8355652: add new method to return ClassFileFormatVersion from ClassFileVersion.
-
### Progress
- [ ] Change must be properly reviewed (1 review required, with at least 1
[Reviewer](https://openjdk.org/bylaws#reviewer))
- [x] Change must not contain extraneous whitespace
- [x] Commit messag
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Minor change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24898/files
- new: https:
On Wed, 18 Jun 2025 04:41:06 GMT, David Holmes wrote:
>
> I see a few tests that do that, nearly all of which are network tests. It is
> not something I was familiar with. But it doesn't seem right to me that a
> particular test would use that property to change the behaviour of
> `OutputAnal
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with two additional
commits since the last revision:
- Removed trailingwhitespace
- Revision changes
Revision changes, with explanation comment for init
13 matches
Mail list logo
