Re: RFR: 8303762: Optimize vector slice operation with constant index using VPALIGNR instruction [v7]

2025-08-12 Thread Jatin Bhateja
> Patch optimizes Vector. slice operation with constant index using x86 ALIGNR > instruction. > It also adds a new hybrid call generator to facilitate lazy intrinsification > or else perform procedural inlining to prevent call overhead and boxing > penalties in case the fallback implementation e

Re: RFR: 8303762: Optimize vector slice operation with constant index using VPALIGNR instruction [v2]

2025-08-12 Thread Jatin Bhateja
On Tue, 12 Aug 2025 05:58:47 GMT, Xiaohong Gong wrote: >>> Q1: Is it possible that just passing `origin->get_con()` to >>> `VectorSliceNode` in case there are architectures that need it directly? >>> Or, maybe we'd better add comment telling that the origin passed to >>> `VectorSliceNode` is a

Re: RFR: 8303762: Optimize vector slice operation with constant index using VPALIGNR instruction [v6]

2025-08-12 Thread Jatin Bhateja
> Patch optimizes Vector. slice operation with constant index using x86 ALIGNR > instruction. > It also adds a new hybrid call generator to facilitate lazy intrinsification > or else perform procedural inlining to prevent call overhead and boxing > penalties in case the fallback implementation e

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1

2025-08-12 Thread SendaoYan
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote: > This changes the timeout factor from 4 to 1. Most of the changes add timeouts > to individual test cases so that I am able to run them with a timeout factor > of 0.7 (some margin to the checked in factor of one) > > In addition to changing

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1

2025-08-12 Thread SendaoYan
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote: > This changes the timeout factor from 4 to 1. Most of the changes add timeouts > to individual test cases so that I am able to run them with a timeout factor > of 0.7 (some margin to the checked in factor of one) > > In addition to changing

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v3]

2025-08-12 Thread Volkan Yazici
On Tue, 12 Aug 2025 15:58:13 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Simplify added null checks >> - Avoid code duplication by sprinkling some generics magic > > src/java.base/share/clas

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v4]

2025-08-12 Thread Volkan Yazici
> `NoRepl`-suffixed `String` methods denote methods that do not replace invalid > characters, but throw `CharacterCodingException` on encounter. This behavior > cannot easily be derived from the method footprints, has been a source of > confusion for maintainers, and is not uniformly adopted, e.

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1

2025-08-12 Thread Chris Plummer
On Tue, 12 Aug 2025 17:01:41 GMT, Leo Korinth wrote: > sun/tools/jhsdb/BasicLauncherTest.java > I am unsure about this one, it has not failed on my runs before, even with a > timeout factor of 0.7, maybe I was unlucky. @lkorinth Can you send me a link to the failure? - PR Comment:

RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1

2025-08-12 Thread Leo Korinth
This changes the timeout factor from 4 to 1. Most of the changes add timeouts to individual test cases so that I am able to run them with a timeout factor of 0.7 (some margin to the checked in factor of one) In addition to changing the timeout factor, I am also using a library call to parse the

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v3]

2025-08-12 Thread Chen Liang
On Tue, 12 Aug 2025 12:11:07 GMT, Volkan Yazici wrote: >> `NoRepl`-suffixed `String` methods denote methods that do not replace >> invalid characters, but throw `CharacterCodingException` on encounter. This >> behavior cannot easily be derived from the method footprints, has been a >> source o

Re: RFR: 8365017: The SegmentBulkOperations::copy method can be improved using overlaps [v6]

2025-08-12 Thread Emanuel Peter
On Mon, 11 Aug 2025 16:31:17 GMT, Per Minborg wrote: >> This PR proposes to use overlapping memory areas in >> `SegmentBulkOperations::copy`, similar to what is proposed for >> `SegmentBulkOperations::fill` in https://github.com/openjdk/jdk/pull/25383. >> >> This PR passes `tier1`, `tier2`, an

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v4]

2025-08-12 Thread Viktor Klang
On Tue, 12 Aug 2025 11:54:38 GMT, Per Minborg wrote: >> @ExE-Boss That seems to presume that 1) it will be called again, and 2) it >> will eventually produce a non-exception > > The underlying function will be retained until all values are computed (non > exceptionally). It is as simple as that

Integrated: 8365307: AIX make fails after JDK-8364611

2025-08-12 Thread Matthias Baesken
On Tue, 12 Aug 2025 08:18:30 GMT, Matthias Baesken wrote: > After recent change > [JDK-8364611](https://bugs.openjdk.org/browse/JDK-8364611), the build fails > on AIX with : > > > /priv/jenkins/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/test/jdk/java/lang/ProcessBuilder/childSignalDi

Re: RFR: 8365307: AIX make fails after JDK-8364611

2025-08-12 Thread Matthias Baesken
On Tue, 12 Aug 2025 11:57:24 GMT, Christoph Langer wrote: > Thanks for fixing the build. Can't act.sa_mask be printed somehow on AIX, > though? We have a member`sigset_t sa_mask ` in the struct and most likely can evaluate this member, but it is only test coding so probably not worth much

Re: RFR: 8365307: AIX make fails after JDK-8364611

2025-08-12 Thread Matthias Baesken
On Tue, 12 Aug 2025 08:18:30 GMT, Matthias Baesken wrote: > After recent change > [JDK-8364611](https://bugs.openjdk.org/browse/JDK-8364611), the build fails > on AIX with : > > > /priv/jenkins/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/test/jdk/java/lang/ProcessBuilder/childSignalDi

Re: RFR: 8365307: AIX make fails after JDK-8364611

2025-08-12 Thread Andreas Steiner
On Tue, 12 Aug 2025 08:18:30 GMT, Matthias Baesken wrote: > After recent change > [JDK-8364611](https://bugs.openjdk.org/browse/JDK-8364611), the build fails > on AIX with : > > > /priv/jenkins/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/test/jdk/java/lang/ProcessBuilder/childSignalDi

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v2]

2025-08-12 Thread Volkan Yazici
On Fri, 8 Aug 2025 17:29:34 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v3]

2025-08-12 Thread Volkan Yazici
On Mon, 21 Jul 2025 13:00:03 GMT, Chen Liang wrote: > The docs should mention these two details: > > 1. This method does not replace upon malformed data but fails > 2. This method does not copy the byte array for validation (can add to the > warning) @liach, I presume you want more than the fo

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v3]

2025-08-12 Thread Volkan Yazici
On Mon, 28 Jul 2025 22:34:08 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Simplify added null checks >> - Avoid code duplication by sprinkling some generics magic > > src/java.base/share/cla

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v3]

2025-08-12 Thread Volkan Yazici
On Tue, 29 Jul 2025 14:22:56 GMT, Roger Riggs wrote: >> src/java.base/share/classes/java/lang/String.java line 1262: >> >>> 1260: MalformedInputException mie = new MalformedInputException(nb); >>> 1261: String msg = "malformed input off : " + off + ", length : " + >>> nb; >>> 12

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v3]

2025-08-12 Thread Volkan Yazici
> `NoRepl`-suffixed `String` methods denote methods that do not replace invalid > characters, but throw `CharacterCodingException` on encounter. This behavior > cannot easily be derived from the method footprints, has been a source of > confusion for maintainers, and is not uniformly adopted, e.

Re: RFR: 8365307: AIX make fails after JDK-8364611

2025-08-12 Thread Christoph Langer
On Tue, 12 Aug 2025 08:18:30 GMT, Matthias Baesken wrote: > After recent change > [JDK-8364611](https://bugs.openjdk.org/browse/JDK-8364611), the build fails > on AIX with : > > > /priv/jenkins/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/test/jdk/java/lang/ProcessBuilder/childSignalDi

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v4]

2025-08-12 Thread Per Minborg
On Tue, 12 Aug 2025 09:09:17 GMT, Viktor Klang wrote: >> No, because the stable value doesn’t get set in that case, so the  >> supplier/function will be called again. > > @ExE-Boss That seems to presume that 1) it will be called again, and 2) it > will eventually produce a non-exception The und

Re: RFR: 8360025: (se) Convert kqueue Selector Implementation to use FFM APIs

2025-08-12 Thread Darragh Clarke
On Thu, 31 Jul 2025 12:15:32 GMT, Maurizio Cimadamore wrote: >> IMHO the more honest approach is to move these constants closer to the _h >> generated files that use them, as that's the way jextract intends them to be >> used. > > (Also, the latest version of jextract uses `Linker.canonicalLay

Re: RFR: 8360025: (se) Convert kqueue Selector Implementation to use FFM APIs

2025-08-12 Thread Darragh Clarke
On Sat, 26 Jul 2025 07:46:25 GMT, ExE Boss wrote: >> This PR aims to Panamize the Java Kqueue implementation, This is based on >> the work that was previously shared in >> https://github.com/openjdk/jdk/pull/22307 , The main change since then is >> that this branch takes advantage of the chang

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v5]

2025-08-12 Thread Per Minborg
> This PR proposes to release the underlying function if a stable function or > collection has invoked its underlying supplier exhaustively so that it can be > collected. > > This PR passes tier1, tier2, and tier3 testing on multiple platforms. Per Minborg has updated the pull request with a ne

Re: RFR: 8359936: StableValues can release the underlying function after complete computation [v4]

2025-08-12 Thread Viktor Klang
On Mon, 11 Aug 2025 18:08:40 GMT, ExE Boss wrote: >> src/java.base/share/classes/jdk/internal/lang/stable/StableValueImpl.java >> line 174: >> >>> 172: // Reduce the counter and if it reaches zero, >>> clear the reference >>> 173: // to the underlying ho

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v47]

2025-08-12 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Integrated: 8360037: Refactor ImageReader in preparation for Valhalla support

2025-08-12 Thread David Beaumont
On Mon, 30 Jun 2025 23:27:49 GMT, David Beaumont wrote: > Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code com

Integrated: 7191877: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently

2025-08-12 Thread Johny Jose
On Wed, 6 Aug 2025 10:29:45 GMT, Johny Jose wrote: > The test was problem listed since jdk8 as intermittent failures were > observed. For all the failed scenarios, number of objects left in leaseTable > were less than or equal to 4. Though for most of the runs the number of > objects left is l

Re: RFR: 8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics [v8]

2025-08-12 Thread Volkan Yazici
On Thu, 17 Jul 2025 13:58:32 GMT, Raffaello Giulietti wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Replace casting with `as_Region()` in `generate_string_range_check` > > src/java.base/share/classes/java/lang/

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F [v3]

2025-08-12 Thread Bhavana Kilambi
On Tue, 12 Aug 2025 04:33:04 GMT, Galder Zamarreño wrote: >> I've done some testing on x86_64 and aarch64 and the tests pass. >> >> I also made sure that the test output demonstrated execution of the expected >> IR rule as per the requirements of each platform. >> >> ## `c7gn.2xlarge` Graviton

RFR: 8365307: AIX make fails after JDK-8364611

2025-08-12 Thread Matthias Baesken
After recent change [JDK-8364611](https://bugs.openjdk.org/browse/JDK-8364611), the build fails on AIX with : /priv/jenkins/client-home/workspace/openjdk-jdk-aix_ppc64-opt/jdk/test/jdk/java/lang/ProcessBuilder/childSignalDisposition/exePrintSignalDisposition.c:75:41: error: format specifies typ

Re: RFR: 8361842: Move input validation checks to Java for java.lang.StringCoding intrinsics [v15]

2025-08-12 Thread Volkan Yazici
> Validate input in `java.lang.StringCoding` intrinsic Java wrappers, improve > their documentation, enhance the checks in the associated IR or assembly > code, and adapt them to cause VM crash on invalid input. > > ## Implementation notes > > The goal of the associated umbrella issue > [JDK-8

Re: RFR: 8364361: [process] java.lang.Process should implement close and be AutoCloseable [v2]

2025-08-12 Thread Andrey Turbanov
On Thu, 7 Aug 2025 22:05:55 GMT, Roger Riggs wrote: >> The teardown of a Process launched by `ProcessBuilder` includes the closing >> of streams and ensuring the termination of the process is the responsibility >> of the caller. The `Process.close()` method provides a clear and obvious way >>

Re: RFR: 8360046: Scalability issue when submitting virtual threads with almost empty tasks [v5]

2025-08-12 Thread Alan Bateman
On Mon, 11 Aug 2025 16:43:05 GMT, Viktor Klang wrote: >> src/java.base/share/classes/java/lang/VirtualThread.java line 324: >> >>> 322: } else { >>> 323: executor.execute(task); >>> 324: } >> >> Is this worth special-casing—IIRC FJP::submit adapts the task if needed

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v20]

2025-08-12 Thread duke
On Tue, 12 Aug 2025 07:32:15 GMT, David Beaumont wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces cod

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v20]

2025-08-12 Thread Alan Bateman
On Tue, 12 Aug 2025 07:32:15 GMT, David Beaumont wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces cod

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v20]

2025-08-12 Thread David Beaumont
> Refactoring `ImageReader` to make it easy to add preview mode functionality > for Valhalla. > > This PR is a large change to `ImageReader` (effectively a rewrite) but > reduces the surface area of the API significantly, reduces code complexity > and increases performance/memory efficiency. Th

Re: RFR: 8365240: [asan] exclude some tests when using asan enabled binaries

2025-08-12 Thread Matthias Baesken
On Mon, 11 Aug 2025 11:52:00 GMT, Matthias Baesken wrote: > When using asan - enabled binaries, the following tests fail (on Linux > x86_64). > This one uses ulimit in a way problematic with asan : > vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java > > ``` > stdout: []; > stderr: [==19509

Integrated: 8365240: [asan] exclude some tests when using asan enabled binaries

2025-08-12 Thread Matthias Baesken
On Mon, 11 Aug 2025 11:52:00 GMT, Matthias Baesken wrote: > When using asan - enabled binaries, the following tests fail (on Linux > x86_64). > This one uses ulimit in a way problematic with asan : > vmTestbase/nsk/jvmti/Allocate/alloc001/alloc001.java > > ``` > stdout: []; > stderr: [==19509

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v19]

2025-08-12 Thread duke
On Mon, 11 Aug 2025 17:30:08 GMT, David Beaumont wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces cod

Re: RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v19]

2025-08-12 Thread Jaikiran Pai
On Mon, 11 Aug 2025 17:30:08 GMT, David Beaumont wrote: >> Refactoring `ImageReader` to make it easy to add preview mode functionality >> for Valhalla. >> >> This PR is a large change to `ImageReader` (effectively a rewrite) but >> reduces the surface area of the API significantly, reduces cod