Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-24 Thread David Holmes
On Fri, 22 Aug 2025 15:41:21 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/hotspot/jtreg/compiler/tiered/Level2RecompilationT

Integrated: 8365893: test/jdk/java/lang/Thread/virtual/JfrEvents.java failing intermittently

2025-08-24 Thread Alan Bateman
On Sun, 24 Aug 2025 07:59:05 GMT, Alan Bateman wrote: > Under load conditions, testVirtualThreadStartAndEnd can fail because the JFR > recording doesn't have a VirtualThreadEndEvent recorded for all virtual > threads. This is a test issue. ExecutorService::close waits for all tasks > (not thre

Re: Proposal: Add getRandom() default method to java.util.List

2025-08-24 Thread Viktor Klang
While I'm sympathetic to the use-case, I think adding such a method to List is the wrong move—you could equally argue that there should be a randomIterator(), a randomSet(), a randomAdd(). And it wouldn't be coherent with the specification of the List-methods to create a wrapper-type which would

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-24 Thread Alan Bateman
On Fri, 22 Aug 2025 18:43:29 GMT, Albert Mingkun Yang wrote: >>> @prrace the change maintains the same absolute timeout value for those >>> tests. Before the default of 120 was multiplied by the timeoutFactor of 4 >>> to given 480. Now the value 480 is multiplied by the timeoutFactor of 1 to >

Re: Proposal: Add getRandom() default method to java.util.List

2025-08-24 Thread Alan Bateman
On 23/08/2025 20:36, Daniel Tavares wrote: : *Proposed Method* default T getRandom() {     if (isEmpty()) return null;     int index = ThreadLocalRandom.current().nextInt(size());     return get(index); } Add Lists that are mutable and support concurrent access to your list to think about. Th

Re: RFR: 8365893: test/jdk/java/lang/Thread/virtual/JfrEvents.java failing intermittently

2025-08-24 Thread Jaikiran Pai
On Sun, 24 Aug 2025 07:59:05 GMT, Alan Bateman wrote: > Under load conditions, testVirtualThreadStartAndEnd can fail because the JFR > recording doesn't have a VirtualThreadEndEvent recorded for all virtual > threads. This is a test issue. ExecutorService::close waits for all tasks > (not thre

RFR: 8365893: test/jdk/java/lang/Thread/virtual/JfrEvents.java failing intermittently

2025-08-24 Thread Alan Bateman
Under load conditions, testVirtualThreadStartAndEnd can fail because the JFR recording doesn't have a VirtualThreadEndEvent recorded for all virtual threads. This is a test issue. ExecutorService::close waits for all tasks (not threads) to finish. For ThreadPerTaskExecutor the thread terminates