Re: RFR: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps [v15]

2025-08-25 Thread Per Minborg
On Wed, 6 Aug 2025 16:22:30 GMT, Per Minborg wrote: >> This PR builds on a concept John Rose told me about some time ago. Instead >> of combining memory operations of various sizes, a single large and skewed >> memory operation can be made to clean up the tail of remaining bytes. >> >> This ha

Withdrawn: 8357531: The `SegmentBulkOperations::fill` method can be improved using overlaps

2025-08-25 Thread Per Minborg
On Thu, 22 May 2025 07:34:08 GMT, Per Minborg wrote: > This PR builds on a concept John Rose told me about some time ago. Instead of > combining memory operations of various sizes, a single large and skewed > memory operation can be made to clean up the tail of remaining bytes. > > This has th

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v3]

2025-08-25 Thread Jaikiran Pai
On Tue, 26 Aug 2025 05:37:49 GMT, Jaikiran Pai wrote: >> Can I please get a review of this trivial change to the >> `ModuleDescriptor.packages()` method's specification? >> >> The change here clarifies that this method returns all packages that belong >> to the module and not just those that a

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v2]

2025-08-25 Thread Jaikiran Pai
On Tue, 26 Aug 2025 05:18:00 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Chen's and Alan's review > > src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 1519: > >> 1517:

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v3]

2025-08-25 Thread Jaikiran Pai
> Can I please get a review of this trivial change to the > `ModuleDescriptor.packages()` method's specification? > > The change here clarifies that this method returns all packages that belong > to the module and not just those that are exported or open. This > clarification should help avoid

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v2]

2025-08-25 Thread Alan Bateman
On Tue, 26 Aug 2025 00:42:52 GMT, Jaikiran Pai wrote: >> Can I please get a review of this trivial change to the >> `ModuleDescriptor.packages()` method's specification? >> >> The change here clarifies that this method returns all packages that belong >> to the module and not just those that a

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v2]

2025-08-25 Thread Jaikiran Pai
> Can I please get a review of this trivial change to the > `ModuleDescriptor.packages()` method's specification? > > The change here clarifies that this method returns all packages that belong > to the module and not just those that are exported or open. This > clarification should help avoid

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v2]

2025-08-25 Thread Jaikiran Pai
On Mon, 25 Aug 2025 16:50:18 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Chen's and Alan's review > > src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 1519: > >> 1517:

Re: Proposal: Add getRandom() default method to java.util.List

2025-08-25 Thread Daniel Tavares
Thanks Johannes, I just want to improve and contribute to the language. Today, java.util.Random is useful and already helps me a lot. If there's no way to insert the function, that's okay. Best regards, Daniel Perin Tavares Em seg., 25 de ago. de 2025 às 17:51, Johannes Döbler < j...@civilian-f

Re: RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation [v2]

2025-08-25 Thread Iris Clark
On Mon, 25 Aug 2025 19:14:07 GMT, Volker Simonis wrote: >> The JavaDoc of `sun.text.RuleBasedBreakIterator` contains the following link >> to "Text Boundary Analysis in Java" by Richard Gillam which describes its >> implementation details: >> >> http://www.ibm.com/java/education/boundaries/bou

Re: RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation [v2]

2025-08-25 Thread Naoto Sato
On Mon, 25 Aug 2025 19:14:07 GMT, Volker Simonis wrote: >> The JavaDoc of `sun.text.RuleBasedBreakIterator` contains the following link >> to "Text Boundary Analysis in Java" by Richard Gillam which describes its >> implementation details: >> >> http://www.ibm.com/java/education/boundaries/bou

Re: RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation [v2]

2025-08-25 Thread Justin Lu
On Mon, 25 Aug 2025 19:14:07 GMT, Volker Simonis wrote: >> The JavaDoc of `sun.text.RuleBasedBreakIterator` contains the following link >> to "Text Boundary Analysis in Java" by Richard Gillam which describes its >> implementation details: >> >> http://www.ibm.com/java/education/boundaries/bou

Re: Proposal: Add getRandom() default method to java.util.List

2025-08-25 Thread Johannes Döbler
Hi Daniel, what about providing List.getRandom() as an extension method [1] in your projects? Best regards Johannes [1] https://github.com/manifold-systems/manifold/blob/master/manifold-deps-parent/manifold-ext/README.md On 23/08/2025 21:36, Daniel Tavares wrote: Dear OpenJDK community

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v13]

2025-08-25 Thread Artur Barashev
On Wed, 20 Aug 2025 14:38:44 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 616 commits: >> >> - merge latest changes from master branch >> - merge latest http3 changes >> - Hide int

Re: RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation [v2]

2025-08-25 Thread Volker Simonis
On Mon, 25 Aug 2025 17:47:22 GMT, Naoto Sato wrote: > LGTM. Please update the copyright year Done. - PR Comment: https://git.openjdk.org/jdk/pull/26930#issuecomment-3221422600

Re: RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation [v2]

2025-08-25 Thread Volker Simonis
> The JavaDoc of `sun.text.RuleBasedBreakIterator` contains the following link > to "Text Boundary Analysis in Java" by Richard Gillam which describes its > implementation details: > > http://www.ibm.com/java/education/boundaries/boundaries.html > > This link isn't online anymore since at least

Re: RFR: 8365885: Clean up constant pool reflection native code

2025-08-25 Thread Alan Bateman
On Wed, 20 Aug 2025 21:29:29 GMT, Chen Liang wrote: > When I was trying to reuse this constant pool reflection for assembly phase > indy argument validation, I noted the JNI code has a lot of confusing > arguments. In particular, the JVM_ConstantPoolGetSize is wrong because of > argument confu

Re: RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation

2025-08-25 Thread Naoto Sato
On Mon, 25 Aug 2025 15:18:51 GMT, Volker Simonis wrote: > The JavaDoc of `sun.text.RuleBasedBreakIterator` contains the following link > to "Text Boundary Analysis in Java" by Richard Gillam which describes its > implementation details: > > http://www.ibm.com/java/education/boundaries/boundari

Re: RFR: 8365885: Clean up constant pool reflection native code

2025-08-25 Thread Ioi Lam
On Wed, 20 Aug 2025 21:29:29 GMT, Chen Liang wrote: > When I was trying to reuse this constant pool reflection for assembly phase > indy argument validation, I noted the JNI code has a lot of confusing > arguments. In particular, the JVM_ConstantPoolGetSize is wrong because of > argument confu

Re: RFR: 8364751: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive

2025-08-25 Thread Chen Liang
On Mon, 25 Aug 2025 17:31:42 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java line >> 382: >> >>> 380: * or {@code false} depending on whether the >>> least-significant-bit >>> 381: * is 1 or 0 respectively. If {@code value} is

Re: RFR: 8364751: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive

2025-08-25 Thread Jorn Vernee
On Sun, 10 Aug 2025 01:11:43 GMT, Chen Liang wrote: > ConstantBootstraps.explicitCast behaves like a snippet of code in its > specification. However, in the rest of the nominal spec, it incorrectly > assumes a null `value` and a primitive `dstType` results in a > ClassCastException instead of

Re: RFR: 8364751: ConstantBootstraps.explicitCast contradictory specification for null-to-primitive

2025-08-25 Thread Jorn Vernee
On Mon, 25 Aug 2025 17:29:29 GMT, Jorn Vernee wrote: >> ConstantBootstraps.explicitCast behaves like a snippet of code in its >> specification. However, in the rest of the nominal spec, it incorrectly >> assumes a null `value` and a primitive `dstType` results in a >> ClassCastException instea

Re: RFR: 8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors [v2]

2025-08-25 Thread Chen Liang
On Mon, 25 Aug 2025 17:14:16 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> A case for malformed return type > > test/jdk/java/lang/invoke/MethodTypeTest.java line 233: > >> 231: "(jav

Re: RFR: 8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors [v2]

2025-08-25 Thread ExE Boss
On Mon, 25 Aug 2025 14:54:14 GMT, Chen Liang wrote: >> A previous cleanup #14642 accidentally omitted the fact that an >> `Array.newInstance` call in `BytecodeDescriptor::parseSig` is intended to >> propagate `IllegalArgumentException` to >> `MethodType::fromMethodDescriptorString`. This bug i

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved

2025-08-25 Thread Chen Liang
On Mon, 25 Aug 2025 13:19:29 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change to the > `ModuleDescriptor.packages()` method's specification? > > The change here clarifies that this method returns all packages that belong > to the module and not just those that are ex

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved

2025-08-25 Thread Alan Bateman
On Mon, 25 Aug 2025 13:19:29 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change to the > `ModuleDescriptor.packages()` method's specification? > > The change here clarifies that this method returns all packages that belong > to the module and not just those that are ex

Re: Proposal: Add getRandom() default method to java.util.List

2025-08-25 Thread Rob Spoor
The API says that it can return any element, but in practice it returns the first element. I've never seen it return any other element. `list.parallelStream().findAny()` doesn't do a lot better. Some short testing shows that although it doesn't return the first element, it still always returns

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Artur Barashev
On Mon, 25 Aug 2025 13:34:51 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Artur Barashev
On Mon, 25 Aug 2025 13:34:51 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the >> HTTP Client API](https://openjdk.org/jeps/517). >> >> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the >> HTTP Client API](htt

RFR: 8366105: Update link to the external RuleBasedBreakIterator documentation

2025-08-25 Thread Volker Simonis
The JavaDoc of `sun.text.RuleBasedBreakIterator` contains the following link to "Text Boundary Analysis in Java" by Richard Gillam which describes its implementation details: http://www.ibm.com/java/education/boundaries/boundaries.html This link isn't online anymore since at least 2001, but for

Re: Proposal: Add getRandom() default method to java.util.List

2025-08-25 Thread Chen Liang
Hi Daniel, can you explain why `list.stream().findAny()` does not fulfill your needs? This also returns a random element and is also very concise. -Chen Liang From: core-libs-dev on behalf of Daniel Tavares Sent: Saturday, August 23, 2025 2:36 PM To: core-libs-

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F [v4]

2025-08-25 Thread Emanuel Peter
On Mon, 25 Aug 2025 07:10:26 GMT, Galder Zamarreño wrote: >> Galder Zamarreño has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Add more IR node positive assertions >> - Fix source of data for benchmarks >> - Refactor benchmarks to T

Re: RFR: 8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors [v2]

2025-08-25 Thread Jorn Vernee
On Mon, 25 Aug 2025 14:51:43 GMT, Chen Liang wrote: >> A previous cleanup #14642 accidentally omitted the fact that an >> `Array.newInstance` call in `BytecodeDescriptor::parseSig` is intended to >> propagate `IllegalArgumentException` to >> `MethodType::fromMethodDescriptorString`. This bug i

Re: RFR: 8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors [v2]

2025-08-25 Thread Chen Liang
> A previous cleanup #14642 accidentally omitted the fact that an > `Array.newInstance` call in `BytecodeDescriptor::parseSig` is intended to > propagate `IllegalArgumentException` to > `MethodType::fromMethodDescriptorString`. This bug is discovered in a recent > cleanup for `BytecodeDescripto

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Albert Mingkun Yang
On Mon, 25 Aug 2025 11:40:56 GMT, Leo Korinth wrote: > while not multiplying a 10x factor with four resulting in a 40x factor. Why is that undesirable? The base is `(HOLD_TARGET_TIME + 3) * 4` and the timeout-factor changes that linearly. Using `max(..., 4)` here may come as a surprise to

Re: RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v14]

2025-08-25 Thread Daniel Fuchs
> Hi, > > Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP > Client API](https://openjdk.org/jeps/517). > > The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP > Client API](https://bugs.openjdk.org/browse/JDK-8350588) > > This JEP propose

Re: RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved

2025-08-25 Thread Chen Liang
On Mon, 25 Aug 2025 13:19:29 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial change to the > `ModuleDescriptor.packages()` method's specification? > > The change here clarifies that this method returns all packages that belong > to the module and not just those that are ex

RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved

2025-08-25 Thread Jaikiran Pai
Can I please get a review of this trivial change to the `ModuleDescriptor.packages()` method's specification? The change here clarifies that this method returns all packages that belong to the module and not just those that are exported or open. This clarification should help avoid any confusio

Re: RFR: 8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors

2025-08-25 Thread Jorn Vernee
On Sat, 23 Aug 2025 01:46:14 GMT, Chen Liang wrote: > A previous cleanup #14642 accidentally omitted the fact that an > `Array.newInstance` call in `BytecodeDescriptor::parseSig` is intended to > propagate `IllegalArgumentException` to > `MethodType::fromMethodDescriptorString`. This bug is di

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 15:55:38 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/jdk/java/rmi/transport/dgcDeadLock/DGCDeadLock.jav

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Wed, 20 Aug 2025 17:05:59 GMT, Leo Korinth wrote: >> This changes the timeout factor from 4 to 1. Most of the changes add >> timeouts to individual test cases so that I am able to run them with a >> timeout factor of 0.7 (some margin to the checked in factor of one) >> >> In addition to cha

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 16:06:16 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/langtools/jdk/jshell/HangingRemoteAgent.java line

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Fri, 22 Aug 2025 15:44:28 GMT, Albert Mingkun Yang wrote: >> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update testing.md, remove makefile link, fix bad text > > test/hotspot/jtreg/runtime/cds/appcds/LotsOfSyntheticCl

Re: RFR: 8260555: Change the default TIMEOUT_FACTOR from 4 to 1 [v5]

2025-08-25 Thread Leo Korinth
On Sun, 24 Aug 2025 22:51:05 GMT, David Holmes wrote: >> test/hotspot/jtreg/compiler/tiered/Level2RecompilationTest.java line 36: >> >>> 34: * @build jdk.test.whitebox.WhiteBox >>> 35: * @run driver jdk.test.lib.helpers.ClassFileInstaller >>> jdk.test.whitebox.WhiteBox >>> 36: * @run main/ot

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v6]

2025-08-25 Thread Volkan Yazici
On Fri, 22 Aug 2025 14:25:19 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with five >> additional commits since the last revision: >> >> - Renamed to `malformedASCII` >> - Improve exception parametrization >> - Document parametrization on the exception

Re: RFR: 8356439: Rename JavaLangAccess::*NoRepl methods [v7]

2025-08-25 Thread Volkan Yazici
> `NoRepl`-suffixed `String` methods denote methods that do not replace invalid > characters, but throw `CharacterCodingException` on encounter. This behavior > cannot easily be derived from the method footprints, has been a source of > confusion for maintainers, and is not uniformly adopted, e.

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F [v5]

2025-08-25 Thread Galder Zamarreño
> I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F` > nodes. The implementation follows a similar pattern to what is done with > conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have > been updated with the new expectations. > > Also added a JM

Re: RFR: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F [v4]

2025-08-25 Thread Galder Zamarreño
On Fri, 22 Aug 2025 11:40:10 GMT, Galder Zamarreño wrote: >> I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and >> `MoveI2F` nodes. The implementation follows a similar pattern to what is >> done with conversion (`Conv*`) nodes. The tests in >> `TestCompatibleUseDefTypeSize` h