On Sun, 31 Aug 2025 03:24:37 GMT, Chen Liang wrote:
> Hi @davidalayachew, I think what @wenshao tries to do here is to preserve
> behavioral parity before and after the migrations. You are indeed correct
> that listing the constants explicitly would allow us to fail with a compile
> error when
On Thu, 14 Aug 2025 04:49:28 GMT, Shaojin Wen wrote:
> In MethodHandleDesc, the `ofField` method uses enhanced switch, while the
> `of` and `ofMethod` methods use traditional switch. The same class should
> have a unified style.
Hi @davidalayachew, I think what @wenshao tries to do here is to
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
This pull request has now been integrated.
Changes
On Fri, 29 Aug 2025 19:00:23 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revision changes
Ah, fine, thanks.
I'll
Wait, I am confused why you are leaving the default clause in there? Isn't
it to your benefit to replace the default clause and include each value
explicitly?
On Sat, Aug 30, 2025, 12:26 PM Chen Liang wrote:
> On Thu, 14 Aug 2025 04:49:28 GMT, Shaojin Wen wrote:
>
> > In MethodHandleDesc, the `
On Thu, 14 Aug 2025 04:49:28 GMT, Shaojin Wen wrote:
> In MethodHandleDesc, the `ofField` method uses enhanced switch, while the
> `of` and `ofMethod` methods use traditional switch. The same class should
> have a unified style.
Sure, let's go ahead with this.
-
Marked as reviewe
On Fri, 29 Aug 2025 20:44:00 GMT, Justin Lu wrote:
>> This PR is a cleanup change which replaces anchor element references of the
>> Locale `def_locale_extension` section with the Javadoc link tag. This is a
>> doc only change and is a result of the discussion in the PR of
>> https://github.co
On Sat, 30 Aug 2025 05:27:47 GMT, Christian Stein wrote:
> > Is there an ETA for integration?
>
> On September, 1st.
I had a brief discussion with Christian about maybe holding off until the
TIMEOUT_FACTOR changes (pull/26749) is integrated.
-
PR Comment: https://git.openjdk.org/
On Fri, 29 Aug 2025 14:50:29 GMT, Per Minborg wrote:
>> src/java.base/macosx/classes/sun/nio/ch/KQueue.java line 91:
>>
>>> 89: */
>>> 90: static MemorySegment getEvent(MemorySegment memoryHandle, int i) {
>>> 91: return kevent.asSlice(memoryHandle, i);
>>
>> Previous work elim
On Fri, 1 Aug 2025 18:03:52 GMT, Henry Jen wrote:
>> Create a jar directly from the memory instead of real file, this should
>> reduce the I/O overhead which likely the reason for the time out.
>> The issue is not reproducible locally, and fails intermittently, so we
>> simply trying to reduce
On Wed, 13 Aug 2025 12:32:58 GMT, David Beaumont wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Feedback tweaks.
>
> src/java.base/share/classes/jdk/internal/jrtfs/SystemImage.java line 81:
>
>> 79: }
>> 80
On Fri, 29 Aug 2025 08:32:58 GMT, David Beaumont wrote:
>> src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 95:
>>
>>> 93: }
>>> 94:
>>> 95: @Override
>>
>> Discovered this method was missing during testing. I *think* this logic is
>> what's needed here,
On Fri, 29 Aug 2025 08:49:27 GMT, David Beaumont wrote:
>> This PR addresses several issues found while adding unit tests for
>> ExplodedImage.
>> I have added review comments for changes (some of which are a little
>> preferential, but bring the code into line with things like ImageReader in
On Fri, 29 Aug 2025 13:48:52 GMT, Volkan Yazici wrote:
>> `NoRepl`-suffixed `String` methods denote methods that do not replace
>> invalid characters, but throw `CharacterCodingException` on encounter. This
>> behavior cannot easily be derived from the method footprints, has been a
>> source o
On Fri, 29 Aug 2025 13:48:52 GMT, Volkan Yazici wrote:
>> `NoRepl`-suffixed `String` methods denote methods that do not replace
>> invalid characters, but throw `CharacterCodingException` on encounter. This
>> behavior cannot easily be derived from the method footprints, has been a
>> source o
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
Looks OK to me.
-
Marked as reviewed
On Thu, 28 Aug 2025 17:04:52 GMT, Raffaello Giulietti
wrote:
>> @rgiulietti I haven't started yet to implement `BigDecimal.nthRoot()` by now.
>
> @fabioromano1 I'm asking because, as discussed in the past, your efforts on
> this PR would make less sense to integrate in the platform without the
On Fri, 29 Aug 2025 16:27:35 GMT, Brian Burkhalter wrote:
>> Attempt to improve the verbiage of the `java.io.File` specification to make
>> it clearer whether a given method operates only on an abstract pathname or
>> on the actual file system entry it denotes.
>
> Brian Burkhalter has updated
18 matches
Mail list logo
