> Summary: Add two new methods to ImageReader to make SystemModuleReader more
> performant.
>
> Analysis of benchmarks shows that when the vast majority of resources
> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
> SystemModuleReader do NOT exist, performance is degraded com
On Thu, 4 Sep 2025 22:03:51 GMT, Justin Lu wrote:
> This PR cleans up the existing DecimalFormatSymbols, DecimalFormat, and
> NumberFormat serialization tests.
>
> As mentioned in https://github.com/openjdk/jdk/pull/27008 these tests can be
> re-visited.
>
> These older tests are either not r
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote:
> Several java classes in java.base is generated from templates using SPP, the
> "Stream Preprocessor". Unfortunately much of this code is very old and has
> survived unchanged since pre-JDK 7. It does not follow modern makefile
> stan
On Wed, 10 Sep 2025 15:18:25 GMT, Daniel Fuchs wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits
On Tue, 9 Sep 2025 16:46:13 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 22 commits:
>>
>> - @ashu-mehra review comments
>> - Merge branch 'master' into 8350550-preload-aot-classes-during
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>
> As noted in the issue, the current code in
> `com.sun.jndi.ldap.Connection.readReply()` is susceptible to throwing a
> `ServiceUnavailableException` even wh
On Mon, 8 Sep 2025 18:06:54 GMT, Chen Liang wrote:
> This patch removed the `VARHANDLES_GENSRC_DIR` variable used by
> VarHandleGuards generation. I think it can be addressed by a hot fix.
I think the change needs to backed out and the differences with line numbers
checked to see what impact i
On Tue, 9 Sep 2025 15:31:40 GMT, David Beaumont wrote:
>> The writer field of the handler needs to be re-checked for null inside the
>> locked region before use.
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> License fi
On Thu, 11 Sep 2025 09:27:06 GMT, Alan Bateman wrote:
>> This PR
>> * Moves sqrt() and nthRoot() tests to a new subset.
>> * Removes a leftover `@run` tag without a timeout.
>> * Increases the explicit timeout from 400 to 480.
>> * Sorts the jtreg tags according to standard conventions.
>
> test/
On Wed, 10 Sep 2025 21:03:32 GMT, Roger Riggs wrote:
> JNI exception pending in os_getCmdlineAndUserInfo of
> ProcessHandleImpl_macosx.c:306
> Minor cleanup of a missing check for exception pending.
Looks all right.
-
Marked as reviewed by bpb (Reviewer).
PR Review: https://git.o
On Fri, 5 Sep 2025 14:18:19 GMT, Johannes Graham wrote:
> When formatting doubles or BigDecimals, DigitList first formats them as a
> string and then parses the resultant string to extract the mantissa and the
> exponent. This can be done more directly. This allows removing some parsing
> code
(This deserves a reply, but I've been distracted by a bunch of other stuff recently.
I should be able to continue this conversation in a few days. Sorry for the delay.)
s'marks
> Summary: Add two new methods to ImageReader to make SystemModuleReader more
> performant.
>
> Analysis of benchmarks shows that when the vast majority of resources
> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
> SystemModuleReader do NOT exist, performance is degraded com
Hello @core-libs-dev ,
I have frequently run into the following pothole.
Imagine the following directory setup.
root/folderA/fileX.java
root/folderB/fileY.js
root/folderC/fileZ.html
In this directory, let's say that we run the following code.
Files
.walk(Path.of("root"))
.filter(path -> path.e
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8357708?
>
> As noted in the issue, the current code in
> `com.sun.jndi.ldap.Connection.readReply()` is susceptible to throwing a
> `ServiceUnavailableException` even wh
On Thu, 11 Sep 2025 08:55:02 GMT, Raffaello Giulietti
wrote:
> This PR
> * Moves sqrt() and nthRoot() tests to a new subset.
> * Removes a leftover `@run` tag without a timeout.
> * Increases the explicit timeout from 400 to 480.
> * Sorts the jtreg tags according to standard conventions.
The r
Small doc enhancement to use the term "representation equivalence" in a few
more locations.
-
Commit messages:
- JDK-8367382: Expand use of representation equivalence terminology
Changes: https://git.openjdk.org/jdk/pull/27232/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&p
On Fri, 5 Sep 2025 14:37:01 GMT, Johannes Graham wrote:
>> When formatting doubles or BigDecimals, DigitList first formats them as a
>> string and then parses the resultant string to extract the mantissa and the
>> exponent. This can be done more directly. This allows removing some parsing
>>
On Thu, 11 Sep 2025 10:43:55 GMT, David Beaumont wrote:
>> Summary: Add two new methods to ImageReader to make SystemModuleReader more
>> performant.
>>
>> Analysis of benchmarks shows that when the vast majority of resources
>> (~11,000 in the Perfstartup-SwingSet-G1 benchmark) tested for in
On Thu, 11 Sep 2025 00:39:43 GMT, Jiangli Zhou wrote:
>> @AlanBateman @jianglizhou Now that Erik has approved the build
>> functionality, I'd appreciate if anyone of you could approve as well, then I
>> can finally integrate this.
>
>> @magicus I'll take a look today.
>
> Hi @magicus I looked
On Tue, 9 Sep 2025 19:19:22 GMT, David Beaumont wrote:
>> The writer field of the handler needs to be re-checked for null inside the
>> locked region before use.
>
> David Beaumont has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes
On Thu, 11 Sep 2025 00:39:43 GMT, Jiangli Zhou wrote:
>> @AlanBateman @jianglizhou Now that Erik has approved the build
>> functionality, I'd appreciate if anyone of you could approve as well, then I
>> can finally integrate this.
>
>> @magicus I'll take a look today.
>
> Hi @magicus I looked
On Thu, 11 Sep 2025 19:10:57 GMT, Eirik Bjørsnøs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo found in code review.
>
> src/java.base/share/classes/java/lang/Record.java line 132:
>
>> 130: * Note th
> Small doc enhancement to use the term "representation equivalence" in a few
> more locations.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo found in code review.
-
Changes:
- all: https://git.openjdk.org/jdk
On Thu, 11 Sep 2025 22:36:28 GMT, Justin Lu wrote:
>> Please review this PR which is a documentation change to make apparent the
>> recommended approach for using Collator & RuleBasedCollator in a multi
>> threaded environment via an implNote. The original issue and CSR have
>> additional cont
On Wed, 3 Sep 2025 18:40:26 GMT, Roger Riggs wrote:
>> Guanqiang Han has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Class.java
>>
>> change overflow check
>
>> /reviewers 2 reviewer
>>
>> I recommend putting this PR on hold
On Thu, 11 Sep 2025 21:34:24 GMT, Justin Lu wrote:
>> Please review this PR which is a documentation change to make apparent the
>> recommended approach for using Collator & RuleBasedCollator in a multi
>> threaded environment via an implNote. The original issue and CSR have
>> additional cont
> Please review this PR which is a documentation change to make apparent the
> recommended approach for using Collator & RuleBasedCollator in a multi
> threaded environment via an implNote. The original issue and CSR have
> additional context.
Justin Lu has updated the pull request incrementall
> Please review this PR which is a documentation change to make apparent the
> recommended approach for using Collator & RuleBasedCollator in a multi
> threaded environment via an implNote. The original issue and CSR have
> additional context.
Justin Lu has updated the pull request incrementall
On Thu, 11 Sep 2025 20:14:56 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Doc updates reflecting Naoto's comments
>
> src/java.base/share/classes/java/text/Collator.java line 117:
>
>> 115: *
>> 1
On Thu, 11 Sep 2025 18:58:46 GMT, Justin Lu wrote:
> Please review this PR which is a documentation change to make apparent the
> recommended approach for using Collator & RuleBasedCollator in a multi
> threaded environment via an implNote. The original issue and CSR have
> additional context.
This PR
* Moves sqrt() and nthRoot() tests to a new subset.
* Removes a leftover `@run` tag without a timeout.
* Increases the explicit timeout from 400 to 480.
* Sorts the jtreg tags according to standard conventions.
-
Commit messages:
- 8367365: java/math/BigInteger/BigIntegerTest
On Thu, 11 Sep 2025 08:55:02 GMT, Raffaello Giulietti
wrote:
> This PR
> * Moves sqrt() and nthRoot() tests to a new subset.
> * Removes a leftover `@run` tag without a timeout.
> * Increases the explicit timeout from 400 to 480.
> * Sorts the jtreg tags according to standard conventions.
test/
On Thu, 11 Sep 2025 11:59:26 GMT, Claes Redestad wrote:
>> I think replacing `startsWith(String)` with `indexOf(char)` is dubious,
>> since the latter is O(n) and the former O(1)
>>
>> If you _really_ need to squeeze out everything on startup then `(x.length()
>> > 0 && x.charAt(0) == '/')` i
On Tue, 9 Sep 2025 01:05:37 GMT, Guanqiang Han wrote:
>> Validate class name length immediately after GetStringUTFLength() in
>> Class.forName0. This prevents potential issues caused by overly long class
>> names before they reach later code that would reject them, throwing
>> ClassNotFoundExc
On Tue, 9 Sep 2025 01:05:37 GMT, Guanqiang Han wrote:
>> Validate class name length immediately after GetStringUTFLength() in
>> Class.forName0. This prevents potential issues caused by overly long class
>> names before they reach later code that would reject them, throwing
>> ClassNotFoundExc
On Thu, 11 Sep 2025 08:55:02 GMT, Raffaello Giulietti
wrote:
> This PR
> * Moves sqrt() and nthRoot() tests to a new subset.
> * Removes a leftover `@run` tag without a timeout.
> * Increases the explicit timeout from 400 to 480.
> * Sorts the jtreg tags according to standard conventions.
This
On Wed, 10 Sep 2025 23:47:47 GMT, Johannes Graham wrote:
>> When formatting doubles or BigDecimals, DigitList first formats them as a
>> string and then parses the resultant string to extract the mantissa and the
>> exponent. This can be done more directly. This allows removing some parsing
>>
On Wed, 10 Sep 2025 19:57:56 GMT, Kieran Farrell wrote:
>> test/jdk/java/util/UUID/UUIDTest.java line 52:
>>
>>> 50: unixEpochTimeMillisTest();
>>> 51: unixEpochTimeMillisTest_Multi();
>>> 52: unixEpochTimeMillis_userInputTest();
>>
>> Also rename the tests to use the `e
On Wed, 10 Sep 2025 21:03:32 GMT, Roger Riggs wrote:
> JNI exception pending in os_getCmdlineAndUserInfo of
> ProcessHandleImpl_macosx.c:306
> Minor cleanup of a missing check for exception pending.
This pull request has now been integrated.
Changeset: 56f2f7a3
Author:Roger Riggs
URL:
On Thu, 11 Sep 2025 12:56:33 GMT, Jaikiran Pai wrote:
>> Yes - the observed timeout was 120s - so it must have been the first `@run`.
>> That first `@run` was added by
>> [JDK-8078672](https://bugs.openjdk.org/browse/JDK-8078672) - I'm not sure
>> why - that might have been a left over from d
On Sun, 7 Sep 2025 18:28:54 GMT, Doug Lea wrote:
>> This set of updates reduces contention-based performance loss under heavy
>> over-subscription, while also improving perfomance more generally.
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last
> In the static JDK image, a single humongous java executable is generated, and
> no other launcher, such as javac. This makes it impossible to run our jtreg
> tests, which assume these are present.
>
> The solution is fortunately simply: we just need to add a bunch of trivial
> launchers, whic
On Thu, 11 Sep 2025 09:56:30 GMT, David Beaumont wrote:
>> If something shouldn't happen, I would prefer an explicit exception or at
>> least an assert.
>
> Not 100% sure it's impossible to tickle this with current callers (e.g.
> "jrt:/module//path" leaving the trailing path starting with a '/
On Thu, 11 Sep 2025 11:56:30 GMT, Claes Redestad wrote:
>> I had thought of these micro optimizations, but I thought we preferred
>> clarity unless performance was proven to be an issue. I see
>> contains("") in other code - should we be changing that?
>
> I think replacing `starts
On Wed, 10 Sep 2025 21:03:32 GMT, Roger Riggs wrote:
> JNI exception pending in os_getCmdlineAndUserInfo of
> ProcessHandleImpl_macosx.c:306
> Minor cleanup of a missing check for exception pending.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/
On Tue, 2 Sep 2025 09:43:23 GMT, Amit Kumar wrote:
>> Originally Reported in OpenJ9, fix by @AditiS11 present here:
>> https://github.com/ibmruntimes/openj9-openjdk-jdk25/pull/32
>>
>> These test failure were reported in OpenJ9 (x86), I can't reproduce on my
>> system (s390x):
>>
>> java/for
> In the static JDK image, a single humongous java executable is generated, and
> no other launcher, such as javac. This makes it impossible to run our jtreg
> tests, which assume these are present.
>
> The solution is fortunately simply: we just need to add a bunch of trivial
> launchers, whic
On Thu, 11 Sep 2025 01:19:17 GMT, Roger Riggs wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Found additional place where new API can be used.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java
On Thu, 11 Sep 2025 03:12:33 GMT, Chen Liang wrote:
>> While you are at it, both findNode and BuildModulesNode should have comments
>> indicating that the node can be found in one of two places.
>
> If something shouldn't happen, I would prefer an explicit exception or at
> least an assert.
No
On Thu, 11 Sep 2025 09:27:51 GMT, Magnus Ihse Bursie wrote:
>> src/java.base/windows/native/launcher/relauncher.c line 1:
>>
>>> 1: /*
>>
>> How did you test the relauncher for Windows? Can you remind me if static JDK
>> is support for Windows?
>
> Yes, static JDK is supported on all supported
On Wed, 10 Sep 2025 23:36:08 GMT, Jiangli Zhou wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update based on review
>
> src/java.base/share/native/launcher/main.c line 44:
>
>> 42:
>> 43: // This is used
On Wed, 10 Sep 2025 23:29:03 GMT, Jiangli Zhou wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update based on review
>
> src/java.base/share/native/launcher/main.c line 41:
>
>> 39:
>> 40: // This is repor
On Wed, 10 Sep 2025 15:28:39 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
54 matches
Mail list logo
