On Fri, 26 Jul 2024 18:03:18 GMT, Roger Riggs wrote:
> > Could you please review [these](https://github.com/openjdk/jdk/pull/11986)
> > proposed changes for instantiation of `Instant` values with already
> > normalized nanos?
>
> @plokhotnyuk Your contribution cannot be acted upon until the
On Fri, 26 Jul 2024 15:44:59 GMT, Shaojin Wen wrote:
>> By removing the redundant code logic in
>> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be
>> reduced and the performance can be improved.
>
> Shaojin Wen has updated the pull request incrementally with one
On Fri, 3 Nov 2023 23:34:49 GMT, Claes Redestad wrote:
> > @cl4es Could you please test
> >
On Fri, 3 Nov 2023 12:03:24 GMT, Claes Redestad wrote:
> https://github.com/cassioneri/eaf suggest this code for leap year calculation:
>
> public static boolean isLeap(long year) {
> int d = year % 100 != 0 ? 4 : 16;
> return (year & (d - 1)) == 0;
> }
>
> .. with a
On Wed, 13 Sep 2023 01:24:05 GMT, Shaojin Wen wrote:
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
On Fri, 22 Sep 2023 09:22:04 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request
On Thu, 21 Sep 2023 12:51:56 GMT, Raffaello Giulietti
wrote:
> By correctly sizing an intermediate `byte[]` and making use of the internal
> `newStringNoRepl()` method, one allocation per conversion can be avoided when
> the runtime uses compact strings.
I bet that `decNumberOfTrailingZeros`
On Thu, 31 Aug 2023 02:36:09 GMT, 温绍锦 wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> assert bounds check
>
> @cl4es can you help me to review this PR?
@wenshao How about of approach used in James Anhalt's algorithm:
On Thu, 16 Feb 2023 16:51:43 GMT, Raffaello Giulietti
wrote:
> After making sure that `intVal` is even, and before attempting a division by
> a power of 10, it might help to check if 5 divides `intVal` in the first
> place. If it doesn't, there no point in performing the division.
>
> It can
On Tue, 14 Feb 2023 14:07:22 GMT, Raffaello Giulietti
wrote:
>> Sorry, I overlooked those checks two times :)
>>
>> How about adding a moderate path like
>>
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Sorry, I failed to recognize those checks two times :)
How about
On Tue, 31 Jan 2023 13:39:46 GMT, Raffaello Giulietti
wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> This PR is waiting for a review
@rgiulietti Thanks for
On Mon, 30 Jan 2023 08:41:25 GMT, Per Minborg wrote:
> > java.time.ZoneOffset
>
> Maybe I am blind but can you provide a direct reference to an exising JDK
> method in `java.time` where we can apply similar optimizations?
No problem! We can start from `java.time.ZoneOffset` and its `parse`
On Wed, 4 Jan 2023 12:40:43 GMT, Per Minborg wrote:
> > @minborg Amazing piece!
> > Will `java.lang.invoke.VarHandle` instances be shared in JDK to reuse in
> > other places?
> > The
> >
On Wed, 4 Jan 2023 10:49:18 GMT, Per Minborg wrote:
>> Do we need this test at all, because this code is tested to extense through
>> RandomAccessFile? We had no test before, so why add a new one here?
>>
>> Otherwise: PR looks good.
>
>> Do we need this test at all, because this code is
15 matches
Mail list logo
