RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Chad Rakoczy
[JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug with Formatter.format taking a long time when there is a lot of padding. This test runs Formatter.format with very large padding. Test fails before [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) and pass

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Chad Rakoczy
On Tue, 27 Feb 2024 19:13:10 GMT, Alan Bateman wrote: >> [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug >> with Formatter.format taking a long time when there is a lot of padding. >> This test runs Formatter.format with very large padding. Test fails before >> [JDK

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Chad Rakoczy
On Tue, 27 Feb 2024 19:20:36 GMT, Raffaello Giulietti wrote: > I guess the title should read "8326718: Test java/util/Formatter/Padding.java > does not timeout on large inputs _after_ JDK-8299677" The test should timeout/fail before the fix in JDK-8299677 and pass after - PR Comm

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Chad Rakoczy
On Tue, 27 Feb 2024 17:24:03 GMT, Chad Rakoczy wrote: > [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug > with Formatter.format taking a long time when there is a lot of padding. This > test runs Formatter.format with very large padding. Test fails befor

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677

2024-02-27 Thread Chad Rakoczy
On Tue, 27 Feb 2024 19:46:27 GMT, Chad Rakoczy wrote: >> [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug >> with Formatter.format taking a long time when there is a lot of padding. >> This test runs Formatter.format with very large padding.

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677 [v2]

2024-02-27 Thread Chad Rakoczy
On Tue, 27 Feb 2024 20:01:20 GMT, Joe Darcy wrote: >> What is the issue with this? Is there a different way to set a timeout? The >> test tests that format does not take a long time to run so I would like to >> have a timeout > >> What is the issue with this? Is there a different way to set a t

Re: RFR: 8326718: Test java/util/Formatter/Padding.java does not timeout on large inputs before JDK-8299677 [v2]

2024-02-27 Thread Chad Rakoczy
wse/JDK-8299677)) so it should > be consistent. Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision: Test updates - Changes: - all: https://git.openjdk.org/jdk/pull/18033/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677 [v3]

2024-03-05 Thread Chad Rakoczy
wse/JDK-8299677)) so it should > be consistent. Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision: Add underscores to large number - Changes: - all: https://git.openjdk.org/jdk/pull/18033/files - new: https://git

Integrated: 8326718: Test java/util/Formatter/Padding.java should timeout on large inputs before fix in JDK-8299677

2024-03-06 Thread Chad Rakoczy
On Tue, 27 Feb 2024 17:24:03 GMT, Chad Rakoczy wrote: > [JDK-8299677](https://bugs.openjdk.java.net/browse/JDK-8299677) fixes a bug > with Formatter.format taking a long time when there is a lot of padding. This > test runs Formatter.format with very large padding. Test fails befor

RFR: 8325621: Improve jspawnhelper version checks

2024-03-11 Thread Chad Rakoczy
Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621) Updates jspawnhelper to check that JDK version and jspawnhelper version are the same. Updates test to include check for version. Also tested manually by replacing jspawnhelper with incorrect version to confirm that check works.

Re: RFR: 8325621: Improve jspawnhelper version checks [v2]

2024-03-11 Thread Chad Rakoczy
firm that check works. Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision: Code cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/18204/files - new: https://git.openjdk.org/jdk/pull/18204/files/cf3c20fb..7b

Re: RFR: 8325621: Improve jspawnhelper version checks [v2]

2024-03-12 Thread Chad Rakoczy
On Mon, 11 Mar 2024 19:12:33 GMT, Chad Rakoczy wrote: >> Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621) >> >> Updates jspawnhelper to check that JDK version and jspawnhelper version are >> the same. Updates test to include check for version.

Re: RFR: 8325621: Improve jspawnhelper version checks [v3]

2024-03-12 Thread Chad Rakoczy
firm that check works. Chad Rakoczy has updated the pull request incrementally with two additional commits since the last revision: - Print to stdout instead of stderr - Compare version using VERSION_STRING - Changes: - all: https://git.openjdk.org/jdk/pull/18204/files

Re: RFR: 8325621: Improve jspawnhelper version checks [v4]

2024-03-13 Thread Chad Rakoczy
firm that check works. Chad Rakoczy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'master' into JDK-8325621-2 - Update style and improve error messages - Print to stdout instead of stderr

Integrated: 8325621: Improve jspawnhelper version checks

2024-03-14 Thread Chad Rakoczy
On Mon, 11 Mar 2024 17:46:14 GMT, Chad Rakoczy wrote: > Fix for [8325621](https://bugs.openjdk.org/browse/JDK-8325621) > > Updates jspawnhelper to check that JDK version and jspawnhelper version are > the same. Updates test to include check for version. Also tested manually by