Re: RFR: 8254693: Add Panama feature to pass heap segments to native code [v7]

2023-10-19 Thread Feilong Jiang
On Wed, 18 Oct 2023 17:38:24 GMT, Jorn Vernee wrote: >> Add the ability to pass heap segments to native code. This requires using >> `Linker.Option.critical(true)` as a linker option. It has the same >> limitations as normal critical calls, namely: upcalls into Java are not >> allowed, and

Re: RFR: 8313023: Return value corrupted when using CCS + isTrivial (mainline)

2023-07-27 Thread Feilong Jiang
On Tue, 25 Jul 2023 21:28:23 GMT, Jorn Vernee wrote: > @TheRealMDoerr @feilongjiang Just a heads up: this patch touches the PPC and > RISC-V ports as well, which I'm not able to test. I've just eye-balled the > needed changes. I don't think there will be an issue since the code structure > is

Re: RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v5]

2023-03-22 Thread Feilong Jiang
On Tue, 21 Mar 2023 13:35:25 GMT, Per Minborg wrote: >> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add example for Option::captureStateLayout > > A review of all the copyright years shall be made in this PR. Hi

Integrated: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

2023-03-10 Thread Feilong Jiang
On Thu, 9 Mar 2023 14:39:55 GMT, Feilong Jiang wrote: > [JDK-8303604](https://bugs.openjdk.org/browse/JDK-8303604) fixes an issue > with passing structs whose size is not a power of two on SysV and AArch64 > platforms. The same issue happens on RISC-V. > > Modifications

Re: RFR: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

2023-03-10 Thread Feilong Jiang
On Thu, 9 Mar 2023 15:07:55 GMT, Jorn Vernee wrote: >> [JDK-8303604](https://bugs.openjdk.org/browse/JDK-8303604) fixes an issue >> with passing structs whose size is not a power of two on SysV and AArch64 >> platforms. The same issue happens on RISC-V. >> >> Modifications are unnecessary for

Re: RFR: 8303684: Lift upcall sharing mechanism to AbstractLinker (mainline)

2023-03-10 Thread Feilong Jiang
On Mon, 6 Mar 2023 18:40:47 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/791 which lifts the > sharing mechanism for upcall stubs to AbstractLinker. > > This also speeds up upcall stub linking: I'll submit a test on RISC-V board to see the results. It may

RFR: 8303863: RISC-V: TestArrayStructs.java fails after JDK-8303604

2023-03-09 Thread Feilong Jiang
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. --

Re: RFR: 8303022: "assert(allocates2(pc)) failed: not in CodeBuffer memory" When linking downcall handle [v2]

2023-03-08 Thread Feilong Jiang
On Wed, 8 Mar 2023 20:54:17 GMT, Jorn Vernee wrote: > @feilongjiang Could you comment on this? If you could figure out the needed > sizes for RISCV I could add the needed changes to this patch. Otherwise I > could file a followup issue if that seems more convenient. TIA Yes, I will take a

Integrated: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)

2023-01-18 Thread Feilong Jiang
On Sat, 5 Nov 2022 03:48:01 GMT, Feilong Jiang wrote: > Add experimental Foreign Function & Memory API support for RISC-V. > > For details of the FFM API RISC-V port please refer to [JBS > issue](https://bugs.openjdk.org/browse/JDK-8293841) > > Testing: > > -

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v5]

2023-01-18 Thread Feilong Jiang
On Sat, 14 Jan 2023 10:20:22 GMT, Jorn Vernee wrote: >> Feilong Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix callArranger > > Marked as reviewed by jvernee (Reviewer). @JornVernee @RealFYang @

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v8]

2023-01-18 Thread Feilong Jiang
-riscv64 > - [x] jdk_foreign with release/fastdebug build on linux-x64 > - [x] jdk_foreign with release/fastdebug build on linux-aarch64 Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brough

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v7]

2023-01-17 Thread Feilong Jiang
On Mon, 16 Jan 2023 11:48:21 GMT, Aleksey Shipilev wrote: >> Feilong Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> more code style adjustment > > src/hotspot/cpu/riscv/codeBuffer_riscv.cpp line 3:

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v5]

2023-01-16 Thread Feilong Jiang
On Fri, 13 Jan 2023 11:30:35 GMT, Jorn Vernee wrote: > Excellent. No Comments. > > I am running some sanity testing on our CI, and will approve when it comes > back green. @JornVernee, thanks for the reviewing and testing! - PR: https://git.openjdk.org/jdk/pull/11004

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v7]

2023-01-15 Thread Feilong Jiang
-riscv64 > - [x] jdk_foreign with release/fastdebug build on linux-x64 > - [x] jdk_foreign with release/fastdebug build on linux-aarch64 Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: more code style adjustment - Changes

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v5]

2023-01-15 Thread Feilong Jiang
On Sun, 15 Jan 2023 09:09:07 GMT, Fei Yang wrote: >> Feilong Jiang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix callArranger > > test/jdk/java/foreign/callarranger/TestRISCV64CallArranger

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v6]

2023-01-15 Thread Feilong Jiang
-riscv64 > - [x] jdk_foreign with release/fastdebug build on linux-x64 > - [x] jdk_foreign with release/fastdebug build on linux-aarch64 Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brough

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v5]

2023-01-10 Thread Feilong Jiang
x] run TestMatrix.java manually with release/fastdebug build Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: fix callArranger - Changes: - all: https://git.openjdk.org/jdk/pull/11004/files - new: https://git.openjdk.or

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v4]

2023-01-10 Thread Feilong Jiang
x] run TestMatrix.java manually with release/fastdebug build Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: fix callArranger - Changes: - all: https://git.openjdk.org/jdk/pull/11004/files - new: https://git.openjdk.or

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v3]

2023-01-09 Thread Feilong Jiang
x] run TestMatrix.java manually with release/fastdebug build Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision: fix build - Changes: - all: https://git.openjdk.org/jdk/pull/11004/files - new: https://git.openjdk.org/jdk/pull

Re: RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview) [v2]

2023-01-09 Thread Feilong Jiang
x] run TestMatrix.java manually with release/fastdebug build Feilong Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the

RFR: 8293841: RISC-V: Implementation of Foreign Function & Memory API (Preview)

2023-01-04 Thread Feilong Jiang
Add experimental Foreign Function & Memory API support for RISC-V. Details of FFM API RISC-V port please refer to [JBS issue](https://bugs.openjdk.org/browse/JDK-8293841) - Commit messages: - sync with JDK-8296477 - sync with JDK-8295044 - JDK-8293841: RISC-V: Implementation of