On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote:
> The fix is trivial. We should include the standard C header `stdlib.h` [1],
> rather than non-standard one `malloc.h`.
>
> [1] https://en.cppreference.com/w/c/memory/malloc
This pull request has now been integrated.
Changes
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote:
> The fix is trivial. We should include the standard C header `stdlib.h` [1],
> rather than non-standard one `malloc.h`.
>
> [1] https://en.cppreference.com/w/c/memory/malloc
Thanks for your reviews.
-
PR Co
The fix is trivial. We should include the standard C header `stdlib.h` [1],
rather than non-standard one `malloc.h`.
[1] https://en.cppreference.com/w/c/memory/malloc
-
Commit messages:
- 8320131: Zero build fails on macOS after JDK-8254693
Changes:
On Thu, 22 Sep 2022 07:02:16 GMT, Hao Sun wrote:
> This warning seems to be a false positive, because 1) array "fq" with
> elements from index 0 to "jz" has already been initialized as "fw" at line
> 290 [1], and 2) variable "jz" should
On Mon, 26 Sep 2022 01:39:41 GMT, Hao Sun wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz"
On Fri, 23 Sep 2022 12:47:24 GMT, Magnus Ihse Bursie wrote:
>> Thanks for your review.
>>
>> Your mentioned solution should work and we can also enable the pragma only
>> for aarch64 + gcc>=12 condition.
>> I considered such a solution when preparing this patch.
>>
>> But I personally prefer
ithub.com/openjdk/jdk/blob/master/src/java.base/share/native/libfdlibm/k_rem_pio2.c#L290
>
> [2]
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/native/libfdlibm/k_rem_pio2.c#L99
>
> [3] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106992
Hao Sun has updated the pull r
On Thu, 22 Sep 2022 09:35:47 GMT, Andrew Haley wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz" should be non-negative from the comment at
>> line 99
This warning seems to be a false positive, because 1) array "fq" with elements
from index 0 to "jz" has already been initialized as "fw" at line 290 [1], and
2) variable "jz" should be non-negative from the comment at line 99 [2].
Note-1: GCC warning option -Wmaybe-uninitialized is not a new
