On Thu, 8 Aug 2024 02:04:17 GMT, Joe Darcy wrote:
> Easy fix of an accidentally repeated "Java".
LGTM
-
Marked as reviewed by jiefu (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20505#pullrequestreview-2226726552
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote:
> Hi all,
>
> java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
> machines.
> I'm not an expert in this area and just guess it can be fixed like this.
> Please review it.
>
> Thanks.
>
On Mon, 1 Apr 2024 16:55:45 GMT, Naoto Sato wrote:
>> Hi all,
>>
>> java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
>> machines.
>> I'm not an expert in this area and just guess it can be fixed like this.
>> Please review it.
>>
>> Thanks.
>> Best regards,
>> Jie
>
>
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote:
> Hi all,
>
> java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
> machines.
> I'm not an expert in this area and just guess it can be fixed like this.
> Please review it.
>
> Thanks.
> Be
On Sat, 30 Mar 2024 22:00:26 GMT, Justin Lu wrote:
> This is indeed the correct solution to ensure that the DecimalFormat,
> (specifically, the underlying DecimalFormatSymbols) has the same locale as
> the MessageFormat subformat.
Thanks @justin-curtis-lu for the review.
-
PR Com
On Tue, 26 Mar 2024 23:32:34 GMT, Justin Lu wrote:
>> Please review this PR which updates two MessageFormat sub format related
>> tests to be guaranteed to run under the `en_US` locale.
>>
>> There exists locale that do not provide distinct instances for separate
>> styles. For example, the `e
Hi all,
java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
machines.
I'm not an expert in this area and just guess it can be fixed like this.
Please review it.
Thanks.
Best regards,
Jie
-
Commit messages:
- 8329354: java/text/Format/MessageFormat/CompactSub
On Wed, 24 Jan 2024 15:20:37 GMT, Jie Fu wrote:
> This patch tries to fix the invalid test group definition of lib-test.
> Please review.
> Thanks.
This pull request has now been integrated.
Changeset: 2d5cb972
Author: Jie Fu
URL:
https://git.openjdk.org/j
On Wed, 24 Jan 2024 17:22:42 GMT, Aleksey Shipilev wrote:
>> This patch tries to fix the invalid test group definition of lib-test.
>> Please review.
>> Thanks.
>
> Ooof. I wonder how that happened. This would not show up before we try to run
> the actual libtest tests. What is extra wild is tha
This patch tries to fix the invalid test group definition of lib-test.
Please review.
Thanks.
-
Commit messages:
- 8324647: Invalid test group of lib-test after JDK-8323515
Changes: https://git.openjdk.org/jdk/pull/17558/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17558&
On Tue, 23 Jan 2024 17:03:13 GMT, Aleksey Shipilev wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Catch-all -> All tests
>
> Thank you all!
Hi @shipilev , plese see https://github.com/openjdk/jdk/pull/17558 .
On Sat, 9 Dec 2023 23:19:52 GMT, John Jiang wrote:
> It looks the `else-if` and `else` clauses in method
> `ArraysSupport::hugeLength` could be simplified by `Math::max`.
The JBS should be an enhancement, not a bug, right?
-
PR Comment: https://git.openjdk.org/jdk/pull/17043#issue
On Thu, 2 Nov 2023 02:02:18 GMT, Joe Darcy wrote:
>> Due to their longer-than-typical running time and because the vector API is
>> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
Okay.
If 2min testing time is not acceptable in tier1 for vector api, I agree with
@A
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
May I ask how long it will take to run jdk_vector_sanity?
My testing in JDK-8295970 wa
On Thu, 27 Jul 2023 06:46:46 GMT, John Jiang wrote:
> if (i < savingsInstantTransitions.length) {
> // javazic writes the last GMT offset into index 0!
> if (i < savingsInstantTransitions.length) {
> offsets[0] = standardOffsets[standardOffsets.length - 1] * 1000;
> nOffse
On Fri, 30 Jun 2023 21:12:11 GMT, 温绍锦 wrote:
> can you create a new issue and i continue improving?
Filed: https://bugs.openjdk.org/browse/JDK-8311207
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14578#discussion_r1248348302
On Thu, 29 Jun 2023 13:45:20 GMT, Alan Bateman wrote:
> @DamonFool In the future, please wait at least 24 hours before sponsoring
> changes like this. There have been 33 revisions of this change, many of the
> people that have commented, potential reviewers are in many time zones and
> need to
On Thu, 29 Jun 2023 13:13:33 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Tue, 30 May 2023 13:31:16 GMT, Jie Fu wrote:
> Just remove the `static` to fix the build failure.
> Thanks.
This pull request has now been integrated.
Changeset: 15e02853
Author: Jie Fu
URL:
https://git.openjdk.org/jdk/commit/15e028530ad6408693e9f21fb94daa705b951897
Stats:
On Tue, 30 May 2023 13:40:42 GMT, Tobias Hartmann wrote:
> Looks good and trivial.
Thanks @TobiHartmann .
-
PR Comment: https://git.openjdk.org/jdk/pull/14218#issuecomment-1568458529
Just remove the `static` to fix the build failure.
Thanks.
-
Commit messages:
- 8309110: Build failure after JDK-8307795 due to warnings in micro-bechmark
StoreMaskTrueCount.java
Changes: https://git.openjdk.org/jdk/pull/14218/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr
On Fri, 19 May 2023 10:50:39 GMT, Alan Bateman wrote:
> > May I push it now since it's a build breakage? Thanks.
>
> Yes, the change is trivial so please go ahead.
Thanks @AlanBateman .
-
PR Comment: https://git.openjdk.org/jdk/pull/14057#issuecomment-1554418471
On Fri, 19 May 2023 10:02:04 GMT, Jie Fu wrote:
> May I get review for this change which fixes the build broken with GCC8?
> Thanks.
This pull request has now been integrated.
Changeset: 690d3969
Author: Jie Fu
URL:
https://git.openjdk.org/jdk/
On Fri, 19 May 2023 10:12:52 GMT, Alan Bateman wrote:
> This looks okay
Thanks @AlanBateman for your quick review.
May I push it now since it's a build breakage?
Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/14057#issuecomment-1554383346
May I get review for this change which fixes the build broken with GCC8?
Thanks.
-
Commit messages:
- 8308408: Build failure with -Werror=maybe-uninitialized in libjli/java.c
with GCC8
Changes: https://git.openjdk.org/jdk/pull/14057/files
Webrev: https://webrevs.openjdk.org/?repo=
On Tue, 7 Feb 2023 08:45:49 GMT, Alan Bateman wrote:
> It's okay if your change goes first of course, it's just that I hope to
> replace these sleeps to make the tests more robust.
So just sponsor it.
-
PR: https://git.openjdk.org/jdk/pull/12398
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>
On Tue, 17 Jan 2023 18:12:44 GMT, Phil Race wrote:
> client changes are OK by me.
Thanks @prrace .
-
PR: https://git.openjdk.org/jdk/pull/12005
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>
On Sat, 14 Jan 2023 14:28:32 GMT, Jie Fu wrote:
> Hi all,
>
> Please review the fix for the build failure with clang-15.
>
> 1. -Wbitwise-instead-of-logical
>
>1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the
> warning
>
On Tue, 17 Jan 2023 04:29:31 GMT, David Holmes wrote:
> Hotspot changes are good.
Thanks @dholmes-ora .
-
PR: https://git.openjdk.org/jdk/pull/12005
On Mon, 16 Jan 2023 08:51:34 GMT, Jie Fu wrote:
> For the libzip issues, are these in the native methods or when compiling the
> zlib code, just wondering if there are bug reports for upstream there too.
Mainly caused by files under `src/java.base/share/native/libzip/zlib/`.
I'm
On Mon, 16 Jan 2023 08:21:47 GMT, Alan Bateman wrote:
> Is there a list of the issues building libjli? I don't see the in the PR or
> the JBS issue. For the libzip issues, are these in the native methods or when
> compiling the zlib code, just wondering if there are bug reports for upstream
>
On Sat, 14 Jan 2023 15:03:42 GMT, Kevin Rushforth wrote:
> Normally, such changes in third-party libraries need to be done upstream, and
> not locally. @prrace can confirm.
Thanks @kevinrushforth for your review.
Yes, it had been fixed in the upstream and I just follow it.
Please see https://g
Hi all,
Please review the fix for the build failure with clang-15.
1. -Wbitwise-instead-of-logical
1) src/hotspot/share/oops/generateOopMap.cpp <--- fixed the warning
2) src/hotspot/share/runtime/notificationThread.cpp <--- keep the code and
disable warnings
3) src/hotspot/s
On Fri, 2 Dec 2022 02:01:57 GMT, Jie Fu wrote:
> Hi all,
>
> The following 3 tests fail with debug VMs due to lack of @enablePreview after
> JDK-8297215.
>
>
> * jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
> * jtreg:test/jdk/java/lang/Threa
On Fri, 2 Dec 2022 05:16:14 GMT, Joe Darcy wrote:
> (Failures seen in subsequent testing in Oracle.)
Thanks @jddarcy for your review.
-
PR: https://git.openjdk.org/jdk/pull/11469
On Fri, 2 Dec 2022 02:19:49 GMT, Joe Darcy wrote:
> How are you running the tests? They pass on Oracle-internal tier 1 to 3
> testing.
Just run with
Ben="java/lang/Thread/virtual/stress/GetStackTraceALot.java
java/lang/Thread/virtual/HoldsLock.java jdk/internal/vm/Continuation/Basic.java"
ARG
Hi all,
The following 3 tests fail with debug VMs due to lack of @enablePreview after
JDK-8297215.
* jtreg:test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALot.java
* jtreg:test/jdk/java/lang/Thread/virtual/HoldsLock.java
* jtreg:test/jdk/jdk/internal/vm/Continuation/Basic.java
Let's fi
On Thu, 27 Oct 2022 03:53:13 GMT, Jie Fu wrote:
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
This pull requ
On Thu, 3 Nov 2022 03:31:56 GMT, Jie Fu wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best
On Wed, 2 Nov 2022 15:11:36 GMT, Aleksey Shipilev wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains four additi
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request incrementally with one additi
> Hi all,
>
> As discussed here
> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
> would be better to add the vector api tests in GHA.
>
> Thanks.
> Best regards,
> Jie
Jie Fu has updated the pull request incrementally with two additio
On Fri, 28 Oct 2022 13:41:28 GMT, Erik Joelsson wrote:
>> Jie Fu has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains four additi
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best
On Sat, 29 Oct 2022 23:08:38 GMT, Sergey Bylokhov wrote:
> What about possibility to run additional group of the test by passing somehow
> the name of group to the GA, via label or via /test cmd, or via parameter to
> the specific task in GA?
Well, it sounds good to run specific tests via labe
On Sat, 29 Oct 2022 07:58:49 GMT, Alan Bateman wrote:
> I realise there are already some test lists in both the hotspot and jdk
> TEST.groups but it feels like it needs something better so that
> RunTests.gmk/jtreg can select the sanity tests to run.
Thanks @AlanBateman for this comment.
Is th
On Fri, 28 Oct 2022 13:41:28 GMT, Erik Joelsson wrote:
> I think you need to add at least one other label than `build` to this now to
> make sure the right people can have a say in the change.
Done.
Thanks @erikj79 .
-
PR: https://git.openjdk.org/jdk/pull/10879
On Fri, 23 Sep 2022 11:03:52 GMT, Jie Fu wrote:
> Hi all,
>
> Since `ThreadDeath` would be deprecated soon, I assume it's fine to just
> remove it.
>
> Thanks.
> Best regards,
> Jie
This pull request has now been integrated.
Changeset: 2e20e7ec
Author:
On Fri, 23 Sep 2022 11:03:52 GMT, Jie Fu wrote:
> Hi all,
>
> Since `ThreadDeath` would be deprecated soon, I assume it's fine to just
> remove it.
>
> Thanks.
> Best regards,
> Jie
Thank you all for the review.
-
PR: https://git.openjdk.org/jdk/pull/10406
On Fri, 23 Sep 2022 12:23:53 GMT, Aleksey Shipilev wrote:
> I think it is also better be named "Remove use of ThreadDeath from make
> utilities" :)
Done.
Thanks.
-
PR: https://git.openjdk.org/jdk/pull/10406
On Fri, 23 Sep 2022 12:09:46 GMT, Magnus Ihse Bursie wrote:
> Fix is good but change bug type to subtask as Shipilev says.
Done.
Thanks @magicus and @shipilev .
-
PR: https://git.openjdk.org/jdk/pull/10406
Hi all,
Since `ThreadDeath` would be deprecated soon, I assume it's fine to just remove
it.
Thanks.
Best regards,
Jie
-
Commit messages:
- 8294271: make bootcycle-images fails after JDK-8289610
Changes: https://git.openjdk.org/jdk/pull/10406/files
Webrev: https://webrevs.openjdk
On Wed, 14 Sep 2022 10:47:18 GMT, Jaikiran Pai wrote:
>> Hi all,
>>
>> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp`
>> is a symbolic link directory.
>> The root cause is that `JarUtils.createJarFile` [1] will throw
>> `FileAlreadyExistsException` if `parent` is a
On Wed, 14 Sep 2022 09:42:37 GMT, Jie Fu wrote:
> Hi all,
>
> runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is
> a symbolic link directory.
> The root cause is that `JarUtils.createJarFile` [1] will throw
> `FileAlreadyExistsException` if `par
On Wed, 21 Sep 2022 15:34:03 GMT, Ioi Lam wrote:
> Withdraw my approval per Alan's comment.
Okay.
Thanks @iklam and @AlanBateman .
-
PR: https://git.openjdk.org/jdk/pull/10266
On Wed, 14 Sep 2022 10:47:18 GMT, Jaikiran Pai wrote:
> I could reproduce the issue with `Files.createDirectories` on a macos with a
> trivial program. It appears to be because of the use of `NOFOLLOW_LINKS` here
> https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/nio/
Hi all,
runtime/Dictionary/ProtectionDomainCacheTest.java fails on Linux if `/tmp` is a
symbolic link directory.
The root cause is that `JarUtils.createJarFile` [1] will throw
`FileAlreadyExistsException` if `parent` is a symbolic directory.
So it seems better to test the existance of `parent` b
On Fri, 19 Aug 2022 19:48:24 GMT, Daniel D. Daugherty
wrote:
>> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG
>> setting
>> when waiting for a compilation to finish.
>>
>> This fix is being tested in my jdk-20+10 stress testing run.
>>
>> The usual Mach5 timeoutF
On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty
wrote:
> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG
> setting
> when waiting for a compilation to finish.
>
> This fix is being tested in my jdk-20+10 stress testing run.
>
> The usual Mach5 timeoutFactor i
On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty
wrote:
> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG
> setting
> when waiting for a compilation to finish.
>
> This fix is being tested in my jdk-20+10 stress testing run.
>
> The usual Mach5 timeoutFactor i
On Fri, 12 Aug 2022 04:03:56 GMT, Jie Fu wrote:
>> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG
>> setting
>> when waiting for a compilation to finish.
>>
>> This fix is being tested in my jdk-20+10 stress testing run.
>>
>
On Tue, 5 Jul 2022 04:21:55 GMT, xpbob wrote:
> Container configuration information is useful for troubleshooting
> problems,Exposing information in MBeans is ideal for monitoring, jConsole,
> and other scenarios.
> Results the following
> 