On Wed, 2 Nov 2022 17:21:11 GMT, Jorn Vernee wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/runtime/TemplateSu
On Tue, 1 Nov 2022 00:09:21 GMT, David Schlosnagle wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add @SafeVarargs declarations
>
> src/java.base/share/classes/java/lang/runtime/TemplateSupport.java line 201:
>
>>
On Mon, 31 Oct 2022 20:11:34 GMT, Jim Laskey wrote:
>> Enhance the Java programming language with string templates, which are
>> similar to string literals but contain embedded expressions. A string
>> template is interpreted at run time by replacing each expression with the
>> result of
On Wed, 26 Oct 2022 05:18:45 GMT, Ioi Lam wrote:
>> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show
>> how invokedynamic call sites are resolved.
>>
>> For example:
>>
>>
>> public class StrConcat {
>> static String hello = "Hello";
>> static String world
On Tue, 25 Oct 2022 19:43:14 GMT, Jorn Vernee wrote:
>> Is it possible to use filter/findfirst without using lambdas? I want to
>> avoid recursion inside the tracing code.
>>
>> I am not sure about dumping the call stack. It seems an overkill and not
>> use
On Tue, 25 Oct 2022 19:37:06 GMT, Ioi Lam wrote:
> Is it possible to use filter/findfirst without using lambdas? I want to avoid
> recursion inside the tracing code.
You could do this I believe (if I've eye-balled that correctly :)):
Suggestion:
String callerName = caller.getName();
On Tue, 25 Oct 2022 17:34:15 GMT, Ioi Lam wrote:
>> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show
>> how invokedynamic call sites are resolved.
>>
>> For example:
>>
>>
>> public class StrConcat {
>> static String hello = "Hello";
>> static String world
On Tue, 25 Oct 2022 18:54:19 GMT, Jorn Vernee wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @JornVernee comments
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleNativ
On Mon, 24 Oct 2022 22:15:49 GMT, Ioi Lam wrote:
> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show
> how invokedynamic call sites are resolved.
>
> For example:
>
>
> public class StrConcat {
> static String hello = "Hello";
> static String world =
On Tue, 25 Oct 2022 12:50:05 GMT, Jorn Vernee wrote:
>> I've added a `java.lang.invoke.MethodHandle.TRACE_CALLSITE` property to show
>> how invokedynamic call sites are resolved.
>>
>> For example:
>>
>>
>> public class StrConcat {
>> sta
On Tue, 11 Oct 2022 15:48:56 GMT, Raffaello Giulietti
wrote:
> Simple doc correction.
Marked as reviewed by jvernee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10658
On Thu, 21 Jul 2022 18:48:14 GMT, Jorn Vernee wrote:
> This patch removes the use of std::thread from the `java.lang.foreign` tests,
> and switches to the OS specific thread APIs, in order to change things such
> as the stack size on some platforms where this is required in the fu
On Fri, 22 Jul 2022 18:44:30 GMT, Thomas Stuefe wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> Hi @JornVernee,
>
> good job and thanks for doing it so quickly. Lo
On Wed, 27 Jul 2022 06:43:45 GMT, David Holmes wrote:
> > Does run_in_new_thread seem good enough?
>
> No, sorry, the fact it both runs and joins is a critical aspect. `run_async`
> in `CompleteableFuture` just does the "run in new thread" part, whereas the
> `get()` on the returned
by adding a small header-only library that exposes a function to
> run code in freshly spawned threads (`run_async`).
>
> Testing: Running the affected tests on platforms that implement the linker.
Jorn Vernee has updated the pull request incrementally with one additional
com
On Tue, 26 Jul 2022 09:44:53 GMT, Maurizio Cimadamore
wrote:
> This patch removes java/foreign/TestUnsupportedPlatform, which has been
> superseded by TestUnsupportedLinker, and is no longer required.
> This old test relies on unspecified behavior and should be removed.
Marked as reviewed by
On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote:
>> This patch removes the use of std::thread from the `java.lang.foreign`
>> tests, and switches to the OS specific thread APIs, in order to change
>> things such as the stack size on some platforms where this is required
by adding a small header-only library that exposes a function to
> run code in freshly spawned threads (`run_async`).
>
> Testing: Running the affected tests on platforms that implement the linker.
Jorn Vernee has updated the pull request incrementally with one additional
commit since t
by adding a small header-only library that exposes a function to
> run code in freshly spawned threads (`run_async`).
>
> Testing: Running the affected tests on platforms that implement the linker.
Jorn Vernee has updated the pull request incrementally with one additional
commit since t
On Tue, 26 Jul 2022 13:39:50 GMT, Jorn Vernee wrote:
>> The intent was to exit the test with a non-zero exit code, in order to avoid
>> any accidental false positives.
>>
>> I could return the error code from `GetLastError` and from the respective
>> pthrea
On Tue, 26 Jul 2022 12:58:09 GMT, Jorn Vernee wrote:
>> test/lib/native/testlib_threads.h line 50:
>>
>>> 48: static void fatal(const char* message) {
>>> 49: perror(message);
>>> 50: exit(-1);
>>
>> Won't work as intended for Windows
On Sat, 23 Jul 2022 05:58:42 GMT, David Holmes wrote:
> `run_async` is an odd name for this, especially as the fact you create then
> join mean it doesn't run asynchronously at all - it runs synchronously in
> another thread.
I took the name from the CompleteableFuture API [1], although in
On Fri, 22 Jul 2022 18:37:02 GMT, Thomas Stuefe wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> test/lib/native/testlib_threads.h line 61:
>
>> 59: helper->
On Fri, 22 Jul 2022 18:32:56 GMT, Thomas Stuefe wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> test/lib/native/testlib_threads.h line 50:
>
>> 48: static
On Fri, 22 Jul 2022 14:56:16 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixes
>
> Looks good!
@mcimadamore Thanks for the comments. I've cleaned up
On Fri, 22 Jul 2022 15:09:13 GMT, Christoph Langer wrote:
>> This patch removes the use of std::thread from the `java.lang.foreign`
>> tests, and switches to the OS specific thread APIs, in order to change
>> things such as the stack size on some platforms where this is required in
>> the
by adding a small header-only library that exposes a function to
> run code in freshly spawned threads (`run_async`).
>
> Testing: Running the affected tests on platforms that implement the linker.
Jorn Vernee has updated the pull request incrementally with one additional
commit since
On Thu, 21 Jul 2022 12:06:37 GMT, Maurizio Cimadamore
wrote:
> The javadoc for `Linker` states that some operations throw
> `UnsupportedOperationException` when called on an unsupported platform. These
> operations are:
>
> * `Linker::nativeLinker`
> * `VaList::empty`
> * `VaList::make`
> *
On Tue, 19 Jul 2022 11:07:27 GMT, Maurizio Cimadamore
wrote:
> This patch fixes several `toRowLongValue` instead of `toRawLongValue`
> scattered in the javadoc for accessor methods in `MemorySegment` and
> `MemoryAddress`.
Marked as reviewed by jvernee (Reviewer).
-
PR:
On Mon, 18 Jul 2022 14:21:19 GMT, Thomas Stuefe wrote:
> Until [JDK-8290059](https://bugs.openjdk.org/browse/JDK-8290059) is solved,
> I'd like to disable
>
> - java/foreign/TestUpcallAsync.java
> - java/foreign/enablenativeaccess/TestEnableNativeAccess.java
>
> on muslc to take load from our
On Wed, 29 Jun 2022 13:40:01 GMT, Jorn Vernee wrote:
> This patch changes all VaList implementations to throw
> `NoSuchElementException` when out of bounds reads occur on a VaList that is
> created using the Java builder API. The docs are updated accordingly.
>
> For VaLists t
their
> bounds, so we can not throw exceptions in that case.
>
> Testing: `jdk_foreign` test suite on all platforms that implement VaList.
Jorn Vernee has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- Merge bra
On Mon, 4 Jul 2022 13:01:34 GMT, Jorn Vernee wrote:
> This PR updates the spec and implementation to throw an
> `IllegalArgumentException` when an attempt is made to convert a Java string
> containing null characters to a C string.
>
> Testing: local run of the `jdk_fore
On Wed, 6 Jul 2022 21:50:36 GMT, Maurizio Cimadamore
wrote:
>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Turn non-closeable view back into
On Mon, 27 Jun 2022 16:44:17 GMT, Jorn Vernee wrote:
> https://github.com/openjdk/jdk/pull/8817 added a button to copy a link to a
> section of javadoc to the clipboard. For the copy button to appear, the
> header needs to have an `id`.
>
> This cleanup PR canonicalizes
On Wed, 6 Jul 2022 17:05:51 GMT, Jorn Vernee wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert implicit vs. heap session changes
>
> src/java.base/sh
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore
wrote:
>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert implicit vs. heap session
On Mon, 4 Jul 2022 13:01:34 GMT, Jorn Vernee wrote:
> This PR updates the spec and implementation to throw an
> `IllegalArgumentException` when an attempt is made to convert a Java string
> containing null characters to a C string.
>
> Testing: local run of the `jdk_foreign` te
On Fri, 17 Jun 2022 18:39:03 GMT, Maurizio Cimadamore
wrote:
>> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert implicit vs. heap session
> This PR updates the spec and implementation to throw an
> `IllegalArgumentException` when an attempt is made to convert a Java string
> containing null characters to a C string.
>
> Testing: local run of the `jdk_foreign` test suite.
Jorn Vernee has updated the pull reques
On Tue, 5 Jul 2022 11:13:15 GMT, Maurizio Cimadamore
wrote:
>> This patch changes all VaList implementations to throw
>> `NoSuchElementException` when out of bounds reads occur on a VaList that is
>> created using the Java builder API. The docs are updated accordingly.
>>
>> For VaLists that
On Tue, 5 Jul 2022 11:03:30 GMT, Maurizio Cimadamore
wrote:
>> This patch changes all VaList implementations to throw
>> `NoSuchElementException` when out of bounds reads occur on a VaList that is
>> created using the Java builder API. The docs are updated accordingly.
>>
>> For VaLists that
On Tue, 5 Jul 2022 15:07:32 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/foreign/VaList.java line 61:
>>
>>> 59: * Particularly, variable argument lists created using {@link
>>> #make(Consumer, MemorySession)} are able to detect out-of-
their
> bounds, so we can not throw exceptions in that case.
>
> Testing: `jdk_foreign` test suite on all platforms that implement VaList.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
hmtl -> html
---
their
> bounds, so we can not throw exceptions in that case.
>
> Testing: `jdk_foreign` test suite on all platforms that implement VaList.
Jorn Vernee has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
On Tue, 5 Jul 2022 15:14:20 GMT, Jorn Vernee wrote:
>> This seems a bit too much.
>>
>> The class javadoc further up already describes a va list as "a stateful
>> cursor used to iterate over a set of arguments". If that description is
>> in
This PR updates the spec and implementation to throw an
`IllegalArgumentException` when an attempt is made to convert a Java string
containing null characters to a C string.
Testing: local run of the `jdk_foreign` test suite.
-
Commit messages:
- Throw IAE when converting string
This patch changes all VaList implementations to throw `NoSuchElementException`
when out of bounds reads occur on a VaList that is created using the Java
builder API. The docs are updated accordingly.
For VaLists that are created from native addresses, we don't know their bounds,
so we can not
On Mon, 27 Jun 2022 20:40:43 GMT, Maurizio Cimadamore
wrote:
>> Recent fix for JDK-8289188 relaxed behavior or
>> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
>> null handling to what it used to be.
>
> Maurizio Cimadamore has updated the pull request
On Mon, 27 Jun 2022 16:47:32 GMT, Maurizio Cimadamore
wrote:
> Recent fix for JDK-8289188 relaxed behavior or
> `SegmentAllocator::allocateArray` too much w.r.t. nulls. This patch reverts
> null handling to what it used to be.
Should test/jdk/java/foreign/TestNulls.java also be reverted?
On Mon, 27 Jun 2022 16:57:10 GMT, Maurizio Cimadamore
wrote:
>> > href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8817__;!!ACWV5N9M2RV99hQ!Ooc0KcgMe7NsDGNiGbF-wfC_tK6POSNyLNDIHsrms0gVVdXsgnVAAbWZpHXSYWbAAmkJrTeqEh4N1h-1f8ZwKplq$;>https://github.com/openjdk/jdk/pull/8817
>>
https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/8817__;!!ACWV5N9M2RV99hQ!Kkp_j7PnK9AJEJUL817VN56eVeunFZsJPCPgXLt_Dgb1QE4PxZokFGCEF_Cf7KNASIrlkM5xZTNXSGd6ve264vZm$
added a button to copy a link to a section of javadoc to the clipboard.
This cleanup PR canonicalizes all header ids
review.
>>
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/java/lang/constant/ClassDescTest.java
>
> Co-authored-by: Jorn Vernee
Thanks for explaining.
-
Marked as reviewed by jvernee (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9201
On Fri, 17 Jun 2022 12:59:17 GMT, Claes Redestad wrote:
> - Refactor micro using a range of parameters to a simpler benchmark that
> tests different values in one pass
> - Reduce iterations and their runtimes, but add forks (important to be able
> to detect run-to-run variation anomalies)
>
>
On Fri, 17 Jun 2022 14:19:11 GMT, Adam Sotona wrote:
> The symbolic constants API (`java.lang.constant`) was designed, in part, to
> provide bytecode parsing and generation APIs with a validated, common,
> symbolic form for constants in Java class files.
>
> There is an easy way to create a
On Wed, 15 Jun 2022 18:06:44 GMT, Maurizio Cimadamore
wrote:
> This is a JDK 19 clone of: https://github.com/openjdk/jdk/pull/9017
Already reviewed in the mainline repo.
-
Marked as reviewed by jvernee (Reviewer).
PR: https://git.openjdk.org/jdk19/pull/22
801 - 856 of 856 matches
Mail list logo
