Re: Deterministic naming of subclasses of `java/lang/reflect/Proxy`

2024-05-22 Thread Joseph D. Darcy
On 5/22/2024 11:19 AM, Aman Sharma wrote: Hi, [snip] Notice the difference in the order of fields and `helpCommand` method is mapped to a different field name in both classes. This happens because the method array returned by `getMethods` is not sorted in any particular order

Re: CFV: New Core Libraries Group Member: Per-Ake Minborg

2024-03-19 Thread Joseph D. Darcy
Vote: yes On 3/19/2024 8:19 AM, Daniel Fuchs wrote: Hi, I hereby nominate Per-Ake Minborg (pminborg) [1] to Membership in the Core Libraries Group [4]. Per-Ake is an OpenJDK Reviewer, a committer in the Leyden and Panama projects, and a member of Oracle’s Java Core Libraries team. Per-Ake

Re: CFV: New Core Libraries Group Member: Viktor Klang

2024-02-20 Thread Joseph D. Darcy
Vote: yes -Joe On 2/19/2024 3:40 PM, Stuart Marks wrote: I hereby nominate Viktor Klang [6] to Membership in the Core Libraries Group [4]. Viktor has been a member of the Java team in Oracle since 2022, and he is currently a Committer on the JDK project. Viktor has led JEP 461 [1], an

Re: CFV: New Core Libraries Group Member: Raffaello Giulietti

2024-02-13 Thread Joseph D. Darcy
Vote: yes -Joe On 2/13/2024 12:25 PM, Brian Burkhalter wrote: I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group. Raffaello has been working in the Core Library team at Oracle since April, 2022. He has authored more than 50 contributions to OpenJDK in a number of

Re: Blessed modifier order does not include sealed/non-sealed

2024-01-02 Thread Joseph D. Darcy
Note that in terms of updating the implementation of toGenericString() JDK-8322878 to included sealed information, since strictfp is a no-op in the same release sealed/non-sealed was added, a class file can be     sealed XOR strictfp Therefore, Class.toGenericString() could print the

Re: Blessed modifier order does not include sealed/non-sealed

2024-01-02 Thread Joseph D. Darcy
Hello, Some time back, the java.lang.reflect package level docs had a brief discussion added concerning what exactly core reflection is modeling. [1]. tl;dr -- mostly a class file level view. As such, a contingent property of the design of JEP 409 is that sealed/non-sealed happens to _not_

Re: RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal

2023-10-23 Thread Joseph D. Darcy
Hi Hans, Giving some additional context, we'll occasionally get bug reports that amount to an observation equivalent to the following: "I have two Big{Foo} variables and in a loop I assign larger and larger values to them. As the values get large, bigFoo1.add(bigFoo2) runs much faster than

Re: CFV: New Core Libraries Group Member: Joe Wang

2023-07-27 Thread Joseph D. Darcy
Vote: yes On 7/27/2023 11:36 AM, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX,

Re: CFV: New Core Libraries Group Member: Brent Christian

2023-07-27 Thread Joseph D. Darcy
Vote: yes On 7/27/2023 11:36 AM, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class loader,

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

2023-07-27 Thread Joseph D. Darcy
Vote: yes On 7/27/2023 11:35 AM, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, files,

Re: 4-letter patterns in Date Format Style no longer give full text style

2023-07-10 Thread Joseph D. Darcy
Perhaps JEP 252 (https://openjdk.org/jeps/252) as mentioned in the JDK 9 release notes. -Joe On 7/10/2023 12:08 PM, Bruno Borges wrote: Hi all, Was there any change to Date Time Formatter API that made the "" and the "" (and other 4-letter patterns) change from Java 8 to 11+ ?

Re: List extending Collection/SequencedCollection

2023-06-30 Thread Joseph D. Darcy
across JDK versions for List. On Wed, Jun 28, 2023 at 6:31 PM Joseph D. Darcy wrote: Hello, What is Painless doing that would fail under List extends SequencedCollection ... but work under List extends SequencedCollection, Collection ... The two definition are semantically equiva

Re: List extending Collection/SequencedCollection

2023-06-28 Thread Joseph D. Darcy
Hello, What is Painless doing that would fail under     List extends SequencedCollection ... but work under     List extends SequencedCollection, Collection ... The two definition are semantically equivalent since SequencedCollection itself extends Collection. The JDK 22 javadoc for List

Re: The introduction of Sequenced collections is not a source compatible change

2023-05-11 Thread Joseph D. Darcy
-Joe On 5/4/2023 9:08 PM, Joseph D. Darcy wrote: PS And as a general policy, over the releases we've done more to preserve source compatibility when possible for language changes. For example, there were many source compatibility breakages when "assert" was added as a keyword back in

Re: The introduction of Sequenced collections is not a source compatible change

2023-05-04 Thread Joseph D. Darcy
d consider this type inference usage moot. It is same as adding another method addAll(List) when there is already addAll(String[]): existing addAll(null) calls will break, but this is not a valid argument against adding a List variant of addAll. On Thu, May 4, 2023 at 9:38 PM Joseph D. Darcy wrote: A fe

Re: The introduction of Sequenced collections is not a source compatible change

2023-05-04 Thread Joseph D. Darcy
A few comments on the general compatibility policy for the JDK. Compatibility is looked after by the Compatibility and Specification Review (CSR) process ( Compatibility & Specification Review). Summarizing the approach, The general compatibility policy for exported APIs implemented in the

Re: New class for handling infinite-precision rationals

2023-03-02 Thread Joseph D. Darcy
Hello, I suggest a general discussion about whether or not such a class is appropriate for inclusion in the platform [1] ahead of review of a particular PR. Cheers, -Joe [1] https://openjdk.org/guide/#socialize-your-change On 2/21/2023 10:21 AM, Fabio Romano wrote: The Rational class

Re: RFR: JDK-8302027: Port fdlibm trig functions (sin, cos, tan) to Java

2023-03-01 Thread Joseph D. Darcy
On 3/1/2023 8:16 AM, Raffaello Giulietti wrote: On Wed, 1 Mar 2023 14:27:09 GMT, Andrey Turbanov wrote: Last and certainly not least in the port of FDLIBM to Java, the transcendental methods for sin, cos, and tan. Some more tests are to be written in the StrictMath directory to verify that

Re: Difference in behaviour in native math library

2022-12-08 Thread Joseph D. Darcy
Hello, Okay, so it looks like the test is expected the same bit pattern to be used for a NaN output if a NaN was used as an input. That isn't necessarily unreasonable, but it is *not* required by the specifications for the Math or StrictMath method, spec for Math.acos: Returns the arc

Re: Redundant condition in java.math.MutableBigInteger#divideMagnitude

2022-11-28 Thread Joseph D. Darcy
Filed https://bugs.openjdk.org/browse/JDK-8297731. Thanks, -Joe On 11/28/2022 4:35 AM, Raffaello Giulietti wrote: I can confirm that testing that condition is indeed useless *From: *core-libs-dev on behalf of Andrey Turbanov *Date: *Friday, 2022-November-25 at 14:18 *To: *core-libs-dev

CSR review review for JDK-8296182: Start of release updates for JDK 21

2022-11-01 Thread Joseph D. Darcy
Hello, Looking ahead to the start of JDK 21, please review the CSR for     JDK-8296182: Start of release updates for JDK 21     https://bugs.openjdk.org/browse/JDK-8296182 which adds a new enum constant to ClassFileFormatVersion. (The draft PR https://github.com/openjdk/jdk/pull/10924 will

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-29 Thread Joseph D. Darcy
Thanks for catching that Iris; I'll changes those to git URLs. -Joe On 9/29/2022 9:11 PM, Iris Clark wrote: On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: With the domain change from openjdk.java.net to openjdk.org, references to URLs in the sources should be updated. Updates were

Re: Inconsistency between ClassDesc::packageName and Class::getPackageName

2022-08-22 Thread Joseph D. Darcy
On 8/22/2022 11:57 AM, Alan Bateman wrote: On 22/08/2022 18:13, Kasper Nielsen wrote: Hi, I understand that the methods are behaving as specified. However, I still think that int.class.getPackageName() = "java.lang" int.class.describeConstable().get().packageName() = "" is surprising

Re: Executable.hasRealParameterData() and Parameter.isNamePresent() don't work as expected

2022-06-29 Thread Joseph D. Darcy
If you want more information about parameters, use javac with its "-parameters" option. -Joe On 6/28/2022 11:54 PM, Сергей Цыпанов wrote: This question was asked originally here: