Re: RFR: 8337245: Fix wrong comment of StringConcatHelper

2024-07-26 Thread Paul Hohensee
On Fri, 26 Jul 2024 00:00:49 GMT, Shaojin Wen wrote: > 8337245: Fix wrong comment of StringConcatHelper Trivial. - Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20344#pullrequestreview-2202564779

Re: RFR: 8315579: SPARC64 builds are broken after JDK-8304913

2023-09-05 Thread Paul Hohensee
On Mon, 4 Sep 2023 07:28:03 GMT, Aleksey Shipilev wrote: > Similar to other issues in the same area. I have no SPARC machine to test the > build on, but this matches other fixes for other architectures > (https://github.com/openjdk/jdk/commit/83c096d6e20cd6e1164bc666df1be197a10431eb) > after

Re: RFR: 8310019: MIPS builds are broken after JDK-8304913

2023-06-14 Thread Paul Hohensee
On Wed, 14 Jun 2023 15:04:41 GMT, Roger Riggs wrote: > Add mipsel and mips64el to the Architecture enum. > (Later to be backported to JDK 21) Lgtm. - Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14471#pullrequestreview-1479721055

Re: RFR: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86

2022-12-15 Thread Paul Hohensee
On Tue, 13 Dec 2022 00:06:00 GMT, Sergey Bylokhov wrote: > The `java/lang/String/StringRepeat.java` test was updated twice after > integration: > > https://bugs.openjdk.org/browse/JDK-8221400 - the xmx4g was replaced by the > xmx2g > https://bugs.openjdk.org/browse/JDK-8265421 - the

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Paul Hohensee
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. I assumed it was a starter issue in order to learn the patch process. - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Paul Hohensee
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. I believe we need another reviewer (doesn't have to be a capital-Reviewer). I'll sponsor after that. - PR: https://git.openjdk.org/jdk/pull/8179

Re: RFR: 8284640: CollectorImpl class could be a record class

2022-06-28 Thread Paul Hohensee
On Mon, 11 Apr 2022 13:08:43 GMT, altrisi wrote: > Changes the definition of `CollectorImpl` to be a record. Lgtm. - Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk/pull/8179