Re: RFR: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

2022-06-27 Thread Thejasvi Voniadka
On Mon, 27 Jun 2022 05:32:01 GMT, Jaikiran Pai wrote: >> This is a simple change to add some protective code to >> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more >> complete in the event of encountering an any exceptions while running. In >> the present state, the

Integrated: 8282036: Change java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

2022-06-27 Thread Thejasvi Voniadka
On Mon, 27 Jun 2022 04:50:09 GMT, Thejasvi Voniadka wrote: > This is a simple change to add some protective code to > java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more > complete in the event of encountering an any exceptions while running. In the > p

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Thejasvi Voniadka
On Mon, 27 Jun 2022 10:52:58 GMT, Thejasvi Voniadka wrote: >> test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 89: >> >>> 87: server.stop(0); >>> 88: } >>> 89: } >> >> Is there a reason to p

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Thejasvi Voniadka
t; encountering a failure. As a result, the test may get hung until a timeout. > This fix should address the scenario. > > The test passes on all supported platforms post fix. Thejasvi Voniadka has updated the pull request incrementally with one additional commit since the last rev

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v2]

2022-06-27 Thread Thejasvi Voniadka
On Mon, 27 Jun 2022 06:34:29 GMT, Alan Bateman wrote: >> Thejasvi Voniadka has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop >&

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v2]

2022-06-27 Thread Thejasvi Voniadka
t; encountering a failure. As a result, the test may get hung until a timeout. > This fix should address the scenario. > > The test passes on all supported platforms post fix. Thejasvi Voniadka has updated the pull request incrementally with one additional commit since the last rev

RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions

2022-06-26 Thread Thejasvi Voniadka
This is a simple change to add some protective code to java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more complete in the event of encountering an any exceptions while running. In the present state, the server.stop() does not get executed in case of encountering a failure.