Re: RFR: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime [v6]

2022-12-06 Thread Tom Rodriguez
On Tue, 6 Dec 2022 16:06:34 GMT, Doug Simon wrote: >> Libgraal is compiled ahead of time and should not need any JVMCI Java code >> to be dynamically loaded at runtime. Prior to this PR, this is not the case >> due to: >> >> * Code to copy system properties from the HotSpot heap into the libgr

Re: RFR: 8303577: [JVMCI] OOME causes crash while translating exceptions

2023-03-06 Thread Tom Rodriguez
On Fri, 3 Mar 2023 15:40:01 GMT, Doug Simon wrote: > JDK-8297431 added code for special handling of OutOfMemoryError when > translating an exception between libjvmci and HotSpot[1]. > Unfortunately, this code was deleted by JDK-8298099 when moving the exception > translation mechanism to VMSupp

Re: RFR: 8303431: [JVMCI] libgraal annotation API [v5]

2023-03-14 Thread Tom Rodriguez
On Wed, 8 Mar 2023 22:59:23 GMT, Doug Simon wrote: >> This PR extends JVMCI with new API (`jdk.vm.ci.meta.Annotated`) for >> accessing annotations. The main differences from >> `java.lang.reflect.AnnotatedElement` are: >> * Each `Annotated` method explicitly specifies the annotation type(s) for

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal

2023-06-05 Thread Tom Rodriguez
On Fri, 2 Jun 2023 20:32:14 GMT, Doug Simon wrote: > This PR improves the startup time for libgraal by speeding up how > `VM.savedProps` is copied into libgraal. This data structure is now > serialized to a native buffer directly from C++ and the native buffer is then > directly decoded by lib

RFR: 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout

2023-06-05 Thread Tom Rodriguez
This allows bin/idea.sh to properly see the JVMCI files again. - Commit messages: - 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout Changes: https://git.openjdk.org/jdk/pull/14318/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14318&range=00 I

Integrated: 8309501: Remove workaround in bin/idea.sh for non standard JVMCI file layout

2023-06-06 Thread Tom Rodriguez
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote: > This allows bin/idea.sh to properly see the JVMCI files again. This pull request has now been integrated. Changeset: 7edd0540 Author: Tom Rodriguez URL: https://git.openjdk.org/jdk/com

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal

2023-06-06 Thread Tom Rodriguez
On Fri, 2 Jun 2023 20:32:14 GMT, Doug Simon wrote: > This PR improves the startup time for libgraal by speeding up how > `VM.savedProps` is copied into libgraal. This data structure is now > serialized to a native buffer directly from C++ and the native buffer is then > directly decoded by lib

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v3]

2023-06-11 Thread Tom Rodriguez
On Sun, 11 Jun 2023 17:26:28 GMT, Doug Simon wrote: >> This PR reduces the amount of code executed during libgraal initialization. >> This not only improves VM startup overall but all fixes a number of JDK test >> failures that are caused by Java code executing "too early". For example, >> `ja

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v4]

2023-06-12 Thread Tom Rodriguez
On Mon, 12 Jun 2023 09:21:14 GMT, Doug Simon wrote: >> This PR reduces the amount of code executed during libgraal initialization. >> This not only improves VM startup overall but all fixes a number of JDK test >> failures that are caused by Java code executing "too early". For example, >> `ja

Re: RFR: 8309390: [JVMCI] improve copying system properties into libgraal [v3]

2023-06-12 Thread Tom Rodriguez
On Mon, 12 Jun 2023 09:20:09 GMT, Doug Simon wrote: >> src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/services/Services.java line >> 314: >> >>> 312: String key = toJavaString(unsafe, unsafe.getLong(prop + >>> keyOffset)); >>> 313: long valueAddress = unsafe.getLong(pro

Re: RFR: 8313899: JVMCI exception Translation can fail in TranslatedException.

2023-08-09 Thread Tom Rodriguez
On Tue, 8 Aug 2023 20:52:29 GMT, Doug Simon wrote: > In a test that stresses metaspace (such as > `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also > uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in > `TranslatedException.` due to exhausted metaspace: >

Re: RFR: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch

2023-11-06 Thread Tom Rodriguez
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote: > This test requires certain methods to be compiled, but without `-Xbatch` the > compiler races against the test code, which can lead to intermittent failures. Marked as reviewed by never (Reviewer). - PR Review: https://git.ope

RFR: 8320198: some reference processing tests don't wait long enough for reference processing to complete

2023-12-04 Thread Tom Rodriguez
This slightly increases the wait for reference processing to complete to accommodate long Xcomp compile times. Testing is underway. - Commit messages: - 8320198: some reference processing tests don't wait long enough for reference processing to complete Changes: https://git.openj

Re: RFR: 8320198: some reference processing tests don't wait long enough for reference processing to complete

2023-12-04 Thread Tom Rodriguez
On Mon, 4 Dec 2023 20:51:20 GMT, Joe Darcy wrote: >> This slightly increases the wait for reference processing to complete to >> accommodate long Xcomp compile times. Testing is underway. > > test/jdk/java/lang/Object/FinalizationOption.java line 92: > >> 90: System.gc(); >> 91:

Re: RFR: 8320198: some reference processing tests don't wait long enough for reference processing to complete

2023-12-07 Thread Tom Rodriguez
On Thu, 7 Dec 2023 05:18:26 GMT, Jaikiran Pai wrote: >> This slightly increases the wait for reference processing to complete to >> accommodate long Xcomp compile times. Testing is underway. > > test/jdk/java/lang/Object/FinalizationOption.java line 89: > >> 87: static boolean checkFinaliz

Re: RFR: 8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation [v2]

2024-07-10 Thread Tom Rodriguez
On Tue, 9 Jul 2024 13:46:46 GMT, Doug Simon wrote: >> This PR addresses intermittent failures in jtreg GC stress tests. The >> failures occur under these conditions: >> 1. Using a libgraal build with assertions enabled as the top tier JIT >> compiler. Such a libgraal build will cause a VM exit

Re: RFR: 8338060: jdk/internal/util/ReferencedKeyTest should be more robust

2024-08-12 Thread Tom Rodriguez
On Fri, 9 Aug 2024 15:54:51 GMT, Roger Riggs wrote: > Addressing latent issues with ReferencedKeyTest > - During the `methods()` tests the keys should be strongly held to avoid > inadvertent GC collection and subsequent test failures (JDK-8336926) > - Merge changes from Valhalla to use String (i