On Thu, 30 May 2024 13:56:30 GMT, Emanuel Peter wrote:
>> Control question: Are we confident with this potentially going into JDK 23
>> or should we rather postpone to JDK 24? The fork is next week.
>
>> Control question: Are we confident with this potentially going into JDK 23
>> or should we
On Tue, 28 May 2024 17:36:03 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/c2_stubGenerator_x86_64_string.cpp line 488:
>>
>>> 486: __ cmpq(r11, nMinusK);
>>> 487: __ ja_b(L_return);
>>> 488: __ movq(rax, r11);
>>
>> At places where we know that return value in r11 is correct, we dont
On Wed, 22 May 2024 14:50:40 GMT, Scott Gibbons wrote:
>> test/jdk/java/lang/StringBuffer/IndexOf.java line 284:
>>
>>> 282:
>>> 283: // Note: it is possible although highly improbable that failCount
>>> will
>>> 284: // be > 0 even if everthing is working ok
>>
>> This sounds like
On Fri, 24 May 2024 15:32:26 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Fri, 17 May 2024 23:59:05 GMT, Scott Gibbons wrote:
>> test/jdk/java/lang/StringBuffer/IndexOf.java line 40:
>>
>>> 38: private static boolean failure = false;
>>> 39: public static void main(String[] args) throws Exception {
>>> 40: String testName = "IndexOf";
>>
>> intentation
>
On Wed, 22 May 2024 14:41:36 GMT, Scott Gibbons wrote:
>> test/micro/org/openjdk/bench/java/lang/StringIndexOfHuge.java line 132:
>>
>>> 130: @Benchmark
>>> 131: public int searchHugeLargeSubstring() {
>>> 132: return dataStringHuge.indexOf("B".repeat(30) + "X" +
>>> "A".repeat(30),
On Tue, 2 Apr 2024 15:42:05 GMT, Volodymyr Paprotski wrote:
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA10
On Tue, 21 May 2024 17:41:46 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256with
On Tue, 21 May 2024 07:21:14 GMT, Tobias Hartmann wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> shenandoah verifier
>
> I'm getting some conflicts when trying to apply this
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574 ±
On Fri, 17 May 2024 21:16:47 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256with
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
On Thu, 16 May 2024 23:21:36 GMT, Sandhya Viswanathan
wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> whitespace
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_pol
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
On Wed, 15 May 2024 19:21:37 GMT, Volodymyr Paprotski wrote:
>> Scott Gibbons has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rearrange; add lambdas for clarity
>
> test/jdk/java/lang/StringBuffer/IndexOf.
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sat, 4 May 2024 19:35:21 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
On Thu, 9 May 2024 23:36:03 GMT, Anthony Scarpino wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> whitespace
>
> src/java.base/share/classes/sun/security/ec/ECOpera
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
On Tue, 9 Apr 2024 02:01:36 GMT, Anthony Scarpino wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove use of jdk.crypto.ec
>
> src/java.base/share/classes/sun/security
On Tue, 23 Apr 2024 19:55:57 GMT, Anthony Scarpino
wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comments from Jatin and Tony
>
> src/java.base/share/classes/sun/security
On Tue, 16 Apr 2024 02:26:57 GMT, Jatin Bhateja wrote:
>> Per-above, this is a switch statement (`UNLIKELY`) fallback. I can still add
>> alignment and loop rotation, but being a fallback figured its more important
>> to keep it small
>
> It's all part of intrinsic, no harm in polishing it.
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
On Fri, 5 Apr 2024 07:19:28 GMT, Jatin Bhateja wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove use of jdk.crypto.ec
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_p
On Wed, 10 Apr 2024 23:56:52 GMT, Volodymyr Paprotski wrote:
> Few early comments.
>
> Please update the copyright year of all the modified files.
>
> You can even consider splitting this into two patches, Java side changes in
> one and x86 optimized intrinsic in ne
On Thu, 11 Apr 2024 17:15:21 GMT, Anthony Scarpino
wrote:
>>> In `ECOperations.java`, if I understand this correctly, it is to replace
>>> the existing `PointMultiplier` with montgomery-based PointMuliplier. But
>>> when I look at the code, I see both are still options. If I read this
>>>
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
On Fri, 5 Apr 2024 09:17:18 GMT, Jatin Bhateja wrote:
> Few early comments.
>
> Please update the copyright year of all the modified files.
>
> You can even consider splitting this into two patches, Java side changes in
> one and x86 optimized intrinsic in next one.
Thanks Jatin, will fix!
On Wed, 10 Apr 2024 17:18:55 GMT, Anthony Scarpino
wrote:
> In `ECOperations.java`, if I understand this correctly, it is to replace the
> existing `PointMultiplier` with montgomery-based PointMuliplier. But when I
> look at the code, I see both are still options. If I read this correctly, it
On Tue, 2 Apr 2024 19:19:59 GMT, Volodymyr Paprotski wrote:
>> Performance. Before:
>>
>> Benchmark(algorithm) (dataSize) (keyLength)
>> (provider) Mode Cnt ScoreError Units
>> SignatureBench.ECDSA.signSHA256with
On Tue, 2 Apr 2024 16:29:07 GMT, Alan Bateman wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove use of jdk.crypto.ec
>
> src/java.base/share/classes/module
ntBench.EC.generateSecret ECDH 256
> EC thrpt3 1346.523 ± 28.722 ops/s
> Benchmark (isMontBench) Mode Cnt Score
> Error Units
> PolynomialP256Bench.benchMultiply true thrpt3 1919.574
Performance. Before:
Benchmark(algorithm) (dataSize) (keyLength)
(provider) Mode Cnt ScoreError Units
SignatureBench.ECDSA.signSHA256withECDSA1024 256
thrpt3 6443.934 ± 6.491 ops/s
SignatureBench.ECDSA.sign
37 matches
Mail list logo
