Integrated: 8311517: Add performance information to ArrayList javadoc

2023-08-04 Thread dan1st
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, a

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread dan1st
On Fri, 4 Aug 2023 15:31:59 GMT, Brian Burkhalter wrote: >> dan1st has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8311517: ArrayList Javadoc of getFirst/getLast/removeLast >> >> as requested b

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-08-04 Thread dan1st
On Fri, 4 Aug 2023 03:08:26 GMT, Stuart Marks wrote: > Thanks for the updates. I've drafted a CSR; see link in header. Please take a > look. @stuart-marks Thanks, the CSR looks good to me. I guess the `Fix versions` field will be added when the CSR is reviewed? - PR Comment: http

Re: RFR: 8311517: Add performance information to ArrayList javadoc

2023-08-02 Thread dan1st
On Wed, 26 Jul 2023 23:01:26 GMT, Stuart Marks wrote: >> The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add >> addFirst(), removeFirst() and reversed() methods to lists. >> However, the Javadoc of List mentions: >> > The size, isEmpty, get, set, iterator, and listIterat

Re: RFR: 8311517: Add performance information to ArrayList javadoc

2023-07-26 Thread dan1st
On Wed, 26 Jul 2023 21:59:41 GMT, Stuart Marks wrote: > Regarding the text of the change: should getFirst() and getLast() be > mentioned? They were added by Sequenced Collections, and they run in constant > time. Also, while add() and addLast() run in amortized constant time (because > of the

Re: RFR: 8311517: Add performance information to ArrayList javadoc [v2]

2023-07-26 Thread dan1st
adoc to factor in the new methods introduced by JEP > 431. > > https://bugs.openjdk.org/browse/JDK-8311517 > https://mail.openjdk.org/pipermail/core-libs-dev/2023-June/107328.html > https://mail.openjdk.org/pipermail/core-libs-dev/2023-July/109637.html > > This PR only affec

Re: RFR: 8311517: ArrayList javadoc improvements related to sequenced collection updates

2023-07-26 Thread dan1st
On Wed, 26 Jul 2023 11:02:20 GMT, dan1st wrote: > The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add > addFirst(), removeFirst() and reversed() methods to lists. > However, the Javadoc of List mentions: > > The size, isEmpty, get, set, iterator, a

RFR: 8311517: ArrayList javadoc improvements related to sequenced collection updates

2023-07-26 Thread dan1st
The [JEP for sequenced collections](https://openjdk.org/jeps/431) would add addFirst(), removeFirst() and reversed() methods to lists. However, the Javadoc of List mentions: > The size, isEmpty, get, set, iterator, and listIterator operations run in > constant time. The add operation runs in am