On Fri, 7 Jul 2023 07:55:03 GMT, sid8606 wrote:
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
This pull request has now been integrated.
Changeset: ec1f7a84
Author:Sidraya
Committer: Andrew Dinn
URL:
https://git.openj
On Fri, 18 Aug 2023 04:41:25 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Calculate the
On Tue, 8 Aug 2023 09:59:39 GMT, Martin Doerr wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indentation
>>
>> Signed-off-by: Sidraya
>
> src/hotspot/cpu/s390
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with two additional commits
since the last revision:
- Calculate the code size.
- Fix missing spcaces
-
Changes:
- all: https://gi
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Fix indentation
Signed-off-by: Sidraya
-
Changes:
- all: https://git.ope
On Sun, 6 Aug 2023 09:32:08 GMT, Andrey Turbanov wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>>
>> Signed-off-by: Sidraya
>
> src/java.base/share/c
On Mon, 7 Aug 2023 13:37:57 GMT, Martin Doerr wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo
>>
>> Signed-off-by: Sidraya
>
> src/hotspot/cpu/s390/f
On Mon, 31 Jul 2023 14:27:38 GMT, Amit Kumar wrote:
>> src/hotspot/cpu/s390/frame_s390.cpp line 228:
>>
>>> 226:
>>> 227: bool frame::upcall_stub_frame_is_first() const {
>>> 228: assert(is_upcall_stub_frame(), "must be optimzed entry frame"
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo
Signed-off-by: Sidraya
-
Changes:
- all: https://git.openjdk.o
On Thu, 13 Jul 2023 07:46:00 GMT, Amit Kumar wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> src/java.base/share/classes/jdk/i
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Fix typos
Signed-off-by: Sidraya
-
Changes:
- all: https://git.openjdk.o
On Mon, 31 Jul 2023 09:51:44 GMT, sid8606 wrote:
>> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 45:
>>
>>> 43: if (reg == Z_SP) continue;
>>> 44: // though Z_R6 is argument register it is a saved register
>>> 45: if (!abi.is_volatile_reg(r
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
List all the volatile regs in LinuxS390CallArranger explicitly
Signe
On Mon, 31 Jul 2023 08:08:37 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Preserve and restore register Z_R6
>>
>> Though Z_R6 is argument register it is a
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Restructure comment sentence
-
Changes:
- all: https://git.openjdk.org/jdk
On Fri, 28 Jul 2023 12:36:13 GMT, Andrew Haley wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Preserve and restore register Z_R6
>>
>> Though Z_R6 is argument register it is a
On Fri, 21 Jul 2023 12:17:55 GMT, Martin Doerr wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> I can see it failing with `make run-test TEST
On Thu, 27 Jul 2023 05:05:57 GMT, sid8606 wrote:
>> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162:
>>
>>> 160:
>>> 161: assert(!_needs_return_buffer, "unexpected needs_return_buffer");
>>> 162: bool should_save_return_value = _need
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Preserve and restore register Z_R6
Though Z_R6 is argument register it is a saved register
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
remove if statements around the spill/fill code
See: #15025 (should_save_return_value b
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
revert platform byte ordering changes
-
Changes:
- all: https://git.openjdk.o
On Tue, 25 Jul 2023 21:26:06 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestion
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestions
On Fri, 21 Jul 2023 10:46:14 GMT, Martin Doerr wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address suggestions from Jorn Vernee
>
> I've seen
>
> java/foreign/StdLibT
On Sat, 8 Jul 2023 10:48:15 GMT, sid8606 wrote:
>> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
>
> sid8606 has updated the pull request incrementally with one additional commit
> since the last revision:
>
> Address suggestio
On Fri, 7 Jul 2023 12:24:10 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line
On Fri, 7 Jul 2023 12:02:33 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line
On Fri, 7 Jul 2023 12:06:39 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/foreignGlobals_s390.cpp line 1
On Fri, 7 Jul 2023 11:56:28 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/downcallLinker_s390.cpp line 162
On Fri, 7 Jul 2023 10:33:10 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> test/jdk/java/foreign/TestIllegalLink.java line 57:
&
> Implementation of "Foreign Function & Memory API" for s390x (Big Endian).
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Address suggestions from Jorn Vernee
-
Changes:
- all: https://git.openjdk.o
On Fri, 7 Jul 2023 19:35:53 GMT, Jorn Vernee wrote:
>> Yes, it does pass the test with above changes.
>
> Ok, please use the above changes instead then.
Sure, Thank you
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14801#discussion_r1256959506
On Fri, 7 Jul 2023 17:55:35 GMT, Jorn Vernee wrote:
>> Since s390x runs in Big Endian mode. We get LSB on higher address of
>> integer size.
>
> Ah, wait, now I see. The native side uses `int` as a type, but we try to load
> it as a `JAVA_BYTE`. I think this is a bug in the test. The Java side
On Fri, 7 Jul 2023 12:15:39 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> src/hotspot/cpu/s390/upcallLinker_s390.cpp line 141
On Fri, 7 Jul 2023 10:32:54 GMT, Jorn Vernee wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> test/jdk/java/foreign/TestClassLoaderFindNative.java
On Fri, 7 Jul 2023 08:53:06 GMT, Amit Kumar wrote:
>> sid8606 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address Amit's review comments
>
> Will run test, maybe you want to adopt these cha
> Implementation of "Foreign Function & Memory API" for s390x.
sid8606 has updated the pull request incrementally with one additional commit
since the last revision:
Address Amit's review comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1480
Implementation of "Foreign Function & Memory API" for s390x.
-
Commit messages:
- Fix whitespace errors and boilerplate text
- 8311630:[s390] Implementation of Foreign Function & Memory API (Preview)
Changes: https://git.openjdk.org/jdk/pull/14801/files
Webrev: https://webrevs.ope
39 matches
Mail list logo
