Integrated: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-22 Thread suchismith1993
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we ha

Integrated: JDK-8318175 : AIX PPC64: Handle alignment of double in structs

2023-11-22 Thread suchismith1993
On Thu, 9 Nov 2023 09:22:45 GMT, suchismith1993 wrote: > 1. use pragma directive to handle alignment. > > JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175) This pull request has now been integrated. Changeset: bf0a904f Author:suchismith Committer: Martin D

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-22 Thread suchismith1993
On Wed, 22 Nov 2023 06:50:07 GMT, Jorn Vernee wrote: >> suchismith1993 has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix Typos >> - Remove unnecessary includes > > Note that on Windows we also

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v8]

2023-11-22 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request incrementally with one additional commit since the last revision: Update s

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread suchismith1993
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >>

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request incrementally with two additional commits since the last revisi

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread suchismith1993
On Tue, 21 Nov 2023 17:50:04 GMT, Martin Doerr wrote: >> suchismith1993 has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Comments >> - Change comments > > src/java.base/aix/native/libsyslookup/sys

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request incrementally with two additional commits since the last revision: - Com

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v5]

2023-11-21 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request incrementally with two additional commits since the last revision: - Update Co

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v4]

2023-11-21 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request incrementally with two additional commits since the last revision: -

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v3]

2023-11-21 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request with a new target base due to a merge or a rebase. The pull request now cont

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v2]

2023-11-21 Thread suchismith1993
> > > 1. Adding required compiler flags. > 2. Adding required symbols. > > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) suchismith1993 has updated the pull request incrementally with 172 additional commits since the last revision: - Provide s

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-18 Thread suchismith1993
On Fri, 17 Nov 2023 15:39:49 GMT, Magnus Ihse Bursie wrote: > The syslookup.c solution for Windows looks interesting. While it is still a > hard-coded list, at least you will get compile time errors if the include > file changes to mismatch with the symbols... I don't think AIX has a way to

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread suchismith1993
stuff. > > My understanding is that a lot of symbols can be found out of the box because > they are in dynamically linked libraries. Only some libraries are special on > AIX which don't support dynamic linking and we need this workaround for them. > > @suchismith1993:

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-17 Thread suchismith1993
t;> symbols for math libraries. There were additional parsing instructions to >> remove the first column and remove periods at beginning. >> >> Then we had to remove certain symbols that are dependent on DFP symbols and >> xlc17 doesn't support them yet, So we had to trim down the l

RFR: JDK-8318175 : AIX PPC64: Handle alignment of double in structs

2023-11-14 Thread suchismith1993
1. use pragma directive to handle alignment. JBS Issue: [JDK-8318175](https://bugs.openjdk.org/browse/JDK-8318175) - Commit messages: - Remove trailing whitespaces - Handling alignment for double in AIX. Changes: https://git.openjdk.org/jdk/pull/16579/files Webrev:

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-13 Thread suchismith1993
On Mon, 13 Nov 2023 07:41:11 GMT, Alan Bateman wrote: > > There is not generic way of generating this. It needs a manual intervention > > and symbols are to be added on a need basis in future. Looks like a list to > > be maintained. I had tried adding comments to explain the list, but that >

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread suchismith1993
On Fri, 10 Nov 2023 15:48:59 GMT, Magnus Ihse Bursie wrote: > > Which directory do you suggest to put the exports list in ? Do we create a > > new directory or use any existing directory. > > My initial thinking is like Erik's, that this list should be dynamically > generated at build-time. I

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread suchismith1993
On Thu, 9 Nov 2023 17:46:20 GMT, Erik Joelsson wrote: > For some context: `java.lang.foreign.Linker.nativeLinker().defaultLookup()` > returns a `SymbolLookup` that can be used to find symbols from the standard > library. > > We use a shim library that re-exports symbols from the standard

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-10 Thread suchismith1993
On Wed, 8 Nov 2023 21:11:32 GMT, Magnus Ihse Bursie wrote: > First and foremost, the `make/data/hotspot-symbols` directory is, as the name > says, for hotspot symbols. These are not hotspot symbols. If you really do > need the file, then it needs to reside in a proper location. > > Secondly:

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-08 Thread suchismith1993
On Mon, 30 Oct 2023 10:54:48 GMT, suchismith1993 wrote: > 1. Adding required compiler flags. > 2. Adding required symbols. > > JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) Problem: There is syslookup file which expects the required symbols to be ex

RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols

2023-11-08 Thread suchismith1993
1. Adding required compiler flags. 2. Adding required symbols. JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799) - Commit messages: - Update symbols-aix-foreign - Symbol Resolution fix for Panama changes. Changes: https://git.openjdk.org/jdk/pull/16414/files