On Wed, 18 Jan 2023 13:20:06 GMT, Jonathan Dowland <jdowl...@openjdk.org> wrote:
> This is a fix for https://bugs.openjdk.org/browse/JDK-8300119 > (CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit > systems). Thanks to @jerboaa Severin Gehwolf for figuring out the solution. > > The problem is demonstrated by > test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java which fails on > 32-bit x86 in HEAD, and passes after applying this patch. > > I tested this on an amd64 system with a cross-compiled JDK. I needed to > override the default docker container for the test, to get one with a 32-bit > userland. (the precise choice was also dictated by ABI matching my main > development machine): > > > $JT_HOME/bin/jtreg -v -Djdk.test.docker.retain.image=true > -Djdk.test.docker.image.name=i386/debian > -Djdk.test.docker.image.version=testing-slim -jdk:$JAVA_HOME > test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java This pull request has now been integrated. Changeset: dea58efb Author: Jonathan Dowland <jdowl...@openjdk.org> Committer: Severin Gehwolf <sgehw...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/dea58efb6280bb1d94daf208ac909aa013439397 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8300119: CgroupMetrics.getTotalMemorySize0() can report invalid results on 32 bit systems Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk/pull/12069
