On Mon, 27 Feb 2023 08:19:53 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> JniObjWithEnv is a struct that is commonly managed by std::unique_ptr. > Although it can support managing objects that are not raw pointers, any such > objects have to be > [NullablePointers](https://en.cppreference.com/w/cpp/named_req/NullablePointer). > In the past this has [broken the build when compiler upgrades were carried > out](https://bugs.openjdk.org/browse/JDK-8244220), so we should add in the > final requirements to make the struct a true NullablePointer once and for > all, to prevent similar issues from happening in the future This pull request has now been integrated. Changeset: 50dc041e Author: Julian Waters <jwat...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/50dc041ee69eb62454bbf5c47a9545c6183d43d1 Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod 8303227: JniObjWithEnv should be NullablePointer compliant Reviewed-by: asemenyuk ------------- PR: https://git.openjdk.org/jdk/pull/12758
