Re: [jdk21] RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

2023-07-13 Thread Iris Clark
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote: > Please review this PR which backports > https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d > > Thank you Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/125#pul

Re: [jdk21] RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

2023-07-13 Thread Lance Andersen
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote: > Please review this PR which backports > https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d > > Thank you Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/125#p

Re: [jdk21] RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

2023-07-13 Thread Naoto Sato
On Thu, 13 Jul 2023 18:28:38 GMT, Justin Lu wrote: > Please review this PR which backports > https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d > > Thank you Marked as reviewed by naoto (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/125#pu

[jdk21] RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

2023-07-13 Thread Justin Lu
Please review this PR which backports https://github.com/openjdk/jdk/commit/6cb9ec32a68634f0b6f7461c9dc7ef0c0e59861d Thank you - Commit messages: - 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality Changes: https://git.openjdk.org/jdk21/pull/125/fil

Re: RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

2023-06-29 Thread Naoto Sato
On Thu, 29 Jun 2023 18:02:00 GMT, Justin Lu wrote: > Please review this PR, which clarifies the parameter description of > ChoiceFormat.setChoices(). > > `ChoiceFormat.setChoices(double[] limits, String[] formats)` claims that > `formats` can either be "Format objects or Strings". It also clai

RFR: 6960866: [Fmt-Ch] ChoiceFormat claims impossible and unimplemented functionality

2023-06-29 Thread Justin Lu
Please review this PR, which clarifies the parameter description of ChoiceFormat.setChoices(). `ChoiceFormat.setChoices(double[] limits, String[] formats)` claims that `formats` can either be "Format objects or Strings". It also claims that "When formatting with object Y, if the object is a Num