Re: RFR: 8041676: remove the java.compiler system property [v2]

2023-04-14 Thread Jaikiran Pai
> Can I please get a review of this change which removes the `java.compiler` > system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676. > > A CSR has been filed for this change and is available at > https://bugs.openjdk.org/browse/JDK-8305998. The CSR has more details about

Re: RFR: 8041676: remove the java.compiler system property [v2]

2023-04-14 Thread Roger Riggs
On Fri, 14 Apr 2023 14:21:56 GMT, Jaikiran Pai wrote: >> src/hotspot/share/runtime/arguments.cpp line 1313: >> >>> 1311: " use -Xint if you want to run the application in >>> interpreted-only mode."); >>> 1312: } else { >>> 1313: warning("The java.compiler system pro

Re: RFR: 8041676: remove the java.compiler system property [v2]

2023-04-14 Thread Jaikiran Pai
On Fri, 14 Apr 2023 14:26:24 GMT, Roger Riggs wrote: >> Hello Alan, >> >>> This looks okay although the warning for the empty value and "NONE" case >>> will probably wrap as it's very long. >> >> Agreed, it's a bit long. I can't think of a simpler message though. If >> anyone has a suggestion

Re: RFR: 8041676: remove the java.compiler system property [v2]

2023-04-14 Thread Roger Riggs
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes the `java.compiler` >> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676. >> >> A CSR has been filed for this change and is available at >> https://bugs.ope

Re: RFR: 8041676: remove the java.compiler system property [v2]

2023-04-14 Thread Iris Clark
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes the `java.compiler` >> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676. >> >> A CSR has been filed for this change and is available at >> https://bugs.ope

Re: RFR: 8041676: remove the java.compiler system property [v2]

2023-04-19 Thread Jaikiran Pai
On Fri, 14 Apr 2023 14:34:39 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which removes the `java.compiler` >> system property? This addresses https://bugs.openjdk.org/browse/JDK-8041676. >> >> A CSR has been filed for this change and is available at >> https://bugs.ope