> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Renamed local
On Wed, 26 Apr 2023 08:30:07 GMT, Raffaello Giulietti
wrote:
> No, that would not be correct. It would be subject to [double
> rounding](https://en.wikipedia.org/wiki/Rounding#Double_rounding), against
> the spec.
>
> For example, `BigDecimal` 1.00059604644775390626 should round to `float
On Wed, 26 Apr 2023 01:47:07 GMT, Joe Darcy wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 3749:
>
>> 37
On Wed, 26 Apr 2023 01:41:09 GMT, Joe Darcy wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 308:
>
>> 306
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Marked as reviewed by darcy (Reviewer).
-
PR Review: ht
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
src/java.base/share/classes/java/math/BigDecimal.java line 308:
> 30
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Keep it open
-
PR Comment: https://git.openjdk.org/jdk/
On Tue, 14 Feb 2023 14:07:22 GMT, Raffaello Giulietti
wrote:
>> Sorry, I overlooked those checks two times :)
>>
>> How about adding a moderate path like
>> [this](https://github.com/plokhotnyuk/jsoniter-scala/blob/6f702ce5cae05df91b5aa6e4bd61acdf43bf18f6/jsoniter-scala-core/jvm/src/main/scala
On Tue, 14 Feb 2023 08:02:08 GMT, Andriy Plokhotnyuk wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> Sorry, I overlooked those checks two times :)
>
> How about add
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Sorry, I failed to recognize those checks two times :)
How about add
On Mon, 13 Feb 2023 17:53:46 GMT, Andriy Plokhotnyuk wrote:
>> This PR is waiting for a review
>
> @rgiulietti Thanks for keeping making JDK faster!
>
> I have a couple of review comments:
>
> 1) For the line
> https://github.com/openjdk/jdk/pull/9410/files#diff-94d400b99466045dd76001c37e
On Tue, 31 Jan 2023 13:39:46 GMT, Raffaello Giulietti
wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> This PR is waiting for a review
@rgiulietti Thanks for keepin
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
This PR is waiting for a review
-
PR: https://git.openj
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
waiting for review
-
PR: https://git.openjdk.org/jdk/pu
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti
wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
waiting for review
-
PR: https://git.openjdk.org/jdk/pu
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
keep open, waiting for review
-
PR: https://git.openjdk.
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
keep open
-
PR: https://git.openjdk.org/jdk/pull/9410
On Thu, 21 Jul 2022 02:10:27 GMT, Julian Waters wrote:
>> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
>> performance, avoiding an intermediate string and its subsequent parsing on
>> the slow path.
>
> Impressive performance improvements, I also like the PR title :P
@Th
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
Impressive performance improvements, I also like the PR title :P
On Thu, 7 Jul 2022 15:20:32 GMT, Raffaello Giulietti wrote:
> A reimplementation of `BigDecimal.[double|float]Value()` to enhance
> performance, avoiding an intermediate string and its subsequent parsing on
> the slow path.
These are the improvements over the current implementation:
- Much mo
A reimplementation of `BigDecimal.[double|float]Value()` to enhance
performance, avoiding an intermediate string and its subsequent parsing on the
slow path.
-
Commit messages:
- 8205592: BigDecimal.doubleValue() is depressingly slow
Changes: https://git.openjdk.org/jdk/pull/9410/
21 matches
Mail list logo
