Re: RFR: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR [v5]

2023-03-30 Thread Justin Lu
On Wed, 29 Mar 2023 23:14:17 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - Impl cleanup, add Saturday end day conditional >> - Rename test, clarify test documentation >> - Add type to static dec

Re: RFR: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR [v5]

2023-03-29 Thread Naoto Sato
On Tue, 28 Mar 2023 21:06:34 GMT, Justin Lu wrote: >> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)` >> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and >> `DAY_OF_WEEK` combo. >> >> For example, Rolling _Monday, 30 December 2019_ by 1 week produced

Re: RFR: 8225641: Calendar.roll(int field) does not work correctly for WEEK_OF_YEAR [v5]

2023-03-28 Thread Justin Lu
> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)` > rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and > `DAY_OF_WEEK` combo. > > For example, Rolling _Monday, 30 December 2019_ by 1 week produced _Monday, > 31 December 2018_, which is incorrect. This is