Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing [v2]

2022-06-25 Thread Jaikiran Pai
On Sat, 25 Jun 2022 02:45:54 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which fixes an issue in >> `jdk.internal.jimage.ImageReader`? >> >> The `ImageReader` maintains a map of `nodes` which it uses to keep track of >> directories/resources from within the image.

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing [v2]

2022-06-25 Thread Jim Laskey
On Sat, 25 Jun 2022 02:45:54 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which fixes an issue in >> `jdk.internal.jimage.ImageReader`? >> >> The `ImageReader` maintains a map of `nodes` which it uses to keep track of >> directories/resources from within the image.

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing [v2]

2022-06-24 Thread Jaikiran Pai
> Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a `findNode` is called, it > leads to building the

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-24 Thread Daniel D . Daugherty
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-24 Thread Daniel D . Daugherty
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-24 Thread Alan Bateman
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

Re: RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-23 Thread Athijegannathan Sundararajan
On Thu, 23 Jun 2022 12:59:34 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which fixes an issue in > `jdk.internal.jimage.ImageReader`? > > The `ImageReader` maintains a map of `nodes` which it uses to keep track of > directories/resources from within the image. When a

RFR: 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing

2022-06-23 Thread Jaikiran Pai
Can I please get a review for this change which fixes an issue in `jdk.internal.jimage.ImageReader`? The `ImageReader` maintains a map of `nodes` which it uses to keep track of directories/resources from within the image. When a `findNode` is called, it leads to building the `Node` if the