Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Daniel Fuchs
On Mon, 27 Jun 2022 11:52:37 GMT, Thejasvi Voniadka wrote: >> This is a simple change to add some protective code to >> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more >> complete in the event of encountering an any exceptions while running. In >> the present state, the

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Alan Bateman
On Mon, 27 Jun 2022 11:52:37 GMT, Thejasvi Voniadka wrote: >> This is a simple change to add some protective code to >> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more >> complete in the event of encountering an any exceptions while running. In >> the present state, the

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Jaikiran Pai
On Mon, 27 Jun 2022 11:52:37 GMT, Thejasvi Voniadka wrote: >> This is a simple change to add some protective code to >> java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more >> complete in the event of encountering an any exceptions while running. In >> the present state, the

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Thejasvi Voniadka
On Mon, 27 Jun 2022 10:52:58 GMT, Thejasvi Voniadka wrote: >> test/jdk/java/util/zip/ZipFile/DeleteTempJar.java line 89: >> >>> 87: server.stop(0); >>> 88: } >>> 89: } >> >> Is there a reason to put the server.start in the try block, I would think >> this

Re: RFR: 8282036: [Test]: Update java/util/zip/ZipFile/DeleteTempJar.java to stop HttpServer cleanly in case of exceptions [v3]

2022-06-27 Thread Thejasvi Voniadka
> This is a simple change to add some protective code to > java/util/zip/ZipFile/DeleteTempJar.java so that the clean-up is more > complete in the event of encountering an any exceptions while running. In the > present state, the server.stop() does not get executed in case of > encountering a