Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v2]

2022-06-17 Thread Сергей Цыпанов
On Fri, 17 Jun 2022 06:27:12 GMT, liach wrote: >> Another approach would be to keep the parameter array and the boolean in a >> record, and mark the record field as stable, possibly like what's done in >> #6889. Keeping them in a record like: >> >> record ParameterData(Parameter[] parameters,

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v2]

2022-06-17 Thread liach
On Fri, 17 Jun 2022 06:14:32 GMT, liach wrote: >> src/java.base/share/classes/java/lang/reflect/Executable.java line 453: >> >>> 451: >>> 452: private transient boolean hasRealParameterData; >>> 453: private transient volatile Parameter[] parameters; >> >> These can probably be 

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v2]

2022-06-17 Thread liach
On Fri, 17 Jun 2022 05:34:25 GMT, ExE Boss wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8288327: Add clarifying comments > > src/java.base/share/classes/java/lang/reflect/Executable.java line 453: > >> 451:

Re: RFR: 8288327: Executable.hasRealParameterData should not be volatile [v2]

2022-06-16 Thread ExE Boss
On Mon, 13 Jun 2022 19:55:47 GMT, Сергей Цыпанов wrote: >> If there are two threads calling `Executable.hasRealParameterData()` under >> race and the first one writes into volatile `Executable.parameters` field >> (doing _releasing store_) and the second thread reads non-null value from >>